mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bagas Sanjaya <bagasdotme@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, stable@vger.kernel.org,
	lwn@lwn.net, jslaby@suse.cz, Jason Wang <wangborong@cdjrlc.com>
Subject: Re: Linux 4.14.294
Date: Thu, 22 Sep 2022 01:26:59 -0700	[thread overview]
Message-ID: <e4852207ed36662a7c53e36fbbc31a71c5a3396e.camel@perches.com> (raw)
In-Reply-To: <YywGcg/Qgf8B8wEj@kroah.com>

On Thu, 2022-09-22 at 08:53 +0200, Greg Kroah-Hartman wrote:
> On Thu, Sep 22, 2022 at 11:02:21AM +0700, Bagas Sanjaya wrote:
> > On 9/22/22 01:03, Joe Perches wrote:
> > > On Tue, 2022-09-20 at 12:17 +0200, Greg Kroah-Hartman wrote:
> > > []
> > > > diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.h b/drivers/hid/intel-ish-hid/ishtp-hid.h
> > > []
> > > > @@ -118,7 +118,7 @@ struct report_list {
> > > >   * @multi_packet_cnt:	Count of fragmented packet count
> > > >   *
> > > >   * This structure is used to store completion flags and per client data like
> > > > - * like report description, number of HID devices etc.
> > > > + * report description, number of HID devices etc.
> > > >   */
> > > >  struct ishtp_cl_data {
> > > >  	/* completion flags */
> > > 
> > > Needless backporting of typo fixes reduces confidence in the
> > > backport process.
> > > 
> > 
> > The upstream commit 94553f8a218540 ("HID: ishtp-hid-clientHID: ishtp-hid-client:
> > Fix comment typo") didn't Cc: stable, but got AUTOSELed [1].
> > 
> > I think we should only AUTOSEL patches that have explicit Cc: stable.
> 
> That's not how AUTOSEL works or why it is there at all, sorry.

Perhaps not, but why is AUTOSEL choosing this and why is
this being applied without apparent human review?


  reply	other threads:[~2022-09-22  8:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 10:17 Greg Kroah-Hartman
2022-09-20 10:17 ` Greg Kroah-Hartman
2022-09-21 18:03   ` Joe Perches
2022-09-22  4:02     ` Bagas Sanjaya
2022-09-22  6:53       ` Greg Kroah-Hartman
2022-09-22  8:26         ` Joe Perches [this message]
2022-09-22  8:32           ` Greg Kroah-Hartman
2022-09-22  8:39             ` Joe Perches
2022-09-24 18:21               ` stable-kernel-rules need updating? " Pavel Machek
2022-09-25  1:49                 ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4852207ed36662a7c53e36fbbc31a71c5a3396e.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=bagasdotme@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lwn@lwn.net \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=wangborong@cdjrlc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®