From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4BD3C2BC61 for ; Tue, 30 Oct 2018 16:04:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5B4E20664 for ; Tue, 30 Oct 2018 16:04:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5B4E20664 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727688AbeJaA63 (ORCPT ); Tue, 30 Oct 2018 20:58:29 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:37613 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbeJaA63 (ORCPT ); Tue, 30 Oct 2018 20:58:29 -0400 Received: by mail-wm1-f66.google.com with SMTP id p2-v6so11830966wmc.2 for ; Tue, 30 Oct 2018 09:04:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BYnaQcLx06HAjRIELsZiqQrtQWk7Prf2bT5hLFZ6RWo=; b=AOLPDEcMXd81R2gRTw0NCPWIFzyLutp0nNDjVghWM0iuCla0zvsTN7hC56YxqNYQi+ xn1vEynPeRaF+4zujCmpiOF7Ss4yGZumsJ2B2NOPIWgsH+bA2LozkC9aGprhhWEwCD4c 99PGY5l7smkrOFL1REMmPw+gr2yLOsq1NmixXpshqdcF/GWsVycAeSNh4GS2z3vz7ZDp Ocr5rnslitOqq+C80nVAdXhwOjb/WNxkpE10VsVKSkOjpSYfm7zI73aktnjSBr7gR4OC evHtBKSzDVT+WzMs/5fuPx/l9xHuQpMmlptP1QEy/bi+8TlOwXFjl3y1pdQOmBFRfqIo Nqwg== X-Gm-Message-State: AGRZ1gIwil+EbHoYdrTXk0FZgp+jG+9i5Qtadnow1hcNlDgrZd6J3kp4 O7J2xI62EYnZD0MuzR7dxLxAaQ== X-Google-Smtp-Source: AJdET5dEDKa6jBiSy5bWFKgIJp4T5zvz2dpCwA6wPocNa+16dik7U9eULEvZEf3PmvOlJ2t3DqOJEQ== X-Received: by 2002:a1c:930c:: with SMTP id v12-v6mr2374554wmd.9.1540915464389; Tue, 30 Oct 2018 09:04:24 -0700 (PDT) Received: from shalem.localdomain (546A5441.cm-12-3b.dynamic.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id l125-v6sm19653447wmb.1.2018.10.30.09.04.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Oct 2018 09:04:23 -0700 (PDT) Subject: Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL) From: Hans de Goede To: Pierre-Louis Bossart , Dean Wallace Cc: Andy Shevchenko , Stephen Boyd , Michael Turquette , linux-clk , Stable , Johannes Stezenbach , Carlo Caione , Andy Shevchenko , Linux Kernel Mailing List , Mogens Jensen References: <20181025232517.ywnw54qibemosjws@picard> <154083512089.98144.9141070901932719147@swboyd.mtv.corp.google.com> <20181029190819.2ivlx73n6y6sx4vk@picard> <20181030143836.feo7zcxiestylxoo@picard> <2d429c87-24c5-4075-683e-b0d12c3eb1c2@linux.intel.com> Message-ID: Date: Tue, 30 Oct 2018 17:04:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 30-10-18 16:46, Hans de Goede wrote: > Hi, > > On 30-10-18 16:04, Pierre-Louis Bossart wrote: >> In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a cht_bsw_max98090_ti to use plt_clk0 only would break other devices (e.g. Rambi/Orco). Asking for both clocks to be on might work though, > > Ok, so we need to have a DMI based quirk for the Swanky and maybe also > the clapper to use plt_clk_0 there. Asking for 2 clks if we only need > one does not seem like a good plan. Dean, Mogens, To write a proper patch for this I'm going to need DMI strings from your devices. Can you please run (as normal user): grep . /sys/class/dmi/id/* 2> /dev/null And reply with the output of this command? Thanks, Hans