From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C68EF195FCE for ; Sat, 16 Nov 2024 10:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731753630; cv=none; b=L1SlG4o1MZM6/1K4pDbrxB4v/PVlY1Mjx9w7/h03kQ3e+ObjMbYPuPyRWmXtmPKOj4adcoZKc0pSCA9ZxFywCwQXi25EXrgxA6rFYy0qx+VM1bfv6lMwWwr4nBLRQDTI+/EVCbAqJM/CGlWNWdNhqEezxUpK9NiQ6yKvXrMfL8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731753630; c=relaxed/simple; bh=CZEDUO5w9mPwObdkuTZxxGHeinVe6UhoG9nSbMiKlmc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VNES0KAGy2YdL00mOlW3uny7pRPkossPWadbHTiUWehuLdJx333q0SBZHI4ET7TMtMMmmOZaVaSACrmnsrw19uvObnRzzb8BAoU57X9w9xlCtxBf7UyPMmXUQwhSX/T87ilZAF828F7LvbQhzZkyoUSSj3ZujfQU7dDcmXBfDfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lOr0EAjs; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lOr0EAjs" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4319399a411so23112265e9.2 for ; Sat, 16 Nov 2024 02:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731753625; x=1732358425; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lSXFKM+ARjNBrckMO4jvpnEJoLVPjxN4kzAqYuwUUFc=; b=lOr0EAjsUTAs6wseY7V+KzGhBBAXZjQYXBU14sNlc1/O14eQQDJCcDwJbQy+ynWh8x qKYSwPKpD7hcY0em48Te+P6WgHqpu35ge0ehJQrBAIwLV1o/SBjRh/ZvjU5NZx3gT3tx Nb38XmMu1sSYZHZzBe1pPSA9zGPHDMFrcWnOK8hwpIeEoHXm17i4bbYBHX+fxtfFub7t AB/CIVUbhnAeSjtIwo5fLTeP/BEbRiasgOp5c9vKI4IN/cC9WOknw2cJK5jw1NCqW0qW 50KI5IcyLcTqE0QRBK6ox2Z0l0vIcy/2tB1dBDoupmjqhuAI6LvRvVPAP/W62p1Msp52 PaIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731753625; x=1732358425; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lSXFKM+ARjNBrckMO4jvpnEJoLVPjxN4kzAqYuwUUFc=; b=phRBigPyOJ8phhy4rkUJS80j4BwoNhiGzM3IFix8vN0nTb3zmbd1H5mqaLOqj/5O/G 4V+c3E/qctrnKfrQOq8Av7QGgE/7Z0dOy5uTot0x9ijRb68m6gyLvsITWt85Wclccu/A kvTZWx2RSVTDvq4kiWMUzZeuTNwoZvUCN49h05SHfJTCszw6pij/ynqnx9xiZLoOAyba IXS1vMd6DuNwSduVmBsLU2CoxqppUdLD/lGbcTPNJ2v1AXCZ/kaL2e47d9OTkAC5D2lI jFPVOow6sXeYQJwr+DA8FK+F7cO9oDUTMddseILV1f+bUc4p8AX/2RMLdC01yiBEhzIK ogiA== X-Forwarded-Encrypted: i=1; AJvYcCXUahGM2LSidN/9Oe1LrZ+25SAC23xfr6VLFuJqteW6XP9EJ43WHgDs2ZYC71oEFPypS0s97EvKU0QjaiQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxfiTGMwKAfldMFvyBB6SetobUsElDnIOvqt/2iGKoei872z9SX P2ilIbVaSKCwzb45P6v0K9we6g1m90u4n62FcxPwr+lKdgAAE/qQ6kFP9DavKr0= X-Google-Smtp-Source: AGHT+IH8fBA+4s5F3P6X/kjn5LT5A4plOne9CKmDoZ8QUK+uLzjM3K0QAglApJbsapoZYtb9Ft2RHQ== X-Received: by 2002:a05:600c:1d1c:b0:431:4e82:ffa6 with SMTP id 5b1f17b1804b1-432df78c5b5mr46184285e9.24.1731753625076; Sat, 16 Nov 2024 02:40:25 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432da2800absm87243245e9.25.2024.11.16.02.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 02:40:24 -0800 (PST) Date: Sat, 16 Nov 2024 13:40:20 +0300 From: Dan Carpenter To: Christophe Leroy Cc: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v2 05/21] powerpc/papr_scm: Convert timeouts to secs_to_jiffies() Message-ID: References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-5-911fb7595e79@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Nov 16, 2024 at 11:06:55AM +0100, Christophe Leroy wrote: > > diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c > > index 9e297f88adc5d97d4dc7b267b0bfebd58e5cf193..9e8086ec66e0f0e555ac27933854c06cfcf91a04 100644 > > --- a/arch/powerpc/platforms/pseries/papr_scm.c > > +++ b/arch/powerpc/platforms/pseries/papr_scm.c > > @@ -543,7 +543,7 @@ static int drc_pmem_query_health(struct papr_scm_priv *p) > > > > /* Jiffies offset for which the health data is assumed to be same */ > > cache_timeout = p->lasthealth_jiffies + > > - msecs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL * 1000); > > + secs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL); > > Wouldn't it now fit on a single line ? > Some maintainers still prefer to put a line break at 80 characters. It's kind of a nightmare for an automated script like this to figure out everyone's preferences. In this particular file, there are some lines which go over 80 characters so sure. Earlier in the patchset one of these introduced a line break that wasn't there before so I think maybe Coccinelle is applying the 80 character line break rule? There are sometimes where the 80 character rule really hurts readability, but here it doesn't make any difference. regards, dan carpenter