From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBED9C433EF for ; Tue, 19 Apr 2022 08:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350117AbiDSIub (ORCPT ); Tue, 19 Apr 2022 04:50:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235794AbiDSIu2 (ORCPT ); Tue, 19 Apr 2022 04:50:28 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7781BDFED for ; Tue, 19 Apr 2022 01:47:45 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id t1so21454169wra.4 for ; Tue, 19 Apr 2022 01:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=3zfxgfhhkGrdZQPttYFIyDKGOpAjycnaX8YYYe3nvMs=; b=QMuKTTF4XAeRFnDlBJHu27U50iu6XBNoG05MeKFeLU7LsVVjUcV3ejaRRo+hmzy4HE 8RGR84YLIk71QD5AQiyRP+u8oMQokSNGjOV2GeZzTXIeNHMYrl62RYagKfoW7/4BX+KF C9hVR3VkHU0ESauWkgoubLwV7f0N8V8CxKFQOSGTKkkgEfNubRFW8kfT801AsfBDEl8X broAjmmh0Unod0xRCJh7b138tc2H80Cnl9U7AdllLIwQddcei+hpFnZERUtovQtlRIg6 YAxxTykq5evBHh9fJaw2Sx8sp2Rao0lkkWMBCyOUCVh/qrBePzCPZAAaTK7uhf4Xw479 BJ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3zfxgfhhkGrdZQPttYFIyDKGOpAjycnaX8YYYe3nvMs=; b=EZLOL/Gzno0gNs0FVNQwldo42cInKWbBMmAAjxbyh3rUCfbHif896efAxnrwxb0ev4 Kk0ZpDc+0ndxOMo0CuyE89LsULiHzzOBxelPz+IrseO6i28QgNdSxADwk2QErjypkhsc 6mS746xvShzc/bL17vBzuW13nubwCF1wYNSocG51HxnR8ZbNDpML6S5sqJaPk4GG1wbS KBONsYZl+Da+lT8gUvQsyfqrOKAnzjeRME7gv8580B2SW0bFB597sAXYDYqX62+1v1T1 jGrNfPF/r8TnPlLmbFH2T5RteBVglcx85kT/XlxG+THkakW7aLYxbNwYpzCz1VztjYVJ GQ8g== X-Gm-Message-State: AOAM530UlwxB/pk03kVDXJafLeKlUMeQ21kKQ9nBKJJ+ItcXmRGszcCs eEJBOky8rkkq4zmEdUt4dx/j/A== X-Google-Smtp-Source: ABdhPJyGYvopwBZKM+g01h8Kn+VxX+cUxfwLusUKA6MiYSG6VWvCuPXWxSd3hPj8JfuBmWdc2LElng== X-Received: by 2002:adf:dd8a:0:b0:207:9e5f:fd0a with SMTP id x10-20020adfdd8a000000b002079e5ffd0amr10553750wrl.94.1650358064065; Tue, 19 Apr 2022 01:47:44 -0700 (PDT) Received: from [192.168.86.34] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id g8-20020a5d4888000000b00207a49fa6a1sm14168011wrq.81.2022.04.19.01.47.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 01:47:43 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 09:47:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH -next] slimbus: qcom: Remove unnecessary print function dev_err() Content-Language: en-US To: Yang Li , agross@kernel.org Cc: bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20220414014430.19051-1-yang.lee@linux.alibaba.com> From: Srinivas Kandagatla In-Reply-To: <20220414014430.19051-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/2022 02:44, Yang Li wrote: > The print function dev_err() is redundant because > platform_get_irq_byname() already prints an error. > > Eliminate the follow coccicheck warning: > ./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because > platform_get_irq() already prints an error > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Applied thanks, --srini > --- > drivers/slimbus/qcom-ctrl.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c > index ec58091fc948..c0c4f895d76e 100644 > --- a/drivers/slimbus/qcom-ctrl.c > +++ b/drivers/slimbus/qcom-ctrl.c > @@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev) > } > > ctrl->irq = platform_get_irq(pdev, 0); > - if (ctrl->irq < 0) { > - dev_err(&pdev->dev, "no slimbus IRQ\n"); > + if (ctrl->irq < 0) > return ctrl->irq; > - } > > sctrl = &ctrl->ctrl; > sctrl->dev = &pdev->dev;