Re: [PATCH] drivers: base: power: Use of_clk_get_parent_count()

[Kefeng Wang <wangkefeng.wang@huawei.com>]

On 2019/5/27 19:08, Geert Uytterhoeven wrote:
> Hi Kefeng,
>
> On Sat, May 25, 2019 at 1:54 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> Use of_clk_get_parent_count() instead of open coding.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Thanks for your patch!
>
>> --- a/drivers/base/power/clock_ops.c
>> +++ b/drivers/base/power/clock_ops.c
>> @@ -195,8 +195,7 @@ int of_pm_clk_add_clks(struct device *dev)
>>         if (!dev || !dev->of_node)
>>                 return -EINVAL;
>>
>> -       count = of_count_phandle_with_args(dev->of_node, "clocks",
>> -                                          "#clock-cells");
>> +       count = of_clk_get_parent_count(dev->of_node);
>>         if (count <= 0)
>>                 return -ENODEV;
>
> Given of_clk_get_parent_count() is provided by <linux/of_clk.h>, I think
> you should add an include for that.
Thanks for your kind suggestion, v2 has been sent with the head and your reviewed-by.
>
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>