From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2E143596F1 for ; Sat, 21 Feb 2026 17:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771693635; cv=none; b=YG9ENNhsiIkKtUmUOf5xoO4cQtz4Z0Znb8bpAYO69XZ/SVyUshE20MFST553n2xIegtCJlU5bmNunDCojXozK0l5xPeFd24PRMHLgy2HfvqYzaV164Uzdtg5m52geyPLlkETviv8oovYEC2ueFAWMu9Nqg4gml4YA/gRAYDHyDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771693635; c=relaxed/simple; bh=7hX5ObVgc+z5d80aOlRN7dM27T5qBFbqi0RU0q7F6FA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OC52Dk8aKYXFpm7Bx1Mx4faISP11yrjH3LXhxDLzN92r6MCBrRE76YcOPvI2rQMUUjqTTq7L5onZkMYlZwKbcCdz0yzOp2F554pn3WbaKSuKt44hXNWCBkug1EJ2lVImOXYbszeHFV6W2UrGmT+VyN1QKxdgJDLBVpjllEA/Noo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Sd7KUom3; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Sd7KUom3" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7d4be94eeacso2686234a34.2 for ; Sat, 21 Feb 2026 09:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771693631; x=1772298431; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Zs4ezPRFXzZ0tFdqRXtRb0zbUDD8vrtMcp60HCD0xbw=; b=Sd7KUom3cu4nGKq8U2v3nkkTEZDsxEnpTwLGp6aPkkUODxb90c6rsb7WYwX8fXiLrM OGhXEdleHOTZCIwSY6oLFAAFdjntGRUbJ4Ropv5Y+8AUWDWIGBc3BqTe8wITc91uNQL3 RyGzQyGOEGAsDKJ/McUjT6tJA9o4XTWD8+N0LFibvSnFjb2MHa2PMj3Si+IWhs3JmpYN JoRAqQSI1kaB8W4Z45ZC6ZxFtdYMdYxrOMZzOXk1AL3BSVQmuqbECoNIxRj7907G9fKs stvQx7EbMDx8Yb3JjS7gHelV/DK9DGyvCm2gIYXoG6g0ZNIJjw8qJaOGnAEkYbqwxwm1 +jHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771693631; x=1772298431; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zs4ezPRFXzZ0tFdqRXtRb0zbUDD8vrtMcp60HCD0xbw=; b=pEsOWOheDmfx/ypYwQXZp8DO1Kh1GbCfJs96WUVkYXdJU8jIdIfMkYUE39P6wZ50bH D9gYidHyCVdFvptCm9nbMHQ/SR7iZT16DQQH/BSHfCPp9+8d7KEkVo36SUmdsIGf2hEG dHCYVRoPEL+i/etc1EFrMV2ZuEZ4EZFWyFYxAOzdsozOtuFsO2Tlnw2CwfDXBet1SATn b2p0b1RaykaU6CoR7R2zHBCZJnM5HSlqNeM8ZuouMX5JrCMwm0qx1iwTEBVW4QJpCIH2 I50csNl3hTYmALYE3n4MHEDpQs0j2+EkmnZ9/7aT11F2ieDLDOw/uG0EsyjgtCRqMZ7I 6PWA== X-Forwarded-Encrypted: i=1; AJvYcCVer0oTnK98cNUehA85TTrjsB5yTrkb7qZ/Iu8vQTOssg+py2gOpG27ljh+FbyjPWIs6G03JDuTrl+dhTE=@vger.kernel.org X-Gm-Message-State: AOJu0YxpJK7jDfQabxepss7rmdTq2sS7B08aLi1aAKnwl7g5M/49WYqG 8QKZSFyH42hrcAFRb38myTotvCZAw3V4AqQrT2OCcHPZO496tfmHEwf16ThS9jpDJDg= X-Gm-Gg: AZuq6aLs173SUdUbEv1wkbgOr+DI2Z7mGK0AwmVdT8tt+IK42/p2ZM6XSIQOmKnNPJH +ZeIgF/H6jZTkSKYw9+O3NO1po0cOTtfS5A//It2cqAQhJLv8p2g8Ws12XYHBnLHHiSkkKiv+jR s1reW9RO58B6L800Kvp02c9eI2bRUb6paXHxQXnaFJN0e299JXi9fpipraBpvtVkHmbZVtRU0tK Sei8962YfzYL7Wp+zoHYpruk3a7vG0pLM659wpk17BRo08lLqZF2ZEx6sr3uJk+mDUZHacC45E5 eMN8fiOeqficiH7lBepwUjhA3M3xxwi6LydwAqRFGlIXpvNKTlrxqTbWH5sOhj8zKJUircm/geI 1uITr4pM8KmN/3h0dARXyRhB48fppO1BIsxtVqAPhMEc7fnXIr38BENUvFK6uh9nKKKdLUbGirr 8GvW1hqEtZwSDpYX215WyiYL9Ik9wHNIjZKpYFiYIuHsWGJYBShlyfzcb5seu6TJaXlsrH+p4pJ nVCz4+l X-Received: by 2002:a05:6830:6a92:b0:7cf:dbb4:320a with SMTP id 46e09a7af769-7d52bfbc92emr2199243a34.27.1771693631566; Sat, 21 Feb 2026 09:07:11 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:611:96af:f385:64bf? ([2600:8803:e7e4:500:611:96af:f385:64bf]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d52d0725b9sm2787850a34.26.2026.02.21.09.07.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Feb 2026 09:07:11 -0800 (PST) Message-ID: Date: Sat, 21 Feb 2026 11:07:10 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] iio: core: Clean up device correctly on viio_trigger_alloc() failure To: Salah Triki , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260221073301.105080-1-salah.triki@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260221073301.105080-1-salah.triki@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/21/26 1:32 AM, Salah Triki wrote: > Once we called device_initialize() we have to call put_device() > on it. Refactor the code to make it in the right order. This could be a bit more clear. Something like ... Move device_initialize() after all error paths in viio_trigger_alloc(). Previously, we should have been calling put_device() on any error path after device_initialize(), but failed to do so. Rather than adding put_device(), we can just move device_initialize() to avoid needing to unwind it on error. Additional trig->dev initialization is also moved with this just to keep the code organized. > Did we decide this doesn't need a Fixes: tag? > Signed-off-by: Salah Triki > --- No need to send a new revision for this right away. If Jonathan is in the mood, he might fix it up for you. With the commit message improved: Reviewed-by: David Lechner