From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECD9B3DCDB9 for ; Tue, 31 Mar 2026 12:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774959340; cv=none; b=O0+o8FaAkFB9EIZiXKT/F/bh5VsD0+iZ9xP9qiS2VDvq9bRR7UHZl2k7Oo4ASdIdd2AeXIOtGu9GZKWuUntDlHXgD5W7lxgqyBSkdzh3oLcDHSzgGkdeXYRz8iql53AXYb2iT9c829iP5dOtDezg+yZahuDejFw3WYnqPzNb5Yk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774959340; c=relaxed/simple; bh=hm4Ma4vk+10ks06oT9jA01taD0hMQ0Lh4zE2mDsbYuo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nOU+eW5/C7csYi87fJUc9riEt35mKSydNr14dQ+ijgDwPTlcS9bSNVs4lCaApMo0hCAozDPviyNJjfNHe0qNtrPgfA7h6QOWphZoyNjkn7neUKJB9AeBQbsoFfHBMvglVEZXDPmy8qbd6xi0mo1vZ3cfj/spLkpSt6zVXMxLuyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=L++l8eWj; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="L++l8eWj" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48704db565eso71196405e9.1 for ; Tue, 31 Mar 2026 05:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774959337; x=1775564137; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+Xo3ZpJ8Dl2Flz8g5rck0pTn62dakfIgnmjeFgZwkBg=; b=L++l8eWjAIUre+OMPfxRLQcPmBGlFeCOBJdS8p8Yx+cKCmrHeMZyq4gDIieYqbTwze 0kkCoNKjH/nVA+XjoGKx/LCkwnWOw/i5fqS5TAuEru1OdpyB2P57NktAfzxWpcq6GVI9 0+D/ZyjYPNQD0D834up+foTNWwdSTEKX7u3MlPPjmA5TyNx2KGww6RrtJWciGMCKTP/a kDEB6VSU5Jsnx06xs5rcuKyQviDzKGJ5/qNJYeHvBI7a25g6xoPY9q7M7+IhTZC0n0lJ LVnvDdFVCv6pYMRPpRtI6SiTeJCh7jRzioXgxQJaaynni5daA3fhbkegu/EiRbCDrJlb W0Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774959337; x=1775564137; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+Xo3ZpJ8Dl2Flz8g5rck0pTn62dakfIgnmjeFgZwkBg=; b=Y+k3whKU0KJM7eNiA/mffLgZuPt+FLpiBjk1B+em/PreBTtOOyUSmRfQbrxDDrjhjV cK/u258kh101RJDdXlQNNBtXWDhdHNe//q2R+mw7YwGplGknty2JTB9wm2cOY+PcM0fm vftdLhzbilLOUHXo5ECeLKgxt52ZU/FWsI27NKulKJImS0bQad5m6ErbwKSUCFm43v+u HUSEnD7IfkB2xahzbgvbaWYpdz/24WXCEAYzF98lI9dE8emUZ7b5rKZl/0De8SkdJKHv qFmABfduJiYIrYAAWy7SSQULuCjQP75k+BwnPugyVsFTvGtHAlhrohlJDVxWbYVOYPU+ 7cbw== X-Forwarded-Encrypted: i=1; AJvYcCUwqN2Dn0a2EErPwwey8oFK5Ot3pEPyq92M0MhzoGo0kxm01xGEN3YlyqlE7uLbKrkhzdBrsurnNqSsakU=@vger.kernel.org X-Gm-Message-State: AOJu0YwWNWZd5Q/MkYFXmOPUoYAag0hKRX7qd5hIHwnrVS4vGr4Af3n0 790A+lZEusfMi+PKDDcdisON+fVOGqqQGizu+hI+UGNSJQfdKLGwqu36P9LwvObFxuM= X-Gm-Gg: ATEYQzyZjfWoW/HO8wBDMV/YAgOQeuoqUriTh5RHb6C10b32TpkwNPJWBvv3JPnEWIp UwCkVDTNZSIb0QxaRxTNWHQzFtWEFjtPaPVJVMsmoARuxnflrB1yCCGJWr4Cou7Ht7nhMOuXZho uwl1I8kvaVbUC1VkOKkt0ycVbColBr0QTZ5KSFVRm0+ZqkTny568nmnobOvK1ehatesWXjaROD9 Wd/gFLueDulc1Dhe1xCpvcMdATxv7KZBjVJZc1eO69hZ9IuTbVIWmNtR6dYYS2EDaCJdeReFbat ieKCvB9KBFFoct0ptmLkWlWfU4gb5ymA669hV1cgN4yNMnIS0Zm3Krth5Vu6PeFJ5GTxBiFyjwi OteDW4T9yCgjUAA7pSoJ9fC67wYB1t/qYvx8OtRE0frlmjML/m9qbA4xzMTndKYb3/GuofybM2S T9BTi7OWn1ZCzXIGKkrYhhkH/EFZi682jB4HG26JdruIoBdVFn53JJQrRkrXh03bj5vts= X-Received: by 2002:a05:600c:3b24:b0:485:6ec7:2df with SMTP id 5b1f17b1804b1-48727d5f7a5mr278725665e9.8.1774959337174; Tue, 31 Mar 2026 05:15:37 -0700 (PDT) Received: from ?IPV6:2001:a61:1379:a401:6839:7a39:6f33:47c7? ([2001:a61:1379:a401:6839:7a39:6f33:47c7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887a630901sm25614755e9.0.2026.03.31.05.15.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 05:15:36 -0700 (PDT) Message-ID: Date: Tue, 31 Mar 2026 14:15:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] usb: misc: usbio: Fix URB memory leak on submit failure To: Felix Gu , Israel Cepeda , Hans de Goede , Sakari Ailus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260331-usbio-v2-1-d8c48dad9463@gmail.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20260331-usbio-v2-1-d8c48dad9463@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31.03.26 14:05, Felix Gu wrote: > When usb_submit_urb() fails in usbio_probe(), the previously allocated > URB is never freed, causing a memory leak. > > Fix this by jumping to err_free_urb label to properly release the URB > on the error path. > > Fixes: 121a0f839dbb ("usb: misc: Add Intel USBIO bridge driver") > Signed-off-by: Felix Gu Reviewed-by: Oliver Neukum