mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Tuo <islituo@gmail.com>
To: maximlevitsky@gmail.com, oakad@yahoo.com, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	baijiaju1990@gmail.com
Subject: [BUG] memstick: rtsx_usb_ms: possible uninitialized-variable access in rtsx_usb_ms_issue_cmd()
Date: Sat, 31 Jul 2021 14:36:49 +0800	[thread overview]
Message-ID: <e49e0ad5-d09d-4fa7-12a9-0608d9c9d800@gmail.com> (raw)

Hello,

Our static analysis tool finds a possible uninitialized-variable access 
in the memstick driver in Linux 5.14.0-rc3:

At the beginning of the function rtsx_usb_ms_issue_cmd(), the variable 
int_reg is not initialized.
If the following condition is true, it remains uninitialized.
469:    if (req->long_data)

However, it is accessed in some statements such as:
491:    if (int_reg & MS_INT_CMDNK)

I am not quite sure whether this possible uninitialized-variable access 
is real and how to fix it if it is real.
Any feedback would be appreciated, thanks!

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>

Best wishes,
Tuo Li

                 reply	other threads:[~2021-07-31  6:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e49e0ad5-d09d-4fa7-12a9-0608d9c9d800@gmail.com \
    --to=islituo@gmail.com \
    --cc=baijiaju1990@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=oakad@yahoo.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®