From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751035AbdIKKJr (ORCPT ); Mon, 11 Sep 2017 06:09:47 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:33708 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbdIKKJp (ORCPT ); Mon, 11 Sep 2017 06:09:45 -0400 X-Google-Smtp-Source: AOwi7QCcXPPJtdQHebRHaZQn2GP5YOiwbPPP8RDypYmDMiiYeBkhqa3LKuG/jJSTf9hxVBHnpqbIDQ== Subject: Re: [PATCH 3/5] staging: typec: pd: Document struct pd_message To: Guenter Roeck , Greg Kroah-Hartman Cc: Heikki Krogerus , Yueyao Zhu , Badhri Jagan Sridharan , Hans de Goede , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org References: <1505075825-15700-1-git-send-email-linux@roeck-us.net> <1505075825-15700-3-git-send-email-linux@roeck-us.net> From: Sergei Shtylyov Message-ID: Date: Mon, 11 Sep 2017 13:09:42 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1505075825-15700-3-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 9/10/2017 11:37 PM, Guenter Roeck wrote: > struct pd_message is the format of a PD message as seen on the wire. > > Signed-off-by: Guenter Roeck > --- > drivers/staging/typec/pd.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/staging/typec/pd.h b/drivers/staging/typec/pd.h > index 30b32ad72acd..42a10883a2cb 100644 > --- a/drivers/staging/typec/pd.h > +++ b/drivers/staging/typec/pd.h > @@ -104,6 +104,11 @@ static inline unsigned int pd_header_msgid_le(__le16 header) > > #define PD_MAX_PAYLOAD 7 > > +/* The kernel-doc comments (to which this comment looks alike) should start with /**. > + * struct pd_message - PD message as seen on wire > + * @header: PD message header > + * @payload: PD message payload > + */ > struct pd_message { > __le16 header; > __le32 payload[PD_MAX_PAYLOAD]; MBR, Sergei