From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA044C4727E for ; Wed, 30 Sep 2020 14:11:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D0BA2076B for ; Wed, 30 Sep 2020 14:11:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="hvDPSp5E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730537AbgI3OLL (ORCPT ); Wed, 30 Sep 2020 10:11:11 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:57368 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730188AbgI3OLK (ORCPT ); Wed, 30 Sep 2020 10:11:10 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08UE41ir152392; Wed, 30 Sep 2020 14:11:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=vzEB3YJL3N7wUcPuw7796PUa/Oe8OTJqZE6lGZWzKqY=; b=hvDPSp5EhGQJBANchZKLY9BN/2RajUpy7MAOl1FT0qS96URst14atzsaQLLhOVBEkgie Ife4/GwLspGlEAynhNApm5lGyMegsZbhvnf0akBK3ufi6ekM3s8sPmRIxxma9zqNaih5 fJN68a9WI3Tzk/Q/XeawZyZMpUgII6nSHcF5m2176cXHwJvTuunYua0sEaLNkwYARGmp i43Th00WXm/PpFfGHAz5i97/ysflCIx52mGX9uHrl0kdxppPpkS4QE5QE55n9ce/c4sE oIQFiqlX/LWn+liIGnSE7GRnb51oNQCx2PSJLJP3yX6SCH9rtP+rSmBWBoAbEq0d5O8l Lw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 33su5b0t1n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 30 Sep 2020 14:10:59 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08UEAngu185133; Wed, 30 Sep 2020 14:10:59 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 33tfdtyuu6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Sep 2020 14:10:58 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08UEAviB028625; Wed, 30 Sep 2020 14:10:57 GMT Received: from [10.74.86.12] (/10.74.86.12) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 Sep 2020 07:10:57 -0700 Subject: Re: [PATCH 2/2] xen/gntdev.c: Convert get_user_pages*() to pin_user_pages*() To: Souptick Joarder Cc: Juergen Gross , sstabellini@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, John Hubbard References: <1599375114-32360-1-git-send-email-jrdr.linux@gmail.com> <1599375114-32360-2-git-send-email-jrdr.linux@gmail.com> <8a608871-af25-fee6-24ea-24d78010cd6c@oracle.com> From: boris.ostrovsky@oracle.com Organization: Oracle Corporation Message-ID: Date: Wed, 30 Sep 2020 10:10:55 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9759 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300113 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9759 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 mlxscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300112 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/29/20 10:14 PM, Souptick Joarder wrote: > On Tue, Sep 29, 2020 at 6:00 PM wrote: >> >> >> On 9/29/20 8:09 AM, Souptick Joarder wrote: >>> On Fri, Sep 11, 2020 at 8:12 PM wrote: >>>> >>>> On 9/6/20 2:51 AM, Souptick Joarder wrote: >>>>> In 2019, we introduced pin_user_pages*() and now we are converting >>>>> get_user_pages*() to the new API as appropriate. [1] & [2] could >>>>> be referred for more information. This is case 5 as per document [1]. >>>>> >>>>> [1] Documentation/core-api/pin_user_pages.rst >>>>> >>>>> [2] "Explicit pinning of user-space pages": >>>>> https://lwn.net/Articles/807108/ >>>>> >>>>> Signed-off-by: Souptick Joarder >>>>> Cc: John Hubbard >>>>> Cc: Boris Ostrovsky >>>>> Cc: Juergen Gross >>>>> Cc: David Vrabel >>>> >>>> Reviewed-by: Boris Ostrovsky >>> Are these 2 patches queued for 5.10-rc1 ? >> >> >> Yes, I am preparing the branch. (BTW, your second patch appears to have been either manually edited or not generated on top of the first patch. Please don't do this next time) > > I created it on top of the first one and didn't edit manually. > I was able to apply it in my local repository. > What was the error ? > Patch 1: + if (batch->writeable && !PageDirty(batch->pages[i])) Patch 2: - if(batch->writeable && !PageDirty(batch->pages[i])) This doesn't look to me like usual whitespace damage in-flight. Anyway, this has been applied to for-linus-5.10 -boris