From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E07E7397694 for ; Mon, 20 Apr 2026 12:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776689444; cv=none; b=NBKmSmrAM4vQYMLs74Zr+MOKsDT7k3ZnImcjcapvL9zC3rViCF+Vi1nbkZfh0EiK2GluWIPF+GdGXTEAJPXS5Nbu8wrVsxXjMwAnskVHLYVXewu6XMoyLN9Tn2fCUVBtvQ7v2o3LXD1kwBZ4cC7rx+l1SUMBBFUIMgebMo0a3Io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776689444; c=relaxed/simple; bh=neg6eIdJRVkDfxbADXvR7pQbjSovMoDrB+ifUOQr2bM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c3oT8e1gRbidzi0S5zples6LFNLRFJv83JroT9+mnJapgGjMjAnV2Hp5VhV+3lSACkmw9dhDyVB4mUfKhPeejBYC9kxd4lBSBma8PhlAujsZBYUDro487qWTpX3SFlw+PGcRyJydjjmvkNzmzXE7dxdEa7+VPupJjSzCvV3W1dg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bdFwf9bQ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qWaPPnSs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bdFwf9bQ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qWaPPnSs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776689442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FOqefyw2xfKGzGmt4FILCNloyRh5kydROPG1tzzp9Iw=; b=bdFwf9bQjCgih+engzQ1XPLkf9gGYupMRmkkl6DMEIELTPLmIAMZUAR3q3COQCguOO0n0I qiYbwQLUQ0jCtj+LLVs0va/HrNo+BPA2VDknkbdGBZOo/n9hdMG+wOdTx8zOH7QYV3HubZ lGqD0KiXF16y9p1Tf5KSYbtT2Sl/Gnc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-DdnLnHVyMKW6pQJi-aprGw-1; Mon, 20 Apr 2026 08:50:41 -0400 X-MC-Unique: DdnLnHVyMKW6pQJi-aprGw-1 X-Mimecast-MFC-AGG-ID: DdnLnHVyMKW6pQJi-aprGw_1776689440 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d7730e9e3so2162991f8f.2 for ; Mon, 20 Apr 2026 05:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776689439; x=1777294239; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FOqefyw2xfKGzGmt4FILCNloyRh5kydROPG1tzzp9Iw=; b=qWaPPnSs9UQOeN8mvUdPNcoU3ltlAN8pNUNy7ApupJKjYGJZJe2CH/oq7lz1u6LHKe VFiaoC7+SDouwKQ61UhF2aFMKroiFxZ/yYz5JetK2m5IL/Iny4gp35IPgfjvcDchLcfD P4QFC4WEeVbaiykiftqCw2ArVo+7kX/D9zw4JIOnzjVVHmjf+mKSbcRup+MQFp4SyL5H ULcYV1CBBOxCIMZ6Gayb0lr1lYslXcUWF61gtAYiddZ4uOLkn4ui1/Xfq+U+/aMGUOMo mK4pd4DMYdwG0zh32w0k9hA/IztN2cE0lCHQ6eOwGG7fWlKK/oFInC+CW0+cve+SJlS3 XZyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776689439; x=1777294239; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FOqefyw2xfKGzGmt4FILCNloyRh5kydROPG1tzzp9Iw=; b=AQs2/R9era9WohHJ4PKSqt7ga+6baDnpsKHjgmUiWTMxVbSOkyPyq0JP6wOqhV2Gui fgO/OHjfv3GPVuzPvvE9EXmjjeKfIfy/zi4MAZSSvun0y5LKtMzJMHXZIrkixtN0HnZ+ KOu3Sd9EUlvNmyez6kKmVpfm+DqaFq7p4V6VLDcn49B5A16zb+ED7pxqDyRwzC9P6eqe ZfPhL0rDK+9ZyCLaOynidROPIH5lOJ1SJrgHrhui4kbAgMnbhANzW6CNvP4ifPo8C5AD DrMHEsC3qGBlbBwhPyrvR08v+j1DgVI01EWG/oZCdfmWUItdNvzO5xeu5jMUqEZC1XC6 M8Dg== X-Gm-Message-State: AOJu0YwtsiFpV0ymmcNLcmKq5ThrTRuiCBM9e65RMqPyNG+C9Hxp/gXP uToDxHkPP0f1iv1iKAV/L07Kpw4nN9VmQFHkN6WYlRdgtSqCEQkQJG1jtS0MOuvC+nrBmctpgyY N/jkseqj+0yp3LoOnkdATs/HimWMaPvwipU+qmKQZowOCwbajb4MYk3of9HbsrxJAHhK7c8KL4q mY+a66yawdndHh2Y8R25XniZSKzYBpcdffBHh8WC0UdlA= X-Gm-Gg: AeBDiesmgAww/NBJim8OllBhGoA6brXo7s+2KAQOfoB89EJKDtqtZ9pWBgTVkmsQKL6 d8Y/+VIztRU5l6g5BQBg4G6GjqJLoCrNlsuuN/8I3jm5qkfJb+W8dsme/ouJoiyb9pkwVKvyQNh BI/JXFVbMhAShW2+MphytqFY645lowqcGJFp9kVBu+6TkwjKYIW0dWqwF4aLl9ps3wzh/PByWwf Cc6l3WidURL8Ns9bjydu35MP3+aPZPOLOxhbMyEZUwgw7A1XsdKFU8f4pmQKFz+w0g/2vfvMQyq xuXCKIPi4EOs1OKFJOkcg7rvktiYnQ5zMRtxOGvjGglElZc9Y6AsxEVw1kgV7G6tAA4MpPJQUZl 57JuVsGda5dtYj90ku4/FVgR1iScz9AdlJosbxHjSt54CuTg6zA6gPg== X-Received: by 2002:a05:6000:40dc:b0:43d:7b7b:ab77 with SMTP id ffacd0b85a97d-43fe3dcbbeamr19710829f8f.11.1776689439206; Mon, 20 Apr 2026 05:50:39 -0700 (PDT) X-Received: by 2002:a05:6000:40dc:b0:43d:7b7b:ab77 with SMTP id ffacd0b85a97d-43fe3dcbbeamr19710690f8f.11.1776689437905; Mon, 20 Apr 2026 05:50:37 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-21.inter.net.il. [80.230.25.21]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb1249sm25931964f8f.5.2026.04.20.05.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 05:50:37 -0700 (PDT) Date: Mon, 20 Apr 2026 08:50:35 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Andrew Morton , David Hildenbrand , Vlastimil Babka , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Jason Wang , Andrea Arcangeli , linux-mm@kvack.org, virtualization@lists.linux.dev, Johannes Weiner , Zi Yan Subject: [PATCH RFC v2 06/18] mm: page_alloc: thread pghint_t through get_page_from_freelist Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Add pghint_t *hints to get_page_from_freelist() and pass it to prep_new_page(). All internal callers except the main fast path in __alloc_frozen_pages_hints_noprof() pass NULL. The next patch uses this to return hints from post_alloc_hook() to callers via __alloc_frozen_pages_hints(). Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 Assisted-by: cursor-agent:GPT-5.4-xhigh --- mm/page_alloc.c | 37 +++++++++++++++++++++++-------------- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index b0971a1eaa73..ece61d02ea96 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2483,7 +2483,8 @@ __rmqueue_steal(struct zone *zone, int order, int start_migratetype) continue; page = get_page_from_free_area(area, fallback_mt); - page_del_and_expand(zone, page, order, current_order, fallback_mt); + page_del_and_expand(zone, page, order, current_order, + fallback_mt); trace_mm_page_alloc_extfrag(page, order, current_order, start_migratetype, fallback_mt); return page; @@ -3294,7 +3295,8 @@ struct page *rmqueue_buddy(struct zone *preferred_zone, struct zone *zone, * high-order atomic allocation in the future. */ if (!page && (alloc_flags & (ALLOC_OOM|ALLOC_NON_BLOCK))) - page = __rmqueue_smallest(zone, order, MIGRATE_HIGHATOMIC); + page = __rmqueue_smallest(zone, order, + MIGRATE_HIGHATOMIC); if (!page) { spin_unlock_irqrestore(&zone->lock, flags); @@ -3414,7 +3416,8 @@ static struct page *rmqueue_pcplist(struct zone *preferred_zone, */ pcp->free_count >>= 1; list = &pcp->lists[order_to_pindex(migratetype, order)]; - page = __rmqueue_pcplist(zone, order, migratetype, alloc_flags, pcp, list); + page = __rmqueue_pcplist(zone, order, migratetype, alloc_flags, pcp, + list); pcp_spin_unlock(pcp, UP_flags); if (page) { __count_zid_vm_events(PGALLOC, page_zonenum(page), 1 << order); @@ -3451,7 +3454,7 @@ struct page *rmqueue(struct zone *preferred_zone, } page = rmqueue_buddy(preferred_zone, zone, order, alloc_flags, - migratetype); + migratetype); out: /* Separate test+clear to avoid unnecessary atomics */ @@ -3835,7 +3838,7 @@ static inline unsigned int gfp_to_alloc_flags_cma(gfp_t gfp_mask, */ static struct page * get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, - const struct alloc_context *ac) + const struct alloc_context *ac, pghint_t *hints) { struct zoneref *z; struct zone *zone; @@ -4084,14 +4087,14 @@ __alloc_pages_cpuset_fallback(gfp_t gfp_mask, unsigned int order, struct page *page; page = get_page_from_freelist(gfp_mask, order, - alloc_flags|ALLOC_CPUSET, ac); + alloc_flags|ALLOC_CPUSET, ac, NULL); /* * fallback to ignore cpuset restriction if our nodes * are depleted */ if (!page) page = get_page_from_freelist(gfp_mask, order, - alloc_flags, ac); + alloc_flags, ac, NULL); return page; } @@ -4129,7 +4132,8 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order, */ page = get_page_from_freelist((gfp_mask | __GFP_HARDWALL) & ~__GFP_DIRECT_RECLAIM, order, - ALLOC_WMARK_HIGH|ALLOC_CPUSET, ac); + ALLOC_WMARK_HIGH|ALLOC_CPUSET, ac, + NULL); if (page) goto out; @@ -4227,7 +4231,8 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, /* Try get a page from the freelist if available */ if (!page) - page = get_page_from_freelist(gfp_mask, order, alloc_flags, ac); + page = get_page_from_freelist(gfp_mask, order, alloc_flags, + ac, NULL); if (page) { struct zone *zone = page_zone(page); @@ -4477,7 +4482,8 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order, goto out; retry: - page = get_page_from_freelist(gfp_mask, order, alloc_flags, ac); + page = get_page_from_freelist(gfp_mask, order, alloc_flags, ac, + NULL); /* * If an allocation failed after direct reclaim, it could be because @@ -4831,7 +4837,8 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, * The adjusted alloc_flags might result in immediate success, so try * that first */ - page = get_page_from_freelist(gfp_mask, order, alloc_flags, ac); + page = get_page_from_freelist(gfp_mask, order, alloc_flags, ac, + NULL); if (page) goto got_pg; @@ -5249,7 +5256,7 @@ struct page *__alloc_frozen_pages_hints_noprof(gfp_t gfp, unsigned int order, struct alloc_context ac = { }; if (hints) - *hints = (pghint_t)0; + *hints = 0; /* * There are several places where we assume that the order value is sane @@ -5279,7 +5286,8 @@ struct page *__alloc_frozen_pages_hints_noprof(gfp_t gfp, unsigned int order, alloc_flags |= alloc_flags_nofragment(zonelist_zone(ac.preferred_zoneref), gfp); /* First allocation attempt */ - page = get_page_from_freelist(alloc_gfp, order, alloc_flags, &ac); + page = get_page_from_freelist(alloc_gfp, order, alloc_flags, &ac, + hints); if (likely(page)) goto out; @@ -7855,7 +7863,8 @@ struct page *alloc_frozen_pages_nolock_noprof(gfp_t gfp_flags, int nid, unsigned * Best effort allocation from percpu free list. * If it's empty attempt to spin_trylock zone->lock. */ - page = get_page_from_freelist(alloc_gfp, order, alloc_flags, &ac); + page = get_page_from_freelist(alloc_gfp, order, alloc_flags, &ac, + NULL); /* Unlike regular alloc_pages() there is no __alloc_pages_slowpath(). */ -- MST