From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E93D8303A05 for ; Tue, 6 Jan 2026 06:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767681073; cv=none; b=TVIejOt9HGHzPfKylOMKms5cOLrB2WkRTMzklu7UIUdOAbPsGBWG+QpgVh0bYSUwhkpG2tr2m7yrsQuLEElfmGHv3CUe3exf+3WLDJdv+056N2UX0WNUfCaar3diUpF6L7z86TrF4iH3mdI2x/jojvvOT0VcTB5bUS97sASehz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767681073; c=relaxed/simple; bh=Wov/qB67vp8gz1l2fIooRnUAV2nxx01QDhoiDuwqOdo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uQ7lWIqXaLrYBgWBmpYXxTJMq2ZW/4tdl2Z6yYBNYYnNkcGgAd81LArU59FtbtPhfTDIvE4kUHippjS9X1+DUl083TdfCfjdKJixtqx2mK6R8k02JNlDzi4T4QALcKWJPdFSoxHyWPHOXTvU3J/idaqxHKF+oJAltsjFZ1ZtRck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n0QJ4LOz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FLJdTeiy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n0QJ4LOz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FLJdTeiy" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6063QCNv3052779 for ; Tue, 6 Jan 2026 06:31:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RDWKmfMAAIQKR/wtVg52c2k7p6H/btOMvPSVN3ySifc=; b=n0QJ4LOzR4aY0S7E CAsIkrc+bylTq/cjMlqCNsdZwO/wIphHWiSxSIGsv3xEsz+M9hBPHtzFwHSFwUH/ 1sDbZ5cgrjRlbpFDhPk9VpTCxrz5Vee+sOEq0z49NUkp0ke+heuvhwGoz+kHOH5Z 0HTOo4P7KIjA1hgfw56bnWHDPfyHTBlE75eLmpRgtDOAsDmzlItTUy7nJ/Nbz+gZ XfPOeAQPm1vZTKXIEGHRuUZqETIgIBfUKiUOKc57b/lg7Is2rfjpvvE5alzk0L5J CcnYYrnjDrnKqg5KJyZTSm39U03bfrEkq/i1jwokIPk3/JRP+zB5Pn7uSqOSiP5P GPmNHg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bgpn9s03q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 06:31:10 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7b6b194cf71so1543586b3a.3 for ; Mon, 05 Jan 2026 22:31:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767681070; x=1768285870; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RDWKmfMAAIQKR/wtVg52c2k7p6H/btOMvPSVN3ySifc=; b=FLJdTeiyOO1ORDTxbTSgb0qJgWJooWLqZnI+w8bkBTrADfUwE6NykLlODPKQqFqadt WsaUCDTlOkS+DCqTEo9cneWFAjM/ekt8GG4N8zcjlrGbkfNVVvLtEpBvgl4/e4HGp72w o9i3ag/TyajMgVSLJH8GYbFrAW6drR2+T5qDGqZvq+SOe7baqJSrLJfLP+litlm9Yw6R etIKnV8jQurjx4NFxLjX3kutjPvpngmQQMz5iZR8yF4AbhMTJWIsF14NO0cIwJss47MV zhc0ow48/EQnJP2smjxPfTuXk6sSKnSmsonF9uY/9hFzgjEs2QjKzwciC32Ff9BtKuEL FSJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767681070; x=1768285870; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RDWKmfMAAIQKR/wtVg52c2k7p6H/btOMvPSVN3ySifc=; b=XZXliqP3M+WrHSQWJzAjR7xQVD4V+37d7OUUOiXb/gVA59Zkl42AUcPr57RJSzIjpq 4joFLa9HNCDU9mhVzC7Wu45BMlf0WgXFuW77ChmmtxBr95+z5vAzhnHGPLR3hZIQdsRI 1cui1mJUY16CBuBAceoxJJrBnul8wAuu6ygJCLs1g1uJ08Axnz0g6TYjAoEocgpKc6Gp kW/7Zvd8C4oB5mcV2dhp8Ot84l2OEtMEQxJ33PYu25xterNrW2pCzt2m7W5PlS7CzCwW YoYlqJd3aAgKdcXyXIsm4ICEjh8HdyIIecba2np/EVx9c/1Cj6BWcE2R9HMIc885wt77 6P4Q== X-Forwarded-Encrypted: i=1; AJvYcCWcaSf5Xpgdni7T6OzGI3jVjcUkAaQMYz1VLayWbWvAdWTsu/+Z07CrTfTBQApmTPYcl2rS4fWUyvVy+hs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2Eagoc0ap3ePtxQVE1XatmwE6MCTaLJtcMcfSzrcPAzSk9NP5 yYAS53NmF6Ba32wNC0IgHIPiCECVoHDLonsmqlxj02mKBuSotryq0sdY436OXGReJWo1V9ncX4t HIMqLwK99ByeTUAI6q6vn/1ygeruk399vzespZf0gPZVRRssQqIQSjT0x499Mu/9WB48= X-Gm-Gg: AY/fxX65LG5UsIctLp6bLZUMmFGSFjDoY1H/fDOMwT5PeatQqS+k7yCEvaibV1OhWRE cn+TskFsSDtkKGBUMOya4YQ24DzcjosWES6LOtls9d0OPO3ewKCrdnM+rD01D6vgpuOeuBZrqKL 42spnVaHeaQyQYmOBsYkLtSxiiUiyFrhLONALhMggikK4MRVOZzKUMdJs2nx8EGPeyafamtjzVt kfIeNvticFV/HPao9vGv87J7x98e37u9Adp0q5DzW1/tgBTs/mcPMudZhtEO04pMWhBpg4MOPqd CNyRyOrZ1hX+LTrT2FmnhiImmfah6ArIuXP9fc7jSbdvcnx/DPYJKJE3wIXDacH6NgGb3vEpsAL R6OBp4CLZ+EA13AuY1zXhcTXsGMmhCiNnPFX+jN845Jcw X-Received: by 2002:a05:6a00:44cc:b0:7ff:b07d:d4fa with SMTP id d2e1a72fcca58-81882be1209mr1870840b3a.56.1767681069753; Mon, 05 Jan 2026 22:31:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/vpXsfwuFIlKNlWeDvpXegR4zTXn7c2rAirDsOY7syntOF57m7Ik/8zN1pNoMFJhmyuAbiQ== X-Received: by 2002:a05:6a00:44cc:b0:7ff:b07d:d4fa with SMTP id d2e1a72fcca58-81882be1209mr1870798b3a.56.1767681069241; Mon, 05 Jan 2026 22:31:09 -0800 (PST) Received: from [10.219.56.177] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c59e755bsm992670b3a.48.2026.01.05.22.31.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 22:31:08 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2026 12:01:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v19 01/10] power: reset: reboot-mode: Remove devres based allocations To: Dmitry Baryshkov Cc: Bartosz Golaszewski , Lorenzo Pieralisi , Arnd Bergmann , Bjorn Andersson , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Andy Yan , John Stultz , Matthias Brugger , Moritz Fischer , Mark Rutland , Conor Dooley , Konrad Dybcio , Florian Fainelli , Krzysztof Kozlowski , Mukesh Ojha , Andre Draszik , Kathiravan Thirumoorthy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Srinivas Kandagatla References: <20251228-arm-psci-system_reset2-vendor-reboots-v19-0-ebb956053098@oss.qualcomm.com> <20251228-arm-psci-system_reset2-vendor-reboots-v19-1-ebb956053098@oss.qualcomm.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: dECMuOkYRMCFFCi7aSxwpaevAQBDdlvM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDA1NCBTYWx0ZWRfXysCgd4134KTd 4fulgGW7BPFsC/J1aWtwFTj5Re85WwqCO/8xtLQ4dLlyhNdfz+o0L3FBSRnVOk3UFEdvhp0jA6U 5OUCQqKaUgM2zHjqh6BmnpcNNFHN7gF30twPEAPiSIAa+WyKTYowD29rl6zhYev0boMWh1bdEZp til7+8fHqhIUxO+2z1i/ZyX6PW1FicNSBEd6QQDiGVe2OBrNFeAaID+O21EbRgLxrey+sZhU282 jsE7n1lUtIMHbOrPgB+cg/yyUaZrQ+Co8MQZtqd0HnGvvsxPweds6MO4mSCikLSjrYiWJ89AIUG 0741CPw9vG71NvLwQC4pikSDxkhG42I3Jomt+s6nEm3l43wwXSMBYHWJQQJNMxN7h4RHk36nBV8 vSwq/CAWN8Cj/rgZ4Styn7NfajcT9Jr2G8g+X9BLErupEiGfU31oTtBZVjDv1iBBTmR5G6Gi3mP es0IiEiPuZ5jRGXL0jw== X-Proofpoint-GUID: dECMuOkYRMCFFCi7aSxwpaevAQBDdlvM X-Authority-Analysis: v=2.4 cv=KfnfcAYD c=1 sm=1 tr=0 ts=695cac2e cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KAb_rDcQEDUYZVoDp1sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_02,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060054 On 1/6/2026 3:01 AM, Dmitry Baryshkov wrote: > On Mon, Jan 05, 2026 at 11:46:40PM +0530, Shivendra Pratap wrote: >> >> >> On 1/2/2026 3:35 PM, Bartosz Golaszewski wrote: >>> On Sun, Dec 28, 2025 at 6:20 PM Shivendra Pratap >>> wrote: >> >> [snip] >> >>> >>>> + pr_err("reboot mode %s without magic number\n", prop->name); >>> >>> If this is an error, shouldn't we bail out? >>> >>>> + continue; >> >> This is not an error as per original design of reboot-mode framework. >> The code as of now says, if the reboot-mode node has an entry without >> proper magic value, ignore it, and, process the next. > > Then why are you using error level for the message printout? I have changed from dev_err to pr_err. Can make it pr_info. Will that change need a mention in commit text? thanks, Shivendra