From: Krzysztof Kozlowski <krzk@kernel.org>
To: Diogo Ivo <diogo.ivo.sx@renesas.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Thierry Bultel <thierry.bultel.yh@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH mainline-linux 4/4] arm64: dts: renesas: r9a08g046l48-smarc: Add RS485 support on RSCI2
Date: Fri, 20 Nov 2026 17:03:11 +0100 [thread overview]
Message-ID: <e4b514e1-4b0d-4bb7-a19e-e13518ceb277@kernel.org> (raw)
In-Reply-To: <20261120-divo-ssgrlpcsrc-2996-rs485-v1-4-a989baae3559@renesas.com>
On 20/11/2026 16:49, Diogo Ivo wrote:
> Add an RS485_ENABLE macro (disabled by default) to configure RSCI2
> for RS485 operation using the RSCI2_DE pinmux instead of RTS/CTS
> hardware flow control.
>
> Signed-off-by: Diogo Ivo <diogo.ivo.sx@renesas.com>
> ---
Odd subject prefix. :/
DTS cannot be combined in this patchset and must be split. Don't mix
patches from independent subsystems when you send something explicitly
targeting only one subsystem.
See also: Documentation/devicetree/bindings/submitting-patches.rst
> arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dts b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dts
> index 68d7b579e352..d583f52e61e7 100644
> --- a/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dts
> @@ -23,6 +23,8 @@
> #define KEY_2_GPIO RZG3L_GPIO(6, 4)
> #define KEY_3_GPIO RZG3L_GPIO(6, 5)
>
> +#define RS485_ENABLE 0
> +
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/pinctrl/renesas,r9a08g046-pinctrl.h>
> @@ -185,8 +187,12 @@ rsci1_pins: rsci1 {
> rsci2_pins: rsci2 {
> pinmux = <RZG3L_PORT_PINMUX(7, 6, 5)>, /* RSCI2_RXD_MISO_SCL */
> <RZG3L_PORT_PINMUX(7, 7, 5)>, /* RSCI2_TXD_MOSI_SDA */
> +#if RS485_ENABLE
> + <RZG3L_PORT_PINMUX(8, 1, 6)>; /* RSCI2_DE */
> +#else
That's dead code.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-11-20 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 15:49 [PATCH mainline-linux 0/4] serial: sh-sci: rsci: Add RS485 support Diogo Ivo
2026-11-20 15:49 ` [PATCH mainline-linux 1/4] tty: serial: sh-sci: set the RSCI RX FIFO trigger to half the FIFO Diogo Ivo
2026-11-20 16:11 ` Greg Kroah-Hartman
2026-11-20 15:49 ` [PATCH mainline-linux 2/4] dt-bindings: serial: renesas,rsci: Document RS485 properties Diogo Ivo
2026-11-20 15:49 ` [PATCH mainline-linux 3/4] serial: sh-sci: rsci: Add RS485 support Diogo Ivo
2026-11-20 15:49 ` [PATCH mainline-linux 4/4] arm64: dts: renesas: r9a08g046l48-smarc: Add RS485 support on RSCI2 Diogo Ivo
2026-11-20 16:03 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4b514e1-4b0d-4bb7-a19e-e13518ceb277@kernel.org \
--to=krzk@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo.sx@renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®