From: Mark Brown <broonie@kernel.org>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: alsa-devel@alsa-project.org, venkataprasad.potturu@amd.com,
Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Syed Saba Kareem <Syed.SabaKareem@amd.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..."
<linux-sound@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: amd: acp: fix for acp_init function error handling
Date: Wed, 27 Mar 2024 14:58:50 +0000 [thread overview]
Message-ID: <e4ba58bc-fa5b-4ece-8906-f7cc7cb5b0f4@sirena.org.uk> (raw)
In-Reply-To: <20240327104657.3537664-1-Vijendar.Mukunda@amd.com>
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
On Wed, Mar 27, 2024 at 04:16:52PM +0530, Vijendar Mukunda wrote:
> @@ -115,7 +115,10 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id
> goto unregister_dmic_dev;
> }
>
> - acp_init(chip);
> + ret = acp_init(chip);
> + if (ret)
> + return ret;
> +
The return check is good but shouldn't this be a 'goto
unregister_dmic_dev' like the above case so we do cleanup?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-27 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 10:46 Vijendar Mukunda
2024-03-27 10:46 ` [PATCH 2/2] ASoC: amd: acp: fix for acp pdm configuration check Vijendar Mukunda
2024-03-27 14:58 ` Mark Brown [this message]
2024-03-27 17:38 ` [PATCH 1/2] ASoC: amd: acp: fix for acp_init function error handling Mukunda,Vijendar
2024-03-28 22:01 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4ba58bc-fa5b-4ece-8906-f7cc7cb5b0f4@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®