From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbdILUvH (ORCPT ); Tue, 12 Sep 2017 16:51:07 -0400 Received: from mail-cys01nam02on0062.outbound.protection.outlook.com ([104.47.37.62]:34209 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750869AbdILUvE (ORCPT ); Tue, 12 Sep 2017 16:51:04 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Joerg Roedel , "Michael S . Tsirkin" , Paolo Bonzini , =?UTF-8?B?XCJSYWRpbSBLcsSNbcOhxZlcIg==?= , Tom Lendacky Subject: Re: [RFC Part2 PATCH v3 10/26] KVM: Introduce KVM_MEMORY_ENCRYPT_REGISTER/UNREGISTER_RAM ioctl To: Borislav Petkov References: <20170724200303.12197-1-brijesh.singh@amd.com> <20170724200303.12197-11-brijesh.singh@amd.com> <20170912202940.qmq5oq2cx2cmhwqg@pd.tnic> From: Brijesh Singh Message-ID: Date: Tue, 12 Sep 2017 15:50:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170912202940.qmq5oq2cx2cmhwqg@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR2001CA0023.namprd20.prod.outlook.com (2603:10b6:4:16::33) To DM2PR12MB0154.namprd12.prod.outlook.com (2a01:111:e400:50ce::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a336a785-6cf5-46d1-b178-08d4fa1ffa2c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM2PR12MB0154; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0154;3:XFntBmSUtDleANcqDkVMVVpoybQXrQZUkCo9ZFbvxIhwm3OnokGlEsoY6bvaElR07qYarsLv8qZLyQIhiLI1cfWHHMrTA+K/BPcZUO1wG1E9g4vlqMHX0XeDu7ACpEsuiDeF3mAXA2zqgHp3Z5JMrOa+HQf/4e/A92ldsQ8+UxfQ4o1gHh4UbB1z8bzYRo+mA0Mkjp5SihfmDrGewJsDbHEMjavCBi9Mb4b2FQK587eYgeig/bv07jTgUpSjoclu;25:pobAyIOAsEsL5Ci3izJF0lbA7x+1f71zvTNLpsloWQO36XJDtCBGZfXXYvwW7KjZgYOMmdM9qoT9HdRCP3f9S7lrx7cOfyFNXVhDEwEnUV6kMLtEJshcyA3CzcmrAm+qEp6MNl0uahndSxgzWObuiNF5Qj8vixScEkdO9U8S3wZnM0K0iZxOrC3/FIfjtTjAomnEGBwDFzbRJNPlS2W3HVn/VA5SCrnC9/e0y1BxctjA63rI275jgJwtuk7cEbV5HnAcy6cFF8NZwy7ue0SaBaKgLBAA0ErL/yOtAWjHSz59wYR9FFPCXeqmy/F9uCLTIMrMu6y+QMeywgC9etLSAA==;31:XwuiJHppb/BS1bzrlQX1rGTOYzGNfOkQQowcTnnSAsIqkXeWITdX9EGcXdifX30o0yB2ARCPHUw/2WlttdbiGqbF38YOySjBIU7p3wVRZZ8pn9C2aS21HzMLosbftMCKH5gY1x8xabQXH2tuic96mRa81iNKePUudVaZJItbJJqiaeRAUtNm4siRzS6H2x+ND6PhfnY/3Sei83vzji4rjHTgXlntTqwVWiuGL9122/Q= X-MS-TrafficTypeDiagnostic: DM2PR12MB0154: X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0154;20:P4isQy1ireYKyh72FX2fRoHsE3Ql//8y726JYz9kF+bq/xm+Q9XLRFqrBD4p3U5oYu5zJRQ7Xr0l5dUH3Z2JDzavaJv3pJwsN8sbUavXJeYGaV5PAlpuPd7Ymh5Vh16h+oAj1Cv+R5Iy4xfDCssN+tYuZCNKhKDERV8me35bNUEhqVJgKGsmymblQbqUpDOjZK3gg2SgX/pAB76tjuFVXK4ZDOq7cZnML5YrckG9AAJGmL/xameByHvcEgMMJwHXaJVXLV1/Sb5ZxDhIZXYcjbBq4ADAsz5uGMcJd3p85KAB/NNi+IzXUXhdq+zFzcbAuK+xUD0qGoKnraaF6bOa5b2VWBC1/Ly3rWA+8G2DC9rIYdMOZuh6L1iYJE8rTr3xBpeS6RMp4MoG4IS86psFvPN5DqkQFpgHZGPsK9Ott/mT65UWLC5Z1a4rvHxsmfx+M/V3sXM2VX/cbh5bVtehFgUs+0KHpJFQSCi5y72+et9iOOjXPlGTDjnh2sL8fWJT;4:d9ZktUP0YK8Kd5bMEfz5BoXynlfXuWNHHKg2rTXYXICOu68AEAa6xv8mvwu1ARV//eZ7e+20txelRu+rYhBIuD35q/lQNOC2fLHEYeP4aQN8bHCRz0x5nGnnIAaOOhp9RRgvlK2xPKxmJuUbO1X5VTz+hmFf7ZZI9yahYDqgeB3Q033uPT2I5yGFI/kZHXjHoCtjh7CZ/C/3EVhXnXBB4YmZUXwuTQk7LqQ6r+S2OhnfWD2AewW2bTT7bmAdtm7v X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR12MB0154;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR12MB0154; X-Forefront-PRVS: 042857DBB5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(366002)(376002)(39860400002)(24454002)(189002)(199003)(377454003)(81156014)(106356001)(83506001)(97736004)(8936002)(4001350100001)(230700001)(6116002)(16526017)(2906002)(316002)(31686004)(53936002)(53546010)(6916009)(2950100002)(3846002)(33646002)(54906002)(105586002)(16576012)(4326008)(6246003)(31696002)(47776003)(68736007)(6486002)(76176999)(23676002)(50466002)(7736002)(305945005)(64126003)(65826007)(81166006)(86362001)(77096006)(65956001)(66066001)(6666003)(65806001)(8676002)(189998001)(101416001)(5660300001)(25786009)(54356999)(110136004)(36756003)(478600001)(50986999)(229853002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0154;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTU0OzIzOjhkRkdtWVp2WEJLakpteE1YL3pIVWYyWUFX?= =?utf-8?B?SDBNTmoxcVdQYXNtTy9tUGVTbHN5QXpYaHVWNEJXbUJTcmJBdG13NEtMUWQ3?= =?utf-8?B?cFllN21acFdSRG5aVjlzcHdVOEJqRHFjV2FMdEUvSGowTzdDM3U1Kzh3MnJN?= =?utf-8?B?dWlGUU9HdUVMeVhnWlNvR2Y5eGNSdGwveUNnd3phUjM1UW9TSnZjTVhzc004?= =?utf-8?B?Z3NGNXpySnRZS25xZS81ZmRQL01ReW94UWl5TzRIMmdvQjQya3JGS3N3cHMy?= =?utf-8?B?SStuWXd3VkJId3FyTHpxNHFsNGE4akM5RFBzak9hNEk3OEtxR05OYURVaEQ4?= =?utf-8?B?S2RQZ0dJaGF3VlQ1VU4xZWt1eGN1VVl1QW5iU2dBZ3htNHRpYVR0ZXNFRHp3?= =?utf-8?B?NFpyNEU0NnluYVFYbmFVUGg5bHE1MWxudnIxVlh3cTlJMzZteWorZ2x6enV1?= =?utf-8?B?SFlHc2cweEVaNVFZWEt6QmFoTjBUakVENG9mclVOQmRCaHY4OUdkVjIvTkhN?= =?utf-8?B?WFV2NmovTGZtcTJCazZkTE10aTFMNTVvWkZGRGZBcmFaaFRaajlqN1h0WkVz?= =?utf-8?B?Q0NJSGFZSi9mSWdYMWkwZjRabWVlb1hXaTNIS0lGayt4WktaR01sSUZlSjhE?= =?utf-8?B?UFRBblhnVm5QQkgzUkJ4QmZvNGV3NUwzaFhqcDBBMmhqRnRMbnhobzJEbjh4?= =?utf-8?B?TmpPVDlNeWk4T3NmN3FKRHREMFN3ZzNTR1hla1VyQXpSb2xnSkViZmNnbnp0?= =?utf-8?B?U083eE1TMzMzUWFQcU9VcFhDRXArUUQ4djFhSzA1QXFRZ0JkMXJRaEFuR1Jo?= =?utf-8?B?ekRDQ2tWM2ZxZEJ2bFJpb3VkWENWbC96ZGIyT2lrNDB4dU43cDRDUmhFZGdY?= =?utf-8?B?RWYrYUlEaWNoUVZJaVI0enh0UFNnSllPRm1VbGR2N2crREhaZDJOMG5qd0VY?= =?utf-8?B?bDIrcXFZMUIzQXpjT2h3ZW95STNGMzF1ZGZZeURDWWhKZ0NLMGZleDhMSmxB?= =?utf-8?B?bmpqRTlxQzhjSHMvYjZ0ZjVtMjJiUE9qSVA5bmJPRVNFYWlqejJXdksweVJX?= =?utf-8?B?OWRQOEVGdldzQ2hRc3FKd2xLVStna09Ca0d6SmtoNHgwZEVpc1V6ditNa3Np?= =?utf-8?B?a2NLOTdWUGRzOVo5dTZ3cUdpN2NSdjRtQkVrbGlZMkY5d0JTS3NHWWhVRjVM?= =?utf-8?B?eC8rbU1aQTdSbWZFVURtdEoxanhxWUp0UUhqYndsM3hxVVhPZjZiL1h3Ukw5?= =?utf-8?B?MFdPZFE2YWRMYW8vdWlnUmd3RHVzVUg2RmJDcElSbHRQcE52Y0dkZnBXUkVr?= =?utf-8?B?Tm1xN3FFSWMzaDd3R2FjcUhjMTN5WjhTNWdlVmVFaGkyTC9vMXI5Zk90STJP?= =?utf-8?B?YThRczYzLzNpQS8vblVVT3Z5OVQ0Q3N4VmFrVGE4OUNPd05obEdFajlSQ0o4?= =?utf-8?B?NEVNV1ZsbFlXdlZGN1JyaDVVOUNveHE3blZWK3hOMk5zZXZmZ1cxaDBBMlhi?= =?utf-8?B?NHM1N3FwWnBOOXJMWE05WVY3N0ZWd2MvZEhLUXY1R2dPRjFIR0hQcXBHU0lT?= =?utf-8?B?RTJteWcyWUFTdGRnSHRVektGczhUOGhsTkZSdTdBVjdtN1pCSnhVNlRvNklB?= =?utf-8?B?VGc0aEJXS1NjVzFSRkJXMEtxM0lROWloRm9KeVpvSDFnWCtvM1NFUGh6d1lu?= =?utf-8?B?OFp5RkNSbi9CUlpQWS9rbzNkZ2tPRkZjTVhITnB0VzFNUVVrakFoeTl5QTM3?= =?utf-8?B?ZFkvTnBPTk9SNzRkVnhzUll5VjBjbHVqeVEzZHVTOGo4NVl2dEg0UUpickE2?= =?utf-8?B?WjBFTm9xUDk1aUVmdTVOUDR0dFRORWxpWnVKVmNRUnUyS3lxWWI0QlZudmdh?= =?utf-8?B?UE5lZFJGM3ZZQXhMcUpoeDJLU0V2Zk83TnZrVTY5RE4wUW9BazZJR204Ly96?= =?utf-8?Q?aXJ85z47bv96tIXsiwSkb25kG7+Y0Y=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0154;6:n+7BN/wiUkY8p8r/+nsEb1zydM8LyYNx2scLAn71TS8ZbdbEI3SCEs50M7K/THJHSuCN2+EBDoHZuYy//Jg3vjA3XACtCin13BiN6EQj6QzYy4HHws70Jleb51YmFvcAYeWEqp8b0coLNi2SNZ990YE3odJ/MG2yFA7MyK82U+VVJ8MevAbtov8Hx+xu3bTSGcl3JjwdKl0DWVJbUoaNMlGEU0Q+OZKVW2p33i3xKDDkRn+AKJ0G5ruwCpzqDsDtH8r6pLPYfwVnxsmddV/6ObdK4jw9X2COevYIwVeohF4DWuIgzn7NdNvVN6ZOddyU0z/E0TFnKKK9VBmMoZSWMA==;5:CiZIDkVW6Eaal9KjSXCtQRgikuBykoxdHAUJKgS4gT5wSG2lEoypbmoNT7MESHlPsx0zANBnqiQE5W52nl05hL3ZUSyp2VncwVkgg5lrgk0DehAiR4HifIzEaATtDcySWHqQ7KPPKixPorzKIwQ6SQ==;24:/U3SHfGvQRdTMq8Nzv9ewV6AgCSJTsmWw+ZN1CFhGeCsgo5NFFdmdZjxA3AtJyliiuv66wKmD1Np5WHXL6+AFdAijke/BtCHY32Py7KkS5c=;7:ht8sQ9bdooKTeFkq3A/F/7ndup+Z131C71+iHgFTUVQc/T0PHT7RvX+XJhcQTRDc7qd7rTjGOZHxFgyh7ylCVbdiYUX1rYIPchUvPSAT4AWTgmzy2dKbM/Y5DS6e1nI17r27cSsb7fMU/bK4QEXZBBNb5h5KH4CbzG1dZH6izquJ1Cg3Yq3NELPV5htSlj1AinVbO2OCYfhrP3tnNWklBSKm1pIXjC+nMfAlHvipxZ8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0154;20:UowqJBIwlrRHnhKQitsiZ6VPBuBLvsT4swscI5WH+k1yMzmFDDfcU8voguC31QM7ISPKOZbPH6ysJbzxPUTsWbQkQVWixcwCDHM1qGhfy01Niruz6ZwI4PWvMvX3qCpEy7nYcnJh/eV7FgSpgP5NqqczWZCeICHvzeHzrnVTIvnsi7gplahYD2fTq7Qn1CILkxKqZXiph7Yl1qOKXegJ7QhhdtUk8yVJLvAIhPo6URqNJQhwEWsyXAw2d1u7/qMp X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2017 20:51:01.1120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0154 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2017 03:29 PM, Borislav Petkov wrote: ... >> + int (*memory_encryption_unregister_ram)(struct kvm *kvm, >> + struct kvm_memory_encrypt_ram *ram); >> }; > > You can shorten those prefixes to "mem_enc" or so and struct > kvm_memory_encrypt_ram to struct enc_region - which is exactly what it > is - an encrypted memory region descriptor - and then fit each function > on a single line. > Sure, I can do that. In one of the feedback Paolo recommended KVM_MEMORY_ENCRYPT_* ioctl name hence I tried to stick with the same name for structure. I am flexible to use 'struct enc_region' but I personally prefer to keep "mem" somewhere in the structure naming to indicate its for *memory* encryption -- maybe struct kvm_mem_enc_region. ... >> + struct kvm_memory_encrypt_ram) > > As with KVM_MEMORY_ENCRYPT_OP, those two need to be in the KVM API document. > Yes, I missed updating the Documentation/virtual/kvm/api.txt for these new ioctls. I will update it.