From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Stephen Boyd <swboyd@chromium.org>, Benson Leung <bleung@chromium.org>
Cc: linux-kernel@vger.kernel.org, Nick Crews <ncrews@chromium.org>,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] platform/chrome: wilco_ec: Include asm/unaligned instead of linux/ path
Date: Tue, 11 Feb 2020 10:40:11 +0100 [thread overview]
Message-ID: <e4bdff9a-4cd9-70a2-7625-accc6146e063@collabora.com> (raw)
In-Reply-To: <20200203174619.68861-1-swboyd@chromium.org>
Hi Stephen,
On 3/2/20 18:46, Stephen Boyd wrote:
> It seems that we shouldn't try to include the include/linux/ path to
> unaligned functions. Just include asm/unaligned.h instead so that we
> don't run into compilation warnings like below.
>
> In file included from drivers/platform/chrome/wilco_ec/properties.c:8:0:
> include/linux/unaligned/le_memmove.h:7:19: error: redefinition of 'get_unaligned_le16'
> static inline u16 get_unaligned_le16(const void *p)
> ^~~~~~~~~~~~~~~~~~
> In file included from arch/ia64/include/asm/unaligned.h:5:0,
> from arch/ia64/include/asm/io.h:23,
> from arch/ia64/include/asm/smp.h:21,
> from include/linux/smp.h:68,
> from include/linux/percpu.h:7,
> from include/linux/arch_topology.h:9,
> from include/linux/topology.h:30,
> from include/linux/gfp.h:9,
> from include/linux/xarray.h:14,
> from include/linux/radix-tree.h:18,
> from include/linux/idr.h:15,
> from include/linux/kernfs.h:13,
> from include/linux/sysfs.h:16,
> from include/linux/kobject.h:20,
> from include/linux/device.h:16,
> from include/linux/platform_data/wilco-ec.h:11,
> from drivers/platform/chrome/wilco_ec/properties.c:6:
> include/linux/unaligned/le_struct.h:7:19: note: previous definition of 'get_unaligned_le16' was here
> static inline u16 get_unaligned_le16(const void *p)
> ^~~~~~~~~~~~~~~~~~
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: 60fb8a8e93ca ("platform/chrome: wilco_ec: Allow wilco to be compiled in COMPILE_TEST")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
Queued as a fix for 5.6. Thanks,
Enric
prev parent reply other threads:[~2020-02-11 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 17:46 Stephen Boyd
2020-02-11 9:40 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4bdff9a-4cd9-70a2-7625-accc6146e063@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ncrews@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®