From: Randy Dunlap <rdunlap@infradead.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
Jonathan Corbet <corbet@lwn.net>
Cc: kernel@collabora.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: document linked lists
Date: Wed, 2 Jul 2025 23:06:42 -0700 [thread overview]
Message-ID: <e4bea8cb-1367-45ab-aae8-e29efbdbd082@infradead.org> (raw)
In-Reply-To: <70ef2227-55ac-482b-9bcc-df1fd847abd9@gmail.com>
On 7/2/25 10:48 PM, Bagas Sanjaya wrote:
> On 7/3/25 11:16, Randy Dunlap wrote:
>>
>>
>> On 7/2/25 8:24 PM, Bagas Sanjaya wrote:
>>> On Wed, Jul 02, 2025 at 10:24:47PM +0200, Nicolas Frattaroli wrote:
>>>> diff --git a/Documentation/core-api/list.rst b/Documentation/core-api/list.rst
>>>> new file mode 100644
>>>> index 0000000000000000000000000000000000000000..b0586056abb04d2bcc4518f7238ff9a94d3dd774
>>>> --- /dev/null
>>>> +++ b/Documentation/core-api/list.rst
>>>> @@ -0,0 +1,847 @@
>>
>> [snip]
>>
>>>
>>> The text LGTM, thanks!
>>>
>>> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
>>>
>>
>> Please see https://people.kernel.org/tglx/notes-about-netiquette,
>> especially "Trim replies".
>>
>
> I did quote the whole diff to provide review context...
>
If you had commented on any specific lines in the patch, then that would
be necessary. Even if you were commenting on only a few lines of the patch,
most of the patch lines could be snipped out.
The Subject: gives us the review context. It's pointless & annoying to other readers
to have to scroll down thru an 847-line patch to see any kind of Tagged-by: reply.
thanks.
--
~Randy
next prev parent reply other threads:[~2025-07-03 6:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 20:24 Nicolas Frattaroli
2025-07-03 1:37 ` Bagas Sanjaya
2025-07-03 2:52 ` Jonathan Corbet
2025-07-03 2:54 ` Bagas Sanjaya
2025-07-03 3:24 ` Bagas Sanjaya
2025-07-03 4:16 ` Randy Dunlap
2025-07-03 5:48 ` Bagas Sanjaya
2025-07-03 6:06 ` Randy Dunlap [this message]
2025-07-03 6:39 ` Bagas Sanjaya
2025-07-03 6:55 ` Randy Dunlap
2025-07-03 14:10 ` Jonathan Corbet
2025-07-04 20:53 ` Randy Dunlap
2025-07-07 9:11 ` David Laight
2025-07-07 12:30 ` Nicolas Frattaroli
2025-07-13 7:08 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4bea8cb-1367-45ab-aae8-e29efbdbd082@infradead.org \
--to=rdunlap@infradead.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.frattaroli@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®