From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9933931D730 for ; Fri, 3 Apr 2026 17:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775235694; cv=none; b=EhBFBRQBWXU2by3R7Dv5Y1GM2p0L+ovUyC4/RCs30gWjRS895tupDDo5MRfx5cEVDNl6d5iV7JjicqzT1Iy9Ppw8UdY5mLk7dh8VptvyWm1+C1AtALdXar7Bq3KdTEH3q6ZqznGoSMLVFhy8RQF2bYPBNMYfcH84Mv4SH6HnoD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775235694; c=relaxed/simple; bh=PA0C4ej5YL/VzFP4tE4ta3PvKcduZVLgCuPM3C6M4eQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tLO+aHA+4zh4l9Ry8tEWtaxu+60wygU8ekhwbUcBwJOxcpHipdppQgD2vUWHVMFjTOwsQKrmWiz9MYVWwxJwqpOZnr0eE4DCSC4GvmeML0fVuZ2PFysQ3Qxl2TTQPLVKmJjJLNuROrjM9z7g2BeK0YR2oo6sS823RtsUufHZpgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Mmk1jOuI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CCWhpWZG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Mmk1jOuI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CCWhpWZG" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 633DVrC32359658 for ; Fri, 3 Apr 2026 17:01:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j2WCjm4bmftNP02ylQSc1VUrhgMuL1A1n9jIOcKmvYA=; b=Mmk1jOuItibzAY61 5woSpu+MRp8GecYFWmWVsXbC7WU8yBvutMc4CsO0WrZgSiyIgk5gP0bg5edvaRKL B0yda2FyHSQKngPNvkctzXEZaTecUQgo35b0Fp5UNmllAJYapaqcbpHw4MzXWlIT zy52BxksjcWxx1HdbqPY0wf30geET23v45ZQTOg/doOAePBu6AfEH/LtkhsH2rjr QDRSwO5RTZOOkeNx5EEj+QeiTKWAvk+Po6pA2FkQg2+0k9orkkuts0V0wzn9/sOd RLI5oghNoOR5ysLWwMKZhk7jgEJHnob3rr2BVE94m6ZbamNpDbt/hkHrGtW3qcA6 2E534A== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4daeh1gk63-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Apr 2026 17:01:32 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b242f76113so22884715ad.0 for ; Fri, 03 Apr 2026 10:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775235691; x=1775840491; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j2WCjm4bmftNP02ylQSc1VUrhgMuL1A1n9jIOcKmvYA=; b=CCWhpWZGrCWtQX+aO6UcoyGaQVt/Q0mjbj3xDFjrUqfArvOtM2FMseLobJHuJcgkls u3cMF59UxQM+8ZwFxpARLrrcQOKeRAT8jHN9vfqYYCZ5IZDrV431c5vDfTLDqgOWt0Af cVSWWYIV+XJ5HMAoehNd1+4Ov8QTSOo6plI4ZyB/23rzSbA5AF2UuKbmU5pgeX6R8+lH +a4J61G/syzEbi4YqNYiNZXNwz2ZnncD9FrZEKb+UgMZ0aoxzMVbjHyDFJTqPiwonS6F pFFcZdT3vpRkUlnHypSp3j/SWh6jXPLFUjNUeIqwUYj8Dr2Lrm9FJFRoPXZA2Tkclv5l oBvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775235691; x=1775840491; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j2WCjm4bmftNP02ylQSc1VUrhgMuL1A1n9jIOcKmvYA=; b=E9ol/dNBPb0NI6BAcEGYMSlmcmAdjrbwNw802qvsdDUIXc73h/W3zGs8wOGzZox+/o Qj9rtwT0im4OCjT+FlpE9FWpYLQbgrg74LhEmDLnr9yHXqUCQ52mrs5dC4n60Z9Q6sfM fhof9rbAGkwxCfwFs8CHJpf24NIdVu88vG7WoeOrIBVw0HVeD0C319JKcGVhm/d2cFr8 bVffpU7bNUJi54c3PaUFPMYlzC9AuD7LjOfhnKrmIEkF2e4ex4BrA+B60hiSOcPp2JRC 8ls7vwp104VU3IegezSr1q3jbYgBiHkRKIzO9U6FbyZCE8Snp54ZWXLDo8InEPEjHTR/ xm7w== X-Forwarded-Encrypted: i=1; AJvYcCWC0fZkt209PBEMufQFvbMh5I4bcitG/aSxtMaLOPr6tRE39ScAqOyItOLmTA5FgrwPxFSNJHS6djfjzFg=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ2V/qNzDwaIytueknE4KeXNoVjZWZC0wjlTQJbNjl/AqQeKuW gZfjBPBSVtaYxs1gJ59RuYhPiqD21iQ0jF1Iaat1yIY2C3LGBNu3xy5BzRyHes1Iubacofcm+0p PbRtxAaTD1NxpXxba9oZLW8oBmxlGo9Z3Xa/jBRngByG78YhOD1ukd2NHl6UoUmb7EmE= X-Gm-Gg: AeBDievF44LahIFGgAu1l2dOdo1ILYfQ2pxF0ibHeE2gzcsvRRrwKVl++eSL6Mkxdp6 yxS4N7gsgWC3UCWvERd6yfOALKvJB3oSZ81o0GxdFlKSCFTZycTYJ5s1KgZw/GkC7wvG23VNp6s ytpD+wfN2ytfbo7cqLaaW28ZBRcVDu/WOYq91WUlpA1h7OTVWSsBFtCy9hNBnGlPPcfKgyMBr3x FHGaRsMp95G8eUMO7HvVsGf2OSLBany3reHyUZjOeoMNRI+KlpcI8610++4p1ERat2cqSrOPT3T iKMj4JFUFic9neWKYsmmVqNPoTZXWQbaVi8C6/FEA1dCxko63Q6LbAZpxoczeDKLR8MlVPBMlps nOQui0BBmpaFxE/2dbm4V4jidUTTYERLukaYK6UjsqfnyitBERRw= X-Received: by 2002:a17:902:f642:b0:2b2:49a7:a5c4 with SMTP id d9443c01a7336-2b2818b00ccmr32553435ad.27.1775235691238; Fri, 03 Apr 2026 10:01:31 -0700 (PDT) X-Received: by 2002:a17:902:f642:b0:2b2:49a7:a5c4 with SMTP id d9443c01a7336-2b2818b00ccmr32553045ad.27.1775235690603; Fri, 03 Apr 2026 10:01:30 -0700 (PDT) Received: from [192.168.29.116] ([49.37.147.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749cbd4dsm61858985ad.76.2026.04.03.10.01.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2026 10:01:30 -0700 (PDT) Message-ID: Date: Fri, 3 Apr 2026 22:31:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Fix ICE reg size To: Kuldeep Singh , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Luca Weiss , Eric Biggers Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260402-ice_dt_reg_fix-v1-0-74e4c2129238@oss.qualcomm.com> <20260402-ice_dt_reg_fix-v1-1-74e4c2129238@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: <20260402-ice_dt_reg_fix-v1-1-74e4c2129238@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 8BrpA11wklPbH7qfEQeaUP3UXz73o155 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAzMDE1MiBTYWx0ZWRfXw1GD+FWMfMCI T/40JX/OjMZOjhhUS+zgGESMDMyLzfgpWg7p/H90kT82+FCb+ZDZL35CApT4ydVy966DoKHkDmC 2SWqYxBG8tY98ZkjfCPd+vsEdF58ctbTx6+fXPFS6h281gAvNqmNYRzpR7gxC0kCtAipj2Tf43k i3houfhqBBHGwyLOflmiNIoocnxBc4PNglC7x5r5wtrz4uWKM04NO8TbpNBlg5TijEF1p8dswgC N0R9t4adjTWi2XorCNIP9O+K6/XGMGcTu7YYbapZf0cjkUfIla7GassYc8zq2vs+wFCKaSgtuwY aIpXFJs4JFgqqmIACderG0Vq7tSLFm7EiKIfD0ux0JlaUgkk3d8JR3RqbeWndk856vy1lvI3OVM UQ7PPzX/m10nmrwhWYd/OrrSadXjn1yECGS3h/hvxdNoLjj8/rMFpwRPqKzYzJ6yTmP4RWInFgH Lat3LzElBz+BiZo/WmA== X-Proofpoint-ORIG-GUID: 8BrpA11wklPbH7qfEQeaUP3UXz73o155 X-Authority-Analysis: v=2.4 cv=JoT8bc4C c=1 sm=1 tr=0 ts=69cff26c cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=pj5RAjPJ5lVSI15MjsbsBQ==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=JbxdblzTRLZAtYUtz1gA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-03_05,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604030152 On 4/2/2026 12:05 AM, Kuldeep Singh wrote: > The ICE register region on Kodiak is currently defined as 0x8000 bytes. > According to the hardware specification, the correct register size is > 0x18000. > > Update the ICE node reg property to match the hardware. > > Fixes: dfd5ee7b34bb ("arm64: dts: qcom: sc7280: Add inline crypto engine") > Signed-off-by: Kuldeep Singh > --- > arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi > index 6079e67ea829..ed8361f79e28 100644 > --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi > +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi > @@ -2578,7 +2578,7 @@ ufs_mem_phy: phy@1d87000 { > ice: crypto@1d88000 { > compatible = "qcom,sc7280-inline-crypto-engine", > "qcom,inline-crypto-engine"; > - reg = <0 0x01d88000 0 0x8000>; > + reg = <0 0x01d88000 0 0x18000>; > clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; > }; > > Good catch, looks good to me. Reviewed-by: Harshal Dev Regards, Harshal