From: Olivier Langlois <olivier@trillion01.com>
To: Jens Axboe <axboe@kernel.dk>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Oleg Nesterov <oleg@redhat.com>,
Tony Battersby <tonyb@cybernetics.com>
Subject: Re: [PATCH] kernel: make TIF_NOTIFY_SIGNAL and core dumps co-exist
Date: Sun, 22 Aug 2021 16:55:06 -0400 [thread overview]
Message-ID: <e4c296adcb7f0b1fb0cc0acc21c129761b6e2b90.camel@trillion01.com> (raw)
In-Reply-To: <7fb2d8a6-951c-092c-ccaa-15522ae2ed01@kernel.dk>
On Thu, 2021-08-19 at 08:59 -0600, Jens Axboe wrote:
>
> You're absolutely right. On the io_uring side, in the current tree,
> there's only one check where current != task being checked - and
> that's
> in the poll rewait arming. That one should likely just go away. It
> may
> be fine as it is, as it just pertains to ring exit cancelations. We
> want
> to ensure that we don't rearm poll requests if the process is
> canceling
> and going away. I'll take a closer look at that one.
>
> For this particular patch, I agree it's racy. I'll see if I can come
> up
> with something better...
>
I have finally found the patch that you wanted me to test. I'm going to
do it ASAP despite still having issue.
I do have a different approach to solve the same core dump issue.
Feel free to consider it if this can avoid the race condition described
here.
next prev parent reply other threads:[~2021-08-22 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 3:06 Jens Axboe
2021-08-19 2:57 ` Linus Torvalds
2021-08-19 14:59 ` Jens Axboe
2021-08-22 20:55 ` Olivier Langlois [this message]
2022-03-21 18:20 ` Tony Battersby
2022-03-22 15:04 ` Eric W. Biederman
2025-06-27 20:52 ` Tony Battersby
2021-08-23 4:55 ` Olivier Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4c296adcb7f0b1fb0cc0acc21c129761b6e2b90.camel@trillion01.com \
--to=olivier@trillion01.com \
--cc=axboe@kernel.dk \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tonyb@cybernetics.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®