From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 101BC29A5; Mon, 6 Jan 2025 01:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736125561; cv=none; b=FxEnA+OB5ON9WvN/9pXEZ8wgIl4VCOd2FLGvhHJnYV8BSvyCmI9D68OLtYlXcDYDssI5htNRaMimZ8wi25TRn56LPB2NyqWh23yn+oyLOKbGvd/Sk6IQK0fyVJbEEB+TocRu0EPRyb6nCM7Rvyfe/Wh36fiJZd72scqhacwDXQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736125561; c=relaxed/simple; bh=3blgBORgK4NdYFGTz9Ri+gK5/9gA5YNNqV7GzL4pbSE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=c2cGdpskSpv/KYLHPdHdCjfIZefDDyebCh8QNkijOoJJ/q39GV6iAYZupe3olJ2ythmrTEtiH0UdizkF3j7nbF76zeS3+czR4vVU82k7mYU8831F38NYVhIRM4Q58E+twdx7V7b83oBuCajeddv+aJcQSrnmVXyozwMtPwM8hTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=F4a8IpZX; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="F4a8IpZX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1736125550; bh=3blgBORgK4NdYFGTz9Ri+gK5/9gA5YNNqV7GzL4pbSE=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=F4a8IpZX7p3nob6WLeVLKhUtmdlFQTOJybkWf6EE3pUHKwdAPq4dJxaK8lk2rAmDX d491pu/91cUSuzDIfR76OulTYLfVMGzS/WsKS+ZFDN6Rrs4qovgLl/sa/JuDHsVxSx EY4gADlVeabD0QmiFjEXeoZzRQl8AhWbk9pCDfY/tC2kR8FnyLqf/UHNRcv3DK/B4U z4+k5kh/527kBnbCG94F/hSHmXetW56jhYsmkRb7GbZ6+1VE4NNwk1UEGfsHFE0W7D CP3AHmVqxRLXzfBEO1tFhnY/UwKkVzGnNd56lcWTNprIY1bP6Z9inlTjjF5/vEziR+ pt6F/UV0Lj02w== Received: from [192.168.72.171] (210-10-213-150.per.static-ipl.aapt.com.au [210.10.213.150]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 15DF9707E6; Mon, 6 Jan 2025 09:05:48 +0800 (AWST) Message-ID: Subject: Re: [PATCH v11 0/1] MCTP Over PCC Transport From: Jeremy Kerr To: admiyo@os.amperecomputing.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Johnston , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudeep Holla , Jonathan Cameron , Huisong Li Date: Mon, 06 Jan 2025 09:05:48 +0800 In-Reply-To: <20250104035430.625147-1-admiyo@os.amperecomputing.com> References: <20250104035430.625147-1-admiyo@os.amperecomputing.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Adam, > Changes in V11: > - Switch Big Endian data types to machine local for PCC header This seems suspicious; the concept of "machine local" may not be consistent between channel endpoints (ie, system firmware and this driver). Looking at DSP0292, and the PCC channel spec, it looks like these should be explicitly little-endian, no? The warnings you were seeing in v10 seemed to be an issue of direct accesses to the __be32 types in struct mctp_pcc_hdr - ie., without be32_to_cpu() accessors. If you keep the endian-annotated types (but __le32 instead), and use the appropriate le32_to_cpu() accessors, that should address those warnings, while keeping the driver endian-safe. Cheers, Jeremy