From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6415EC4742C for ; Wed, 4 Nov 2020 01:45:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A61222404 for ; Wed, 4 Nov 2020 01:45:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730538AbgKDBpC (ORCPT ); Tue, 3 Nov 2020 20:45:02 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7138 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728567AbgKDBpB (ORCPT ); Tue, 3 Nov 2020 20:45:01 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CQqGJ6pKyz15Qjc; Wed, 4 Nov 2020 09:44:56 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 4 Nov 2020 09:44:56 +0800 Subject: Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages To: Gao Xiang CC: Gao Xiang , , Chao Yu , LKML , References: <20201022145724.27284-1-hsiangkao.ref@aol.com> <20201022145724.27284-1-hsiangkao@aol.com> <20201104011130.GA982972@xiangao.remote.csb> From: Chao Yu Message-ID: Date: Wed, 4 Nov 2020 09:44:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201104011130.GA982972@xiangao.remote.csb> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/4 9:11, Gao Xiang wrote: > On Wed, Nov 04, 2020 at 09:05:56AM +0800, Chao Yu wrote: >> On 2020/10/22 22:57, Gao Xiang wrote: >>> From: Gao Xiang >>> >>> pcluster should be only set up for all managed pages instead of >>> temporary pages. Since it currently uses page->mapping to identify, >>> the impact is minor for now. >>> >>> Fixes: 5ddcee1f3a1c ("erofs: get rid of __stagingpage_alloc helper") >>> Cc: # 5.5+ >>> Signed-off-by: Gao Xiang >> >> Reviewed-by: Chao Yu > > Thanks, I've also added a note to the commit message like this, > " > [ Update: Vladimir reported the kernel log becomes polluted > because PAGE_FLAGS_CHECK_AT_FREE flag(s) set if the page > allocation debug option is enabled. ] > " > Will apply all of this to -fixes branch. Thanks for noticing that, looks fine to me. Thanks, > > Thanks, > Gao Xiang > >> >> Thanks, >> > > . >