From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Max Kellermann <max.kellermann@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/6] [media] cx24116: Improve a size determination in cx24116_attach()
Date: Wed, 30 Aug 2017 09:22:07 +0200 [thread overview]
Message-ID: <e4cf3adb-0a9b-c412-0720-944a9dfd0ffc@users.sourceforge.net> (raw)
In-Reply-To: <d01b4a11-6e93-bc40-72de-dab9ce7b997a@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 30 Aug 2017 08:15:33 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/dvb-frontends/cx24116.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/cx24116.c b/drivers/media/dvb-frontends/cx24116.c
index 54f09a5a5075..74d610207bf2 100644
--- a/drivers/media/dvb-frontends/cx24116.c
+++ b/drivers/media/dvb-frontends/cx24116.c
@@ -1123,7 +1123,7 @@ struct dvb_frontend *cx24116_attach(const struct cx24116_config *config,
dprintk("%s\n", __func__);
/* allocate memory for the internal state */
- state = kzalloc(sizeof(struct cx24116_state), GFP_KERNEL);
+ state = kzalloc(sizeof(*state), GFP_KERNEL);
if (state == NULL)
goto error1;
--
2.14.1
next prev parent reply other threads:[~2017-08-30 7:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 7:18 [PATCH 0/6] [media] cx24116: Adjustments for two function implementations SF Markus Elfring
2017-08-30 7:19 ` [PATCH 1/6] [media] cx24116: Delete an error message for a failed memory allocation in cx24116_writeregN() SF Markus Elfring
2017-08-30 7:20 ` [PATCH 2/6] [media] cx24116: Return directly after a failed kmalloc() " SF Markus Elfring
2017-08-30 7:21 ` [PATCH 3/6] [media] cx24116: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-08-30 7:22 ` SF Markus Elfring [this message]
2017-08-30 7:23 ` [PATCH 5/6] [media] cx24116: Delete an unnecessary variable initialisation in cx24116_attach() SF Markus Elfring
2017-08-30 7:24 ` [PATCH 6/6] [media] cx24116: Delete jump targets " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4cf3adb-0a9b-c412-0720-944a9dfd0ffc@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=max.kellermann@gmail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome