From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751943AbdKVQ4b (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Nov 2017 11:56:31 -0500
Received: from mail-wm0-f49.google.com ([74.125.82.49]:42239 "EHLO
        mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751259AbdKVQ4a (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Nov 2017 11:56:30 -0500
X-Google-Smtp-Source: AGs4zMbSrL/jfAQQONqsbWope9pwGONLiHuXgqgf/eCRs97BBiPxTLp6ZBWUnwxHEMzBEGxJ0RxXuQ==
Subject: Re: [PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler
To: Liran Alon <LIRAN.ALON@ORACLE.COM>, Wanpeng Li <kernellwp@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Dmitry Vyukov <dvyukov@google.com>
References: <1511337410-8100-1-git-send-email-wanpeng.li@hotmail.com>
 <5A153926.7030004@ORACLE.COM> <5A153E5B.2060104@ORACLE.COM>
 <CANRm+CzMFizHBCNccFSDvSAaKOQQygx5mKkrB+4OKRYv-4ou2Q@mail.gmail.com>
 <5A1546A7.4080506@ORACLE.COM>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <e4d0ef8d-bddf-0514-1f3e-7b56806cfe49@redhat.com>
Date: Wed, 22 Nov 2017 17:56:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <5A1546A7.4080506@ORACLE.COM>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22/11/2017 10:43, Liran Alon wrote:
>>>
>>> I think we should also set "vmx->nested.smm.vmxon = false;"
>>> after "vmx->nested.vmxon = false;" to correctlyhandle the case
>>> VMXOFF is executed from SMI handler. Otherwise, when SMI handler
>>> executes RSM, we will reach vmx_pre_leave_smm() which will set
>>> again "vmx->nested.vmxon = true;" which I think shouldn't
>>> happen.
>>
>> I didn't see a real scenario for this.
>
> Actually I later saw that handle_vmoff() calls
> nested_vmx_check_permission() which indeed won't allow to continue
> executing if running from SMI because vmx->nested.vmxon=false; and
> therefore this will raise a #UD. So you are right. :)

Still, not clearing the flag is wrong.  free_nested is also called by
vmx_leave_nested when the host writes 0 to MSR_IA32_FEATURE_CONTROL with
KVM_SET_MSRS.

Paolo