From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Eddie James" <eajames@linux.ibm.com>, linux-kernel@vger.kernel.org
Cc: linux-aspeed@lists.ozlabs.org, "Joel Stanley" <joel@jms.id.au>,
maz@kernel.org, "Jason Cooper" <jason@lakedaemon.net>,
tglx@linutronix.de, "Rob Herring" <robh+dt@kernel.org>,
mark.rutland@arm.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 06/12] drivers/soc: Add Aspeed XDMA Engine Driver
Date: Mon, 25 Nov 2019 10:31:13 +1030 [thread overview]
Message-ID: <e4d49ccb-8b83-4c85-9be1-48d77c0000e2@www.fastmail.com> (raw)
In-Reply-To: <a600a526-2f11-4a37-b4f3-8f53c533db02@www.fastmail.com>
> > +static int aspeed_xdma_remove(struct platform_device *pdev)
> > +{
> > + struct aspeed_xdma *ctx = platform_get_drvdata(pdev);
> > +
> > + gen_pool_free(ctx->vga_pool, (unsigned long)ctx->cmdq_vga_virt,
> > + XDMA_CMDQ_SIZE);
>
> You've used devm_gen_pool_create(), so no need to explicitly free it.
Sorry, disregard that, brain-fart.
Andrew
next prev parent reply other threads:[~2019-11-24 23:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 20:18 [PATCH 00/12] Aspeed: Add SCU interrupt controller and XDMA engine drivers Eddie James
2019-11-08 20:18 ` [PATCH 01/12] dt-bindings: interrupt-controller: Add Aspeed SCU interrupt controller Eddie James
2019-11-12 0:54 ` Rob Herring
2019-11-08 20:18 ` [PATCH 02/12] irqchip: " Eddie James
2019-11-10 14:53 ` Marc Zyngier
2019-11-08 20:18 ` [PATCH 03/12] ARM: dts: aspeed: ast2500: Add " Eddie James
2019-11-08 20:18 ` [PATCH 04/12] ARM: dts: aspeed: ast2600: Add SCU interrupt controllers Eddie James
2019-11-08 20:18 ` [PATCH 05/12] dt-bindings: soc: Add Aspeed XDMA Engine Eddie James
2019-11-14 19:00 ` Rob Herring
2019-11-08 20:18 ` [PATCH 06/12] drivers/soc: Add Aspeed XDMA Engine Driver Eddie James
2019-11-24 23:32 ` Andrew Jeffery
2019-11-25 0:01 ` Andrew Jeffery [this message]
2019-11-25 19:15 ` Eddie James
2019-11-26 0:53 ` Andrew Jeffery
2019-11-08 20:18 ` [PATCH 07/12] drivers/soc: xdma: Add user interface Eddie James
2019-11-24 23:59 ` Andrew Jeffery
2019-11-25 19:44 ` Eddie James
2019-11-26 3:30 ` Andrew Jeffery
2019-12-04 15:26 ` Eddie James
2019-11-08 20:18 ` [PATCH 08/12] ARM: dts: aspeed: ast2500: Add XDMA Engine Eddie James
2019-11-08 20:18 ` [PATCH 09/12] ARM: dts: aspeed: ast2600: " Eddie James
2019-11-08 20:18 ` [PATCH 10/12] ARM: dts: aspeed: witherspoon: Enable " Eddie James
2019-11-08 20:18 ` [PATCH 11/12] ARM: dts: aspeed: rainier: Enable XDMA engine Eddie James
2019-11-08 20:18 ` [PATCH 12/12] ARM: dts: aspeed: tacoma: " Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4d49ccb-8b83-4c85-9be1-48d77c0000e2@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=jason@lakedaemon.net \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®