From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E99AEB64D9 for ; Mon, 19 Jun 2023 12:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231191AbjFSMs4 (ORCPT ); Mon, 19 Jun 2023 08:48:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbjFSMsp (ORCPT ); Mon, 19 Jun 2023 08:48:45 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 604FA113; Mon, 19 Jun 2023 05:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687178924; x=1718714924; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dBCyE2sw+S1qIRqycQBeE/+cUqHyEnIowfaY4Rl2/B0=; b=W8W6wXBpispPfRc95eyOgWsA+yJS225Jh80qFMIFvWk+kmcDgx+mc/XP xDdHCBth5F2vvVx7cIYYPdi+tYxQq8o0VF4F+FLXZoLX4SZylYe1LnxxN JVSYgEiFgSwt52gKOWZibn5hKRJvGVElbZbdomUdMtPuYwDeKR7J91fsE w10KDlTLM0+mWRipDvYwvBd9OXlqyl59wOfXVZOBuj1uugOzYs4eTEyns TediK9Co8MZy7VUg2Exzz8DbHiibUGhuacTJeHsR5t7CfiSVvveY/3Moj x3Fe5okhQb3FpfHfurReJb7Q7bTs7db2wjVnovGUn3Bqyf5I7OkNvH4LR g==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="349342761" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="349342761" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 05:48:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="837857967" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="837857967" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.252.61.10]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 05:48:39 -0700 Message-ID: Date: Mon, 19 Jun 2023 15:48:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.12.0 Subject: Re: [PATCH] tools: Optimize the variable with 0 as the return value Content-Language: en-US To: Li Dong , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Andi Kleen , "Steinar H. Gunderson" , "open list:PERFORMANCE EVENTS SUBSYSTEM" , "open list:PERFORMANCE EVENTS SUBSYSTEM" Cc: opensource.kernel@vivo.com References: <20230619112047.1966-1-lidong@vivo.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20230619112047.1966-1-lidong@vivo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/06/23 14:20, Li Dong wrote: > The variable ret is not used, replacing ret with 0 as the return value What kernel does that apply to? > > Signed-off-by: Li Dong > --- > tools/perf/util/intel-pt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c > index dbf0bc71a63b..a40017458185 100644 > --- a/tools/perf/util/intel-pt.c > +++ b/tools/perf/util/intel-pt.c > @@ -3398,7 +3398,6 @@ static int intel_pt_text_poke(struct intel_pt *pt, union perf_event *event) > struct machine *machine = pt->machine; > struct intel_pt_cache_entry *e; > u64 offset; > - int ret = 0; > > addr_location__init(&al); > if (!event->text_poke.new_len) > @@ -3439,7 +3438,7 @@ static int intel_pt_text_poke(struct intel_pt *pt, union perf_event *event) > } > out: > addr_location__exit(&al); > - return ret; > + return 0; > } > > static int intel_pt_process_event(struct perf_session *session,