From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935269AbeBMNOv (ORCPT ); Tue, 13 Feb 2018 08:14:51 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:42383 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935175AbeBMNOt (ORCPT ); Tue, 13 Feb 2018 08:14:49 -0500 Subject: Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device To: Laurent Pinchart Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Jean-Michel Hautbois , Sergei Shtylyov , Lars-Peter Clausen , Kieran Bingham , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <1518473273-6333-1-git-send-email-kbingham@kernel.org> <1518473273-6333-2-git-send-email-kbingham@kernel.org> <84376496.fPaZ5qpN3E@avalon> From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Tue, 13 Feb 2018 13:14:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <84376496.fPaZ5qpN3E@avalon> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On 13/02/18 12:06, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. Thank you for your review, > On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: >> From: Jean-Michel Hautbois >> >> The ADV7604 has thirteen 256-byte maps that can be accessed via the main >> I²C ports. Each map has it own I²C address and acts as a standard slave >> device on the I²C bus. >> >> Extend the device tree node bindings to be able to override the default >> addresses so that address conflicts with other devices on the same bus >> may be resolved at the board description level. >> >> Signed-off-by: Jean-Michel Hautbois >> [Kieran: Re-adapted for mainline] >> Signed-off-by: Kieran Bingham >> Reviewed-by: Rob Herring > > Nitpicking, I might not mention i2c_new_secondary_device in the subject, as > this is a DT bindings change. I don't mind too much though, as long as the > bindings themselves don't contain Linux-specific information, and they don't, > so How about: ... adv7604: Extend bindings to allow specifying slave map addresses > Reviewed-by: Laurent Pinchart Collected, thanks. -- Kieran > >> --- >> Based upon the original posting : >> https://lkml.org/lkml/2014/10/22/469 >> >> v2: >> - DT Binding update separated from code change >> - Minor reword to commit message to account for DT only change. >> - Collected Rob's RB tag. >> >> v3: >> - Split map register addresses into individual declarations. >> >> .../devicetree/bindings/media/i2c/adv7604.txt | 18 >> ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt >> b/Documentation/devicetree/bindings/media/i2c/adv7604.txt index >> 9cbd92eb5d05..ebb5f070c05b 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt >> +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt >> @@ -13,7 +13,11 @@ Required Properties: >> - "adi,adv7611" for the ADV7611 >> - "adi,adv7612" for the ADV7612 >> >> - - reg: I2C slave address >> + - reg: I2C slave addresses >> + The ADV76xx has up to thirteen 256-byte maps that can be accessed via >> the + main I²C ports. Each map has it own I²C address and acts as a >> standard + slave device on the I²C bus. The main address is mandatory, >> others are + optional and revert to defaults if not specified. >> >> - hpd-gpios: References to the GPIOs that control the HDMI hot-plug >> detection pins, one per HDMI input. The active flag indicates the GPIO >> @@ -35,6 +39,11 @@ Optional Properties: >> >> - reset-gpios: Reference to the GPIO connected to the device's reset pin. >> - default-input: Select which input is selected after reset. >> + - reg-names : Names of maps with programmable addresses. >> + It can contain any map needing a non-default address. >> + Possible maps names are : >> + "main", "avlink", "cec", "infoframe", "esdp", "dpp", "afe", >> + "rep", "edid", "hdmi", "test", "cp", "vdp" >> >> Optional Endpoint Properties: >> >> @@ -52,7 +61,12 @@ Example: >> >> hdmi_receiver@4c { >> compatible = "adi,adv7611"; >> - reg = <0x4c>; >> + /* >> + * The edid page will be accessible @ 0x66 on the i2c bus. All >> + * other maps will retain their default addresses. >> + */ >> + reg = <0x4c>, <0x66>; >> + reg-names "main", "edid"; >> >> reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>; >> hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>; > >