From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF14C40DFB0 for ; Thu, 26 Mar 2026 08:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774514129; cv=none; b=RHCwSfc4fDf16p1PdFDHTIykCZkiOpSut0gzTU6rzXPfdZnQUIjzOGEozB1/sD1BxzQ4QFePbbE2we0qNlkoGJpngSmmn5FC/rQbStHfnOK7wnNuS5cgXZOweXkYNrxmfr/bngOp0lGg7JDuOlhlNOtojTiFGJRiIdUIghuTOm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774514129; c=relaxed/simple; bh=O1kxheMr7GjziX/Tzwk8TMVL97S2FdlZrSmxqXiF3sM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=N/QUml3LfvItQnwrQ1VJuSevdSTuRFdJqk+CCC5EXwbd4Au625dbJLAX+OwaFSrhQp1JgZJ+r9bgT67x9ZX/NbQTyfuHxiGJI7Dr+mvoKKJg4AykW69UatV6RRsZylSH2b9yVOeHYcmJnMtUEEKtINZ/TAE5ez0IcDioNhvU0Wg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bjMV+U6j; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bjMV+U6j" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43b98652f05so77377f8f.1 for ; Thu, 26 Mar 2026 01:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774514126; x=1775118926; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=fnvsgNCpEbH4UYp5iVoGOvBVdC52HxKa6FniJfiCGlU=; b=bjMV+U6j0s5H3CGcUz0CliUK7zMQ/RTUzZQSJCUEcpnddWRq2f1KNFtKid9LNEdwoM Y0tEZXssoHZepfvVLw2NT4HHHcdTtjlM+UY+6leM0RHRqfbduevp2glPqsvTlbKpTJ4s jM+5HL4/QRFfTKxXVrAoswWdF80G/pmwqRY6HbIrJ97W+ht78Gj4SABXze9bFh8GksV8 5cB6KlCpSlfhEyJTdLvEAJ+H0340r1O7HQY7Ep3oyYO8EPKj5/1MtP7MR7s7PPd5gXQa DPGpZN9cAk7311cYkMFu/Qv4Yq5ttnmrRQAf478tre2vUSnE06NBK8c5iHgVV4L/k7L2 +nfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774514126; x=1775118926; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fnvsgNCpEbH4UYp5iVoGOvBVdC52HxKa6FniJfiCGlU=; b=gb0rbHx3HksqAbsQAAMg6uk6+sALeWCxpr5aQI6l+KJbDb+tbJbaizk/sYpl1OaiaK TCdXDGnNV1gNAi8CMJ6EF2oqn5d8rN0uaRu5yMNc3j1rVuCvOdPdUU3ii4rjmz1aif/C odFLL0Z/QKNNEwGy092HhoWB19ZLTICf2owYRsFSKftICE/pPLP2hnAan30bHHZHpf1a buvKNhhZyZiRvDsN9wW/J2j3gSt9iJcwR5VYUHX2O3GRSuNUobEWVC7j0GOXcHdpxcQD LKqd9fHq9889+Qj8EMptOpL1U6Ms+R5LBYpCaDS/fTlVPCvKVTh5JV3/Kksn+PalqcRL Pt0w== X-Forwarded-Encrypted: i=1; AJvYcCXmIMy3f/NzRvDZFEkpF64gLC8wvTtGLtKmG27DRDVjzJzq5wtvoLIGUM6S78BgAuDTNF470GYzu/Nxc/M=@vger.kernel.org X-Gm-Message-State: AOJu0YwsUdzCByCrw/WnBo5An1eJG+GjG5FjuodJJAeWSk6D4qqAYarD SQfdl7zVN6sWEoGIova/LKCfD0j1XChU295bRWFuXvAaTkxyVr1EM7vTzTNoQDEcZvo= X-Gm-Gg: ATEYQzx6bI7bAFRFHuI8YHAVl03MXo5H6lDQ2TwgsrR2oVIeXnCGmv21ghkk0Cv2sKd zPc3ALC8MoJAFAEFN6qqIiH2L1ozeM7iuvxRWXPgWES7IXc0N77Aj3aWNBOyfJVpRf7CXUyx1PL FvWlh8l9AnPvjKD5OjqdSNsE01pW/KSMu7IliyjAmAvi4ii+6QdRJtkGXv39XUnjP0aoaaBV0Sl qIU3fM2+w539kbf9QVbxly3EzgNf/BNqGCT3u0eRg5uJAjqwSv250xkAomeLMdvOPfljfjXeNmr yVpF1ReDvDe3gnYNExHhQQ9SH4Ed8wdVM1HCizbEyMn6ZRp/dEgtV7zpi5AugiI95hYz0YtFJs8 PFTNT3iXbYiU9dX+N7RFDD5bBT287kZ7UeVGMG9dcLPwn5uI7lA/vLf7QhY3hxLomxemlVqd6UA B5LcKpiuDuOSK0L5FTIwl/uO4O3MAObJW1ldgCR9gCJMPel56kn/mZ5jdKQLiNkIT4gU8mpcCgD f4lUaY= X-Received: by 2002:a05:6000:144d:b0:43b:3e34:7fe with SMTP id ffacd0b85a97d-43b889aefd2mr10034853f8f.21.1774514125851; Thu, 26 Mar 2026 01:35:25 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:8431:f88b:714d:f78d? ([2a01:e0a:106d:1080:8431:f88b:714d:f78d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919df903sm6711609f8f.30.2026.03.26.01.35.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 01:35:25 -0700 (PDT) Message-ID: Date: Thu, 26 Mar 2026 09:35:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v5 4/4] drm/panel: ilitek-ili9806e: add Rocktech RK050HR345-CT106A SPI panel To: Dario Binacchi , linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Michael Walle , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20260318073346.18041-1-dario.binacchi@amarulasolutions.com> <20260318073346.18041-5-dario.binacchi@amarulasolutions.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260318073346.18041-5-dario.binacchi@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/18/26 08:32, Dario Binacchi wrote: > Add support for the Rocktech RK050HR345-CT106A panel based on the > Ilitek ILI9806E controller using the SPI bus. > > The driver is designed to be easily extensible to support other panels > with different initialization sequences and display timings by > providing a specific descriptor structure for each model. > > Signed-off-by: Dario Binacchi > > --- > > Changes in v5: > - Add Reviewed-by tag of Neil Armstrong for patches: > - 1/4 drm/panel: ilitek-ili9806e: rename to specific DSI driver > - 2/4 drm/panel: ilitek-ili9806e: split core and DSI logic > > Changes in v4: > - Fix "WARNING: unmet direct dependencies detected for > DRM_PANEL_ILITEK_ILI9806E_CORE" reported by kernel test robot > > Changes in v3: > - Add Reviewed-by tag of Rob Herring > > Changes in v2: > - Introduce DRM_PANEL_ILITEK_ILI9806E_CORE hidden kconfig option. > - Split core and DSI logic. > - Restore vdd-supply as required for both DSI and SPI types in the > dt-bindings. > - Dop useless settings in case of rocktech,rk050hr345-ct106a in the > dt-bindings. > > MAINTAINERS | 1 + > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > .../drm/panel/panel-ilitek-ili9806e-core.c | 31 +- > .../gpu/drm/panel/panel-ilitek-ili9806e-spi.c | 323 ++++++++++++++++++ > 5 files changed, 355 insertions(+), 13 deletions(-) > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e-spi.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index fcb91fe8d061..15e88008bd14 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8027,6 +8027,7 @@ F: drivers/gpu/drm/panel/panel-ilitek-ili9805.c > > DRM DRIVER FOR ILITEK ILI9806E PANELS > M: Michael Walle > +M: Dario Binacchi > S: Maintained > F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-* > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 7fc20421cba5..ec12850fc231 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -270,6 +270,18 @@ config DRM_PANEL_ILITEK_ILI9806E_DSI > Say Y if you want to enable support for panels based on the > Ilitek ILI9806E controller using DSI. > > +config DRM_PANEL_ILITEK_ILI9806E_SPI > + tristate "Ilitek ILI9806E-based RGB SPI panel" > + depends on OF > + depends on SPI > + depends on BACKLIGHT_CLASS_DEVICE > + select DRM_MIPI_DBI > + select VIDEOMODE_HELPERS > + select DRM_PANEL_ILITEK_ILI9806E_CORE > + help > + Say Y if you want to enable support for panels based on the > + Ilitek ILI9806E controller using SPI. > + > config DRM_PANEL_ILITEK_ILI9881C > tristate "Ilitek ILI9881C-based panels" > depends on OF > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index f56dafb36499..948c4a2d58ff 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -28,6 +28,7 @@ obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9341) += panel-ilitek-ili9341.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9805) += panel-ilitek-ili9805.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_CORE) += panel-ilitek-ili9806e-core.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_DSI) += panel-ilitek-ili9806e-dsi.o > +obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_SPI) += panel-ilitek-ili9806e-spi.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9882T) += panel-ilitek-ili9882t.o > obj-$(CONFIG_DRM_PANEL_INNOLUX_EJ030NA) += panel-innolux-ej030na.o > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c > index c088685d9d85..be2cf1440155 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -20,15 +21,11 @@ struct ili9806e { > void *transport; > struct drm_panel panel; > > + unsigned int num_supplies; > struct regulator_bulk_data supplies[2]; > struct gpio_desc *reset_gpio; > }; > > -static const char * const regulator_names[] = { > - "vdd", > - "vccio", > -}; > - > void *ili9806e_get_transport(struct drm_panel *panel) > { > struct ili9806e *ctx = container_of(panel, struct ili9806e, panel); > @@ -44,7 +41,7 @@ int ili9806e_power_on(struct device *dev) > > gpiod_set_value(ctx->reset_gpio, 1); > > - ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); > + ret = regulator_bulk_enable(ctx->num_supplies, ctx->supplies); > if (ret) { > dev_err(dev, "regulator bulk enable failed: %d\n", ret); > return ret; > @@ -65,7 +62,7 @@ int ili9806e_power_off(struct device *dev) > > gpiod_set_value(ctx->reset_gpio, 1); > > - ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); > + ret = regulator_bulk_disable(ctx->num_supplies, ctx->supplies); > if (ret) > dev_err(dev, "regulator bulk disable failed: %d\n", ret); > > @@ -78,7 +75,8 @@ int ili9806e_probe(struct device *dev, void *transport, > int connector_type) > { > struct ili9806e *ctx; > - int i, ret; > + bool set_prepare_prev_first = false; > + int ret; > > ctx = devm_kzalloc(dev, sizeof(struct ili9806e), GFP_KERNEL); > if (!ctx) > @@ -87,11 +85,16 @@ int ili9806e_probe(struct device *dev, void *transport, > dev_set_drvdata(dev, ctx); > ctx->transport = transport; > > - for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) > - ctx->supplies[i].supply = regulator_names[i]; > + ctx->supplies[ctx->num_supplies++].supply = "vdd"; > + if (of_device_is_compatible(dev->of_node, > + "densitron,dmt028vghmcmi-1d") || > + of_device_is_compatible(dev->of_node, > + "ortustech,com35h3p70ulc")) { > + ctx->supplies[ctx->num_supplies++].supply = "vccio"; > + set_prepare_prev_first = true; > + } > > - ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), > - ctx->supplies); > + ret = devm_regulator_bulk_get(dev, ctx->num_supplies, ctx->supplies); > if (ret) > return dev_err_probe(dev, ret, "failed to get regulators\n"); > > @@ -106,7 +109,9 @@ int ili9806e_probe(struct device *dev, void *transport, > if (ret) > return dev_err_probe(dev, ret, "Failed to get backlight\n"); > > - ctx->panel.prepare_prev_first = true; > + if (set_prepare_prev_first) > + ctx->panel.prepare_prev_first = true; > + > drm_panel_add(&ctx->panel); > > return 0; > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-spi.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-spi.c > new file mode 100644 > index 000000000000..9d10b0d28f52 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-spi.c > @@ -0,0 +1,323 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * SPI interface to the Ilitek ILI9806E panel. > + * > + * Copyright (c) 2026 Amarula Solutions, Dario Binacchi > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > + > +#include