mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Hans Westgaard Ry <hans.westgaard.ry@oracle.com>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	Matan Barak <matanb@mellanox.com>,
	Erez Shitrit <erezsh@mellanox.com>,
	Bart Van Assche <bart.vanassche@sandisk.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Hakon Bugge <haakon.bugge@oracle.com>,
	Yuval Shaia <yuval.shaia@oracle.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IBcore/CM: Issue DREQ when receiving REQ/REP for stale QP
Date: Wed, 14 Dec 2016 12:55:41 -0500	[thread overview]
Message-ID: <e4dad5d5-f9d7-e198-e53c-797a0d639d2c@redhat.com> (raw)
In-Reply-To: <1477653269-27359-1-git-send-email-hans.westgaard.ry@oracle.com>


[-- Attachment #1.1: Type: text/plain, Size: 1471 bytes --]

On 10/28/2016 7:14 AM, Hans Westgaard Ry wrote:
> from "InfiBand Architecture Specifications Volume 1":
> 
>   A QP is said to have a stale connection when only one side has
>   connection information. A stale connection may result if the remote CM
>   had dropped the connection and sent a DREQ but the DREQ was never
>   received by the local CM. Alternatively the remote CM may have lost
>   all record of past connections because its node crashed and rebooted,
>   while the local CM did not become aware of the remote node's reboot
>   and therefore did not clean up stale connections.
> 
> and:
> 
>    A local CM may receive a REQ/REP for a stale connection. It shall
>    abort the connection issuing REJ to the REQ/REP. It shall then issue
>    DREQ with "DREQ:remote QPN” set to the remote QPN from the REQ/REP.
> 
> This patch solves a problem with reuse of QPN. Current codebase, that
> is IPoIB, relies on a REAP-mechanism to do cleanup of the structures
> in CM. A problem with this is the timeconstants governing this
> mechanism; they are up to 768 seconds and the interface may look
> inresponsive in that period.  Issuing a DREQ (and receiving a DREP)
> does the necessary cleanup and the interface comes up.
> 
> Signed-off-by: Hans Westgaard Ry <hans.westgaard.ry@oracle.com>
> Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>

Thanks, applied.


-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

  parent reply	other threads:[~2016-12-14 17:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28 11:14 Hans Westgaard Ry
2016-10-30 21:06 ` Sagi Grimberg
2016-10-31  4:52   ` santosh.shilimkar
2016-12-14 17:55 ` Doug Ledford [this message]
2017-02-01 11:17 ` [PING][PATCH] " Hans Westgaard Ry
2017-02-01 11:44   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4dad5d5-f9d7-e198-e53c-797a0d639d2c@redhat.com \
    --to=dledford@redhat.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=erezsh@mellanox.com \
    --cc=haakon.bugge@oracle.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=hans.westgaard.ry@oracle.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matanb@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=sean.hefty@intel.com \
    --cc=yuval.shaia@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®