From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Buday Csaba <buday.csaba@prolan.hu>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: mdio: reset PHY before attempting to access registers in fwnode_mdiobus_register_phy
Date: Mon, 13 Oct 2025 16:31:10 +0200 [thread overview]
Message-ID: <e4dbb9e0-4447-485a-8b64-911c6a3d0a29@bootlin.com> (raw)
In-Reply-To: <20251013135557.62949-2-buday.csaba@prolan.hu>
Hi,
On 13/10/2025 15:55, Buday Csaba wrote:
> When the ID of an ethernet PHY is not provided by the 'compatible'
> string in the device tree, its actual ID is read via the MDIO bus.
> For some PHYs this could be unsafe, since a hard reset may be
> necessary to safely access the MDIO registers.
> This patch makes it possible to hard-reset an ethernet PHY before
> attempting to read the ID, via a new device tree property, called:
> `reset-phy-before-probe`.
>
> There were previous attempts to implement such functionality, I
> tried to collect a few of these (see links).
>
> Link: https://lore.kernel.org/lkml/1499346330-12166-2-git-send-email-richard.leitner@skidata.com/
> Link: https://lore.kernel.org/all/20230405-net-next-topic-net-phy-reset-v1-0-7e5329f08002@pengutronix.de/
> Link: https://lore.kernel.org/netdev/20250709133222.48802-4-buday.csaba@prolan.hu/
> Signed-off-by: Buday Csaba <buday.csaba@prolan.hu>
This should probably be accompanied by a DT binding update,
with some justification that this is indeed HW description
and not OS confguration.
At least the use of the term "probe" in the property makes this
sound like OS configuration, maybe something like :
"phy-id-needs-reset" ?
Maxime
next prev parent reply other threads:[~2025-10-13 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 13:55 [PATCH 1/2] net: mdio: common handling of phy reset properties Buday Csaba
2025-10-13 13:55 ` [PATCH 2/2] net: mdio: reset PHY before attempting to access registers in fwnode_mdiobus_register_phy Buday Csaba
2025-10-13 14:31 ` Maxime Chevallier [this message]
2025-10-15 9:07 ` Buday Csaba
2025-10-15 9:48 ` Russell King (Oracle)
2025-10-13 14:13 ` [PATCH 1/2] net: mdio: common handling of phy reset properties Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4dbb9e0-4447-485a-8b64-911c6a3d0a29@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=buday.csaba@prolan.hu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®