From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C76138B7DD for ; Tue, 7 Apr 2026 06:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775544561; cv=none; b=bBkmQJUIa9mFkYpLxTjjtUVVNrvipY+uJQrAttcOtTvrRt1EENqLdAO5yaX6ZNr9Fe7cE+ZN6+MOqxFd7Regu2BXgNv91w8O0vvnDkT1pUCUqcWCRA1FnV37LDPQS0B/Ie9mcm+3ohGqCG904A9ji53uXOxeClkO4Pvum2qZG2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775544561; c=relaxed/simple; bh=ElB9Q6wjeKkH5o3t3M5qORJdH/927KhFCKLUC8zpLfE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AqMdtw2E/YkvLp1AdGnhUGTBvBcWUkbAiX+Tt5SNTmi0Pe4N0E6RBn87/VaOr8eKK470TC6FJVU8ixDVlXQqAkTPdUqTf2qxBENGiXWchoTiqQ9Gxe+28AccCTkbaaZUt2gCN9T7GUZErfPMVEZYojiH9RD2FWeBUq0KX2esLl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ihi1kN25; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PF4+rytI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ihi1kN25"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PF4+rytI" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6376Kgsu1404160 for ; Tue, 7 Apr 2026 06:49:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gTTq1wh4HXvCWB55XG0GY/u8L0iiLNeuQjUXCQfwBBs=; b=ihi1kN25R9yZbXx9 Ne5xjUfbiLZxb7S/6U+mA9WwKVe2KS75q3ID2pFrBQRJdp55/OPo4UYtK3DfX7ke Lj+CRyuXGb+jaCxyODagBIigcOHAQxkh3NNLdzAbC7N/TVuYIyFEroke8B/m+pNn hqnYLOVe22nwoquBITPt0HoedbbVwZ6GWc/aztPKeE9XgDZO1hPmNQqliDg50DCb xo3OeLhlZQaO20/X1vCKN42GdBfp9Kf+ZDfnuLkfiB0scq2ocA6N+xSuFhK2fank xkda9SC/hS5sTUdEzqLOPK01DFx2gRCqdGFOy5pb3hkohOkMVDtAuYZ8+u8Nn1zR U4T47A== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr89egc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 06:49:19 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35d9dceda3aso1039607a91.1 for ; Mon, 06 Apr 2026 23:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775544558; x=1776149358; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gTTq1wh4HXvCWB55XG0GY/u8L0iiLNeuQjUXCQfwBBs=; b=PF4+rytIVzc6Tp/rIN5DaPOlDRVwrDfLSdd5A3Ir4cKj7XV6AJncQAUoaDBPTI5IPm HCAtD/o6uMmQ1aWoa7p+3LFBrsWNU5rtKxVD5aANJSb+dqUG34DDLTr7x7odEoTj11h9 4Q4d6xb0/KG4pFyhc1OAdCNyjA6NIY/5GbiYyXT7cj3PHlEN+ZuxLUCALuoZkzMkEes3 bfi7VnbDQntB7kxCKzDBzUGGqcpIsJGUyvE9IT1VDo6FF8+oxZW0yKZnBkzuXnOoM2Oz b1Uau9Xicf4gbOKV1u4qvRfBNnOfVKkgkKM9qb8JlciOBdQ1V78xSRLXtneTIeghwcyR 4V6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775544558; x=1776149358; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gTTq1wh4HXvCWB55XG0GY/u8L0iiLNeuQjUXCQfwBBs=; b=jZoiuhxyEokNooNwm8H4PrUpteWwue0HmNiEFiRUfC1z7pzRVplo4lP2Y8MIOVa2xY NodRhaEe6ZqtnxGN7e3A1PnJpNyOHjhh8KsQ34AMqy2xnTfqQwcBUDjc/+2/p9RRG+4M CBqUzSu7zFnVDdzIJ4ESmqSw6vJz91nlStuMSyspoxeTIHo5Syez5QoDhKgoBk/hiDav pOc2v5BZ2Hp9/vt48VDk3UjwJ3+0KI4TddFt6cyiFquZZyBhPK8AH6XWv2x4QzmGkoyE W4cROX6FUOO5Ocf7FHAIHVFjJAp2O0KadgXdCG4BFYoa36Hr8Jad+a25DF0WEGjdDNFA OnNw== X-Forwarded-Encrypted: i=1; AJvYcCXJP1N1G6y6ZaW0SW2v8MlasGGzCYLU2u6WcQqkToRbXh6w2h3RpQZJ1llpgghRA0JEGMG8Mu6wIpZgT9k=@vger.kernel.org X-Gm-Message-State: AOJu0YzbEwJJa/2b/iG5uAOrRMam81sW7L0lGCKTLPV4hLUU0QibMMeC vgFy/Dct/tfAYKBfb0PpVuktvQ5m7XjgzQ/KeP5XdvO4GbilrXjb1aOhZfjK9rsp3MzwA98rVFZ kemMdZTizBUGjXxdoTqSZim9rep7i8t4eOcCU/IrxYa0xU+MHU/kLEu+irHkJrYXsdec= X-Gm-Gg: AeBDietgAqXH2ky8cR/houXEVZbQEP5gpAAHnCEBvXYQHsFKmcHwEDYXVb+7VuOLTfx wC/SahpAVJ0qie61yZVB1CAN+RX/JdTF4y1U6Z+eGWcX4FUtd2IsNbbV89fQCUvF3Zlp3CDsXX0 onhYTi+40xX3i3qWsxdZ1I0COgUmBtUEzdhwoVBfXfhIADk2oHv3xO9VF/ai9nqX0AES9FYA+RM B/TOnMbJPZabs+nEcVGMSpEkLuZGGcSSIgrlcvYJcE9KGT4LkcQl7EYXqrBC7Jw1IWaokH4o6Kp lK0hsoF5pdW7NzugSQYQEUou1yqr1RvymZFvYT5PQXj9jRx9dK1hLa+gpOyNBxN/1FhwUB4W3lc 4tfvjXF/ihN5yg4ydCPhzYW5UlQGSBa81aHrfe7Qd+wT4Ug== X-Received: by 2002:a17:90b:2fc4:b0:35d:9d38:5375 with SMTP id 98e67ed59e1d1-35de6809efemr8591991a91.1.1775544558013; Mon, 06 Apr 2026 23:49:18 -0700 (PDT) X-Received: by 2002:a17:90b:2fc4:b0:35d:9d38:5375 with SMTP id 98e67ed59e1d1-35de6809efemr8591964a91.1.1775544557452; Mon, 06 Apr 2026 23:49:17 -0700 (PDT) Received: from [10.231.195.100] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe9709b8sm19867415a91.16.2026.04.06.23.49.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 23:49:16 -0700 (PDT) Message-ID: Date: Tue, 7 Apr 2026 14:49:11 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] arm64: dts: qcom: kaanapali-mtp: Enable bluetooth and Wifi To: Dmitry Baryshkov Cc: Jingyi Wang , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 20260224-knp-dts-misc-v6-0-79d20dab8a60@oss.qualcomm.com References: <0279f334-95ed-4df8-9e42-749fd854c551@oss.qualcomm.com> <3xb6ya4zxhmaode3u3al5r4g3rfzlq2ifbyodvwtr3qgt34pwc@ia2xqfaeufd2> <4a3887f7-9445-4d46-b250-5fb160c9795b@oss.qualcomm.com> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Q1krnsa80aA6no1zgkgEzsdJhfJip7us X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDA2MSBTYWx0ZWRfXyAvEfgvCr/ey J7yOWu5PJFK3nSTnN0TQu/19Du2lATxmPH8hR1s2W4/AYIlw5HJMV1e56f/ogGAzNeABQmfPlDu zuGegabQq9QTE13YavzffTfklJc0ZdhSjwJ905oTYR9h4vUkHBBI9zySOeZ4+eNn/1Mye2keFRb 6i7Ko9KZ7iYhlOKWDSRxdj33dkOe2+R0xisy3Fj0zY/krqa7zn0cGYT2qlWaXdpBDCtmKf/mnkM 9zj9M/Jy+u4HfC41S4QDUE+U91WwVNsnArX6x8dv/V9PJ8ed5FVot7LcnPmI+vyxqYTuwQvV1nW uPhkVaZ+QZ1PW4Uf31Z+7xGUoI7kve4d/uWKPomq9BLu60Sb5Kqr4mqudnvEfwuzw4Z8gYZWJRh XTB4197lwJ9eC2dI2nsMZBcItj4rd8+OwlbvDRhs1meNmer6DUl+YdH5eJI8UUdsyXz++yyBbWF hrrwKs/Un8GeJCfzqhA== X-Proofpoint-GUID: Q1krnsa80aA6no1zgkgEzsdJhfJip7us X-Authority-Analysis: v=2.4 cv=A/hc+aWG c=1 sm=1 tr=0 ts=69d4a8ef cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=JdHaf1hwYJhrKAK1CHEA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070061 On 4/1/2026 10:07 PM, Dmitry Baryshkov wrote: >>>> 2) its driver does not parse and use the property 'swctrl-gpios', moreover, the >>>> property have no user within upstream DT tree. >>> There is no "driver" in the "DT bindings" >>> >> 'its driver' i mean here is the driver which drives the device which is generated >> by this DT node 'qcom,wcn7850-pmu'. >> source code of the driver is drivers/power/sequencing/pwrseq-qcom-wcn.c > DT describes the hardware. The driver behaviour is not that relevant > here. agree with your opinion which is right (^^) > >>>> 3) the property is not mandatory based on binding spec. >>> Which is expected, because on some platforms it might be not wired up >>> and on the other platforms the pin to which it is wired to might be >>> unknown (think about all the phones for which the community doesn't have >>> schematics). >>> >> got your points and will explain mine at below 2) together. >> >>>> 4) upstream DT tree have had many such usages as mine which just set default pin >>>> configuration and not specify 'swctrl-gpios' explicitly. >>> I don't understand this part. >>> >> For DT node 'qcom,wcn7850-pmu' of products identified by the following dts file at least: >> >> wcn7850-pmu { >> compatible = "qcom,wcn7850-pmu"; >> >> pinctrl-names = "default"; // config SW_CTRL pin default settings, but >> pinctrl-0 = ....; // this DT node does not specify property 'swctrl-gpios'. >> .... >> } >> >> >> grep -l -r "qcom,wcn7850-pmu" arch/arm64/boot/dts/qcom/ | xargs grep -l -r "sw[_-]ctrl" >> arch/arm64/boot/dts/qcom/sm8550-hdk.dts >> arch/arm64/boot/dts/qcom/sm8650-qrd.dts >> arch/arm64/boot/dts/qcom/sm8750-mtp.dts >> arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts >> arch/arm64/boot/dts/qcom/sm8550-qrd.dts >> arch/arm64/boot/dts/qcom/sm8650-hdk.dts > So, let's fix them too. > perhaps. also fix for kaanapali-mtp whose DT have gone into linux-next. BTW, there may be other 'qcom,wcnxxxx-pmu' which have the same problem to fix besides 'qcom,wcn7850-pmu'. >>>> 5) kaanapali-mtp is originally preinstalled with android OS which supports some >>>> qualcomm specific feature which have not been supported by up-stream kernel. >>>> so kaanapali-mtp H/W has some wired pins which is not used by up-stream >>>> kernel sometimes >>> Again, what does that have to do with the hardware description? >> kaanapali-mtp hardware supports the feature pin SW_CTRL involved, but we can decide >> not to enable the feature based on requirements. >> >> any advise about how to correct DTS to not enable the feature SW_CTRL involved ? > You can enable or disable something in the driver. It doesn't change the > way the chip is wired (that's what DT describes). got it. thank you. (^^)