From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D192989BC for ; Sat, 4 Apr 2026 14:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775312749; cv=none; b=VDhrsYWCswthbg1vOnFydNvGlnyrCKWLUg17FHnWEZPx1ow6kHW0mVZlrvdCm1Re2QU15D1Rc+c9/Is1MMnRsVxu85LYjn+tB+6+tMwA27KQOaM87r3QxuQj1P8NWeG+Rs6uUu3To8ayQaj4Zprnsr47Sss1R5+Ym0ZWjVggKaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775312749; c=relaxed/simple; bh=YDHQQIkUtIMA5RuVXX+SK+ZopnAIz0IH3aZAqaHI9pk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WISKKB+4qqBstVLIOmliDS4gYKxO6iqWZd6AYUTLj5cPhvpBQU2JjGSlDLZYfFq9g96sRXrTm/CGxODu+CbhScOU0siXaqFVFot8jMMc56JTegihmnSb4LkJlfw3Mmmyuc4fFQKVuWyAi/dfcun9SVnv6l176ZlVfefefsVRm3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=T+tHPtq/; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="T+tHPtq/" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-46fc5b8a068so342334b6e.3 for ; Sat, 04 Apr 2026 07:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775312745; x=1775917545; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DG8ZLzSkLL5KxGbpBt+cYKmm52XpYZesZWRmcIu235A=; b=T+tHPtq/ZJmrz/x0hon6ubvef3dyaaHhk1GRRXgW8y8HepFtZGYjfJcUQczd3MEkSt 2Agviun9Cf5EYKtk9j0IqUraHya5+cWg7jpTqs6odctBlL2Zz+DNQ/uNqQMe9wgH193o z3zeYYVklZaMQki3yiMddob47zunpO6AWKU8n5PWDQ6LxULv6X3f1wcyghb+It/+xjWX z9PNVkRx7eWxmjJNLwRnRuJlliHjZbQNuYTor2Ij+hbvfTGn47XIa2O2GDia9HEi0TFp QBOE28LuVqSi18lbs2VxGAN1lYamyOifHSPJ/JYonO7K4FYFJ/G3E8jlIr/y0xjtfZ+C UNXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775312745; x=1775917545; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DG8ZLzSkLL5KxGbpBt+cYKmm52XpYZesZWRmcIu235A=; b=AjtAZgzbvCZOxGq35bVpNcPflXYm9nxg8dlhyQJ+0h8kKtl32PQmZ6aZVGtWzU/Fzz gA2EFwPr4Sc+cUJxrRmSHomAksPhXTF/7fbYNd+i8EbER7YO2tdcPYGz+OBrf1YqH+Rf xMFLl8JNoq4vnUiVmuavWtffngXJtlABR9sHTi8RdSq+6b75oLaXA9y5ibWXjvZKLuS2 mcUJ5B/uQnJDtQyI7ScrU65hHrfw5NKtwU+JdZVpud27FRPB6MCOIKl37sr5+xMyqwlO /jqQ1ZaSYo97c+G/ILShovQmjO/hoqAdZV+Af7bHNkaQSazve8CYcnbyzD2D3hQ4b5Vz 9QiQ== X-Forwarded-Encrypted: i=1; AJvYcCU2bvkr/4U2VL/QqbwVNxlEQXy5hxiy5bB8GG0xc1Y2unG6uhasQGRkz7iVI/hhKLUCviLJ9IiBuaw939U=@vger.kernel.org X-Gm-Message-State: AOJu0YzbB99Nq5o8HB6HFnKgHkLiSdQPtx0sQjueiw5NwFF17mqg2yJh x+NwUDmaiiPtVkkOnnP7jnue6WMnP80zpJ37swZ+DT1hZXdQLg8Ej+uonBDo3yx1/SQ= X-Gm-Gg: AeBDieuTRAqRbyFdtVhGUtvS8LnaTFEIPZGqsVycw2xqLBhBxmmalgMxR3U54kNESDi 0nT4KfBx208a87hQaOJ+oeXPzTYZQBA6eSw8ZXdd/W/9zbkS9LLNp4WuI6rdEvDnNWHrpL+zpxL /YU72wy+27prq5ElzYcUvjQi/ayao2G19LhJvlvQM1QmLyFmvzT1JaWmJGFHhgnNegKQDYSSW0d if6Que1RPV1uhct/wL6He6nItWAOnuIqtG7hxliTh2QD64QJRt2oyuPSqVVpTg2bCP1F4jzkXJV K5272s/xGJW4y2i1zAqv7HGdjW3bamq4E26gQNom1cC4EVkKMCaLU73m8Jf4uLkDhIRu9ysBUJX 36cIAbQH8tkNnbndYvGran3YNEspgnei9yfVBJbwDkFbke+t2RygdydIYaZ8ySZH/d+n8fR0piA dCzGDFh/zKgUOLmCW37nhPhaZQ1kYDJ3nMGvcDR2BJ5nueXHCCkSBGOAX1Gj7Fin99Jar3xnvJY Q== X-Received: by 2002:a05:6808:1206:b0:46a:8dd5:3a4f with SMTP id 5614622812f47-46ef5002b8dmr3010289b6e.5.1775312744846; Sat, 04 Apr 2026 07:25:44 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:e14e:bcc6:3f95:26eb? ([2600:8803:e7e4:500:e14e:bcc6:3f95:26eb]) by smtp.gmail.com with ESMTPSA id 5614622812f47-46f0f4e16a9sm2936944b6e.4.2026.04.04.07.25.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Apr 2026 07:25:43 -0700 (PDT) Message-ID: Date: Sat, 4 Apr 2026 09:25:41 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/4] iio: adc: ad4691: add initial driver for AD4691 family To: radu.sabau@analog.com, Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Philipp Zabel , Jonathan Corbet , Shuah Khan Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org References: <20260403-ad4692-multichannel-sar-adc-driver-v6-0-fa2a01a57c4e@analog.com> <20260403-ad4692-multichannel-sar-adc-driver-v6-2-fa2a01a57c4e@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260403-ad4692-multichannel-sar-adc-driver-v6-2-fa2a01a57c4e@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/3/26 6:03 AM, Radu Sabau via B4 Relay wrote: > From: Radu Sabau > > Add support for the Analog Devices AD4691 family of high-speed, > low-power multichannel SAR ADCs: AD4691 (16-ch, 500 kSPS), > AD4692 (16-ch, 1 MSPS), AD4693 (8-ch, 500 kSPS) and > AD4694 (8-ch, 1 MSPS). > > The driver implements a custom regmap layer over raw SPI to handle the > device's mixed 1/2/3/4-byte register widths and uses the standard IIO > read_raw/write_raw interface for single-channel reads. > > The chip idles in Autonomous Mode so that single-shot read_raw can use > the internal oscillator without disturbing the hardware configuration. > > Three voltage supply domains are managed: avdd (required), vio, and a > reference supply on either the REF pin (ref-supply, external buffer) > or the REFIN pin (refin-supply, uses the on-chip reference buffer; > REFBUF_EN is set accordingly). Hardware reset is performed via > the reset controller framework; a software reset through SPI_CONFIG_A > is used as fallback when no hardware reset is available. > > Accumulator channel masking for single-shot reads uses ACC_MASK_REG via > an ADDR_DESCENDING SPI write, which covers both mask bytes in a single > 16-bit transfer. > > Signed-off-by: Radu Sabau > --- This patch looks in good shape. Although I wouldn't mind using MEGA/MICRO, etc. more in numbers with more than 3 or 4 zeros. Reviewed-by: David Lechner