mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	~postmarketos/upstreaming@lists.sr.ht
Cc: martin.botka@somainline.org,
	angelogioacchino.delregno@somainline.org,
	marijn.suijten@somainline.org, jamipkettunen@somainline.org,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8996-tone: Fix USB taking 6 minutes to wake up
Date: Fri, 25 Nov 2022 09:18:40 +0100	[thread overview]
Message-ID: <e4ea8291-f733-775e-e2d1-79c5f887fa5b@linaro.org> (raw)
In-Reply-To: <20221124220147.102611-1-konrad.dybcio@linaro.org>

On 24/11/2022 23:01, Konrad Dybcio wrote:
> The hardware turns out to be pretty sluggish at assuming it can only
> do USB2 with just a USB2 phy assigned to it - before it needed about
> 6 minutes to acknowledge that.
> 
> Limit it to USB-HS explicitly to make USB come up about 720x faster.
> 
> Fixes: 9da65e441d4d ("arm64: dts: qcom: Add support for SONY Xperia X Performance / XZ / XZs (msm8996, Tone platform)")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> No words.
> 
>   arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
> index 12a7b6d91dbe..0ab9687f3406 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
> @@ -991,10 +991,6 @@ touch_int_sleep: touch-int-sleep-state {
>   	};
>   };
>   
> -/*
> - * For reasons that are currently unknown (but probably related to fusb301), USB takes about
> - * 6 minutes to wake up (nothing interesting in kernel logs), but then it works as it should.
> - */
>   &usb3 {
>   	status = "okay";
>   	qcom,select-utmi-as-pipe-clk;
> @@ -1003,6 +999,7 @@ &usb3 {
>   &usb3_dwc3 {
>   	extcon = <&usb3_id>;
>   	dr_mode = "peripheral";
> +	maximum-speed = "high-speed";
>   	phys = <&hsusb_phy1>;
>   	phy-names = "usb2-phy";
>   	snps,hird-threshold = /bits/ 8 <0>;


Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

  reply	other threads:[~2022-11-25  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 22:01 Konrad Dybcio
2022-11-25  8:18 ` Neil Armstrong [this message]
2022-12-28  4:36 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4ea8291-f733-775e-e2d1-79c5f887fa5b@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jamipkettunen@somainline.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=martin.botka@somainline.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®