From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759313AbdAKA2C (ORCPT ); Tue, 10 Jan 2017 19:28:02 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:37072 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750792AbdAKA2B (ORCPT ); Tue, 10 Jan 2017 19:28:01 -0500 Subject: Re: [PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup To: Shuah Khan , balbi@kernel.org, gregkh@linuxfoundation.org, kgene@kernel.org, krzk@kernel.org References: <20170110230528.7612-1-shuahkh@osg.samsung.com> From: Javier Martinez Canillas Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: Date: Tue, 10 Jan 2017 21:27:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170110230528.7612-1-shuahkh@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Shuah, Patch looks good to me, I've just one comment. On 01/10/2017 08:05 PM, Shuah Khan wrote: > Axius clock error path returns without disabling clock and suspend clock. > Fix it to disable them before returning error. > > Signed-off-by: Shuah Khan > --- > drivers/usb/dwc3/dwc3-exynos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c > index 3e8407a..f7421c2 100644 > --- a/drivers/usb/dwc3/dwc3-exynos.c > +++ b/drivers/usb/dwc3/dwc3-exynos.c > @@ -136,7 +136,8 @@ static int dwc3_exynos_probe(struct platform_device *pdev) > exynos->axius_clk = devm_clk_get(dev, "usbdrd30_axius_clk"); > if (IS_ERR(exynos->axius_clk)) { > dev_err(dev, "no AXI UpScaler clk specified\n"); > - return -ENODEV; > + ret = -ENODEV; > + goto axius_clk_err; > } > clk_prepare_enable(exynos->axius_clk); > } else { > @@ -194,6 +195,7 @@ static int dwc3_exynos_probe(struct platform_device *pdev) > regulator_disable(exynos->vdd33); > err2: > clk_disable_unprepare(exynos->axius_clk); > +axius_clk_err: This label isn't consistent with the others, I know the errN aren't great so what about changing those to meaningful names in a preparatory patch? Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America