mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ridong Chen <ridong.chen@linux.dev>
To: Barry Song <baohua@kernel.org>
Cc: Kairui Song <ryncsn@gmail.com>,
	David Hildenbrand <david@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Yu Zhao <yuzhao@google.com>,
	Kairui Song <kasong@tencent.com>, Qi Zheng <qi.zheng@linux.dev>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
	Baoquan He <baoquan.he@linux.dev>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Ridong Chen <chenridong@xiaomi.com>
Subject: Re: [PATCH] mm/mglru: deactivate anon folios into the oldest generation
Date: Mon, 16 Nov 2026 09:48:21 +0800	[thread overview]
Message-ID: <e4f50794-0c47-4fd3-8c3d-f3888f83dd2e@linux.dev> (raw)
In-Reply-To: <CAGsJ_4xx8ivDeh1d5pvJOEgndRL8rf=CO2==T480pAm=j2X0ZQ@mail.gmail.com>



On 11/16/2026 8:28 AM, Barry Song wrote:
> On Thu, Nov 12, 2026 at 4:55 PM Ridong Chen <ridong.chen@linux.dev> wrote:
>>
>>
>>
>> On 11/12/2026 4:41 PM, Barry Song wrote:
>>> On Thu, Nov 12, 2026 at 4:38 PM Kairui Song <ryncsn@gmail.com> wrote:
>>> [...]
>>>>>    mm/folio.c | 11 ++++++++++-
>>>>>    1 file changed, 10 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/mm/folio.c b/mm/folio.c
>>>>> index ea3adb6a89d7..c412d9b398e4 100644
>>>>> --- a/mm/folio.c
>>>>> +++ b/mm/folio.c
>>>>> @@ -583,7 +583,16 @@ static void lru_deactivate(struct lruvec *lruvec, struct folio *folio)
>>>>>         lruvec_del_folio(lruvec, folio);
>>>>>         folio_clear_active(folio);
>>>>>         folio_clear_referenced(folio);
>>>>> -     lruvec_add_folio(lruvec, folio);
>>>>> +     /*
>>>>> +      * For MGLRU, lruvec_add_folio() places anon folios that are not in
>>>>> +      * the swap cache into the second youngest generation, which is an
>>>>> +      * active one. Add the folio to the oldest generation instead, like
>>>>> +      * lru_deactivate_file() does for clean folios.
>>>>> +      */
>>>>> +     if (lru_gen_enabled())
>>>>> +             lruvec_add_folio_tail(lruvec, folio);
>>>>> +     else
>>>>> +             lruvec_add_folio(lruvec, folio);
>>>>
>>>> Hi Ridong,
>>>>
>>>> One question here, why MGLRU/CLRU have to use two different ways to
>>>> add the folio back?  Will this cause over aggressive reclaim of the
>>>> folio?
>>>
>>> I guess that is because on mglru, that is lacing a way to add the folio to
>>> the head of the oldest generation for anon folios while CLRU can do
>>> that :-)
>>
>> Hi Kairui, Barry,
>>
>> Thanks for taking a look.
>>
>> Barry is right about the reason. With the classic LRU,
>> lruvec_add_folio() adds the deactivated folio to the head of the
>> inactive list. With MGLRU, lruvec_add_folio() can't put an anon folio
>> into the oldest generation at all: lru_gen_folio_seq() places a
>> swap-backed folio that is not in the swap cache into max_seq - 1,
>> regardless of its refs. The only way to reach the oldest generation is
>> the reclaiming path of lruvec_add_folio_tail(), and that path adds the
>> folio to the tail.
>>
>> And you are right that this makes it more aggressive than the classic
>> LRU. With this patch, a deactivated folio is evicted before the folios
>> already in the oldest generation, while the classic LRU puts it behind
>> the folios already on the inactive list. It also changes file folios:
>> before this patch they are added to the head of the oldest generation,
>> the same as the classic LRU, and now they go to the tail.
>>
>> So the problem in the current code is that a deactivated anon folio is
>> promoted into an active generation, and with this patch it goes one
>> step further than the classic LRU in the other direction.
> 
> I think MADV_COLD is fundamentally broken for anonymous folios
> under MGLRU!
> 
> An anonymous folio may already be in an older generation, but
> lru_deactivate() can actually promote it to the second-youngest
> generation, effectively making it hotter instead of colder!
> 
> Right. For anonymous folios, we have no way to insert them at the
> head of the oldest generation without introducing a new flag like
> PG_cold, which is unlikely to be accepted.
> 
> If we instead insert them at the tail of the oldest generation,
> I'm not sure whether that would be consistent with the historical
> semantics of MADV_COLD.
> 
> But I've been thinking about how to insert a folio at the head
> of the oldest generation. Why can't we simply move the folio
> directly from its current generation to the head of the oldest
> generation in lru_gen_deactivate_folio()?
> 
> For example, something along these lines:
> 
> lru_gen_deactivate_folio()
> {
>          int type = folio_is_file_lru(folio);
>          int zone = folio_zonenum(folio);
>          int gen = lru_gen_from_seq(lrugen->min_seq[type]);
> 
>          if (folio_lru_gen(folio) < 0)
>                  return false;
> 
>          folio_clear_active(folio);
>          folio_clear_referenced(folio);
> 
>          list_move(&folio->lru, &lrugen->folios[gen][type][zone]);
> }
> 

I think that works, and it is better than what this patch does. It
puts both anon and file folios at the head of the oldest generation,
which matches the classic LRU, and it avoids the two problems I
mentioned (too aggressive for anon, and moving file folios from the
head to the tail).

A plain list_move() is not enough though. We also need to:

- update the gen bits in folio->flags with a cmpxchg loop, as
  folio_inc_gen() does, since folio_update_gen() can change them
  locklessly from the page table walk;
- fix up lrugen->nr_pages and the LRU sizes. lru_gen_update_size()
  warns on an active -> inactive move ("demotion requires
  isolation"), so this would be done as a deletion from old_gen
  followed by an addition to new_gen.

min_seq only advances under the LRU lock, so it is stable here.
Something like:

static bool lru_gen_deactivate_folio(struct lruvec *lruvec,
					struct folio *folio)
{
	  int type = folio_is_file_lru(folio);
	  int zone = folio_zonenum(folio);
	  struct lru_gen_folio *lrugen = &lruvec->lrugen;
	  int new_gen = lru_gen_from_seq(lrugen->min_seq[type]);
	  unsigned long new_flags, old_flags = READ_ONCE(folio->flags.f);
	  int old_gen;
	
	  do {
		old_gen = ((old_flags & LRU_GEN_MASK) >> LRU_GEN_PGOFF) - 1;
		if (old_gen < 0)
			return false;
		new_flags = old_flags & ~LRU_GEN_MASK;
		new_flags |= (new_gen + 1UL) << LRU_GEN_PGOFF;
	  } while (!try_cmpxchg(&folio->flags.f, &old_flags, new_flags));
	
	  if (old_gen != new_gen) {
		lru_gen_update_size(lruvec, folio, old_gen, -1);
		lru_gen_update_size(lruvec, folio, -1, new_gen);
	  }
	  list_move(&folio->lru, &lrugen->folios[new_gen][type][zone]);
	
	  return true;
}


> Right now, lru_deactivate() seems unnecessarily complicated,
> incurring additional CPU overhead and LRU lock contention:
> 
> 1. Remove the folio from the LRU list.
> 2. Add the folio to the LRU cache.
> 3. Drain the LRU cache.
> 4. Add the folio back to the LRU list.
> 
> Why do we need all these intermediate steps instead of moving
> the folio directly in a single operation, given that we're
> already manipulating the LRU list?
> 
> Am I missing something?
> 
I don't think the batch itself is the problem. The folio stays on the
LRU while it sits in the per-cpu batch; only when the batch is
drained do we take the LRU lock once for up to a batch of folios and
do del + add under it. So the batch reduces lock contention rather
than adding to it. What the in-place move saves is the del/add pair
inside the lock.

So I plan to keep the batching and, in lru_deactivate(), call
lru_gen_deactivate_folio() instead of lruvec_del_folio() +
lruvec_add_folio() when MGLRU is enabled. I'll test it and send v2
if that sounds good to you.

-- 
Best regards
Ridong


      reply	other threads:[~2026-11-16  1:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  8:19 Ridong Chen
2026-11-12  8:38 ` Kairui Song
2026-11-12  8:41   ` Barry Song
2026-11-12  8:46     ` Kairui Song
2026-11-12  8:50       ` Barry Song
2026-11-12  8:54     ` Ridong Chen
2026-11-16  0:28       ` Barry Song
2026-11-16  1:48         ` Ridong Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4f50794-0c47-4fd3-8c3d-f3888f83dd2e@linux.dev \
    --to=ridong.chen@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baoquan.he@linux.dev \
    --cc=chenridong@xiaomi.com \
    --cc=david@kernel.org \
    --cc=kasong@tencent.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=qi.zheng@linux.dev \
    --cc=rppt@kernel.org \
    --cc=ryncsn@gmail.com \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=weixugc@google.com \
    --cc=yuanchu@google.com \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®