From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BD9B38735E for ; Tue, 13 Jan 2026 09:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768297511; cv=none; b=d5itFr0MBAnNz3Oktfwqj6VuOGJr9cPqNMgadh1l8Y7+WCNJLWKfZgPAbZ8DWp+aFfZU3rH0pKnYf9zNMdj3VWz7qFRbkOQ1i/CHIlQ9SC4UYO6EMDubGj2zOVQSLdVY+FUTa3RpI9i2fL+JfE8PBIG6xXZXj90IX4Kdacw9VbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768297511; c=relaxed/simple; bh=RnFT60kr/PfSctcSnbhdFd9ofPDILz/gj4K6sG1WZFM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gYhULoIyuarjcAuPq7pSMnOb3McyqKgJUEe3Sy2WVq1w2nsFmfQJSfrmPQGm0nqZOubSGiPsa1EZZZzkT+QA/iqqZP8FjNaQdOwcIBihMV3c2+S1AIw2MEZ5nC6ErkR1WEKRxTfJ0ku/55oxg11dSK/Az6Dq77+v3YnGgIhehSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Zj7upm3f; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N+xY98WN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zj7upm3f"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N+xY98WN" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D5aso93636970 for ; Tue, 13 Jan 2026 09:45:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RnFT60kr/PfSctcSnbhdFd9ofPDILz/gj4K6sG1WZFM=; b=Zj7upm3fDtqwXn9z OxLy5XFTcaIQnLWVhW+TEzQGB/UXiwCZN4N5+rPt6K3wxKnQO6IhulusE9++SIZ2 NbmSUxPKtn9gPO5NNV8xAA65udwzkOzo65z5z2HbSCqE4LpWSW+zz1g4FnAYSel0 VyiMLxoo3keLJX9u1zJY2euqB3+cMB5XVCyrk51itYTLM6CMIbCaPH/Tt21j1NAp D/TdSTjdGNGU71hzI5qYltliVxsDz1jfPbKFWUbpUEvaDru8rF7x3XSDgmnYI2yu eWwhJQnF4CVp0Cs0B87vE9QZ+49b2LzXyzvyWiJE78/JWS5X/SGGxjsvfRWatxgl 7fKMbQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bng2c0ry6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 09:45:07 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4f357ab5757so26906821cf.0 for ; Tue, 13 Jan 2026 01:45:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768297506; x=1768902306; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RnFT60kr/PfSctcSnbhdFd9ofPDILz/gj4K6sG1WZFM=; b=N+xY98WNUpgnp66FVpkrhETL6BzsLpBq4VhyuovEWWoS3LYJa4w4ozW6mi85HNugZv sEPQANgZ8icEfLrPjhdVd4jppk+3mgg/52zVwBn6MZ8YZ1LKTT4EkxorM7n/35tZjivY lgUIqbPgfqLWQmDE2i/bfDDac2p3GOt2qGDbjECXX20ygznLl4JKRN3kFkqcBXe2KOVA FvnJYH4EvAIHNs1nQGtKPNlB30LgqXgJLeg9pGZ9Gkh6ExOg6vTTfT15adG/yfeI9IS/ HnLdn9QUybZz8PRqpiPgH5d6pOPWg7QACi8Kltk/1ElJFMoGtQwKFaw7ZjgtWK0f5l3z JXeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768297506; x=1768902306; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RnFT60kr/PfSctcSnbhdFd9ofPDILz/gj4K6sG1WZFM=; b=BSevMCh7abRAR1ahqscmrmKb7W/uj5lQyFeMj8oHGfnEVkAnKlwbiJmEPrPiT0XAqv li+QU/Agdr/OteXa5kMgoHahk4AShrgg9NH8SPSx2vVt6fOWFdp+6TKNfk0hmRQbxshj nQj8PQRB2dupLhYnHGtZtcRULXAiW4CsGLTF8nimaAdmV/5bfMVraMXcAopVGAcO4zgG vhkfPLFjYU9rL05TNjRtG0UdIBx8n0T0KFseiV1sFd9DkVh52h7BMh2NoFoL36SiLl89 RQGnjV4NxN7e/koLBYx2af/qMO1VXoIJDKo9kA87lpd7UJzXGsLaqgSFVyhyV4bKu++8 IWIA== X-Forwarded-Encrypted: i=1; AJvYcCUKWvpQmUGsK6cIw7AD/RgVwOFxF0/BBfaNjOTYfXpM20EmphP+PuhRm/BXrnvmUZHxfwlx/G+u9Z9jpys=@vger.kernel.org X-Gm-Message-State: AOJu0YxcE6l5hMOEcO3fyd4HKYgf2/o6LMTIg3AtN9BhExbtrIshg/EF PrgDhloW+LiwmPajOZwKE8DTbf0hkx92P09rJXihYJG+0rJlcbyhMK+QxVOuRdbcxLE8+ATdV55 EUPEMCb3wyMHTSmvfvRbuWcjDMgUFBBxP+PJlfLIa5ut/qNdISRnXRQ5UZOkB+/OvYMo= X-Gm-Gg: AY/fxX5smV6duS/XZUaHXNZrth9W+pCmjDYItCXW61kLqJLd8hzJc6yC9jmFxR5HUWc piHwPTNpGQNRVaByCf3PlFseG7qVows1oeLtnJ+IhMyODf7QZK1GedjKZKPt1vaqWkmvlA820DI eLaWe94LYctNRECGDk/MULQMbLan8qNCg/3jAfNffsbqH39XHI5atscrLE+kQG48hivy4szQW7G DWsedbhEGLIjMiVJWCfWUkkaVtT41NUVFyq7SU6JR1aYsI8UxCbO69Z0mkTylcvQZPcm9tD06OL /jYAQEmwXC+FO0NMSErc2YaZUxLsjm2nRcJPk3lxke+cr2UAHd6sw5kKPmdhSqGIw1v0TQ78pOY Fp2XmRlBz4gVI0B2ooO8t96uzLtZRAky4EPY00Y3h5pURsZIDq/G+gKUdVtbe+nj8H3g= X-Received: by 2002:a05:620a:44c1:b0:8b2:df32:b900 with SMTP id af79cd13be357-8c38937ccc9mr2027629485a.4.1768297506298; Tue, 13 Jan 2026 01:45:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGMdhUIah0+kPkq8aX4h9vJ4FJxBVPtReRBnVq6edz29WF1RikziT0hiVy+JhTjeZEsv374g== X-Received: by 2002:a05:620a:44c1:b0:8b2:df32:b900 with SMTP id af79cd13be357-8c38937ccc9mr2027627885a.4.1768297505810; Tue, 13 Jan 2026 01:45:05 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a5187afsm2121235466b.58.2026.01.13.01.45.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 01:45:05 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 10:45:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix reserved gpio ranges To: barnabas.czeman@mainlining.org Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Gabriel Gonzales , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Biswapriyo Nath , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org References: <20260112-xiaomi-willow-v1-0-8e4476897638@mainlining.org> <20260112-xiaomi-willow-v1-4-8e4476897638@mainlining.org> <11ee77c1-2ea6-4c7c-b955-22f10d879ad7@oss.qualcomm.com> <9662c03b-a012-4b3c-8061-62f71a3f44a6@oss.qualcomm.com> <43741f0228b0e0d6b2991417852f890a@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <43741f0228b0e0d6b2991417852f890a@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA4MSBTYWx0ZWRfX6QBQ592rOxzg 6rG/kMWS0VPo3lWlOZYPsTSgKCULDzX6kSwfb29UiW6MCM3iPe1ihoLfWdZXqMmTVw4Rsg2VSuC JQ5aKJ/NbRAbemy3uhGtuAN2TowzsjaG7DRRTH7IUhMNPCM2B+nsHxXVvjIRHvwaMt2kB+1IiGD oSUtWmlhlVX3ukd97Z+Yy6lRFE6uNw7guv+M1hIeKCtOaclCPjSjrHxYWqqmN+1L0xTYmSv9kvu g2BYzuWxGkW8i4nT577pHyHX3/kAPckY+WRZlhMWa1G2rR6TP8mOz4yoC8KLr3fvaBJaKM57U9A ZFHjcnE+HcON1vT3L3gdLnS//p1dEfW85teXFg71Ltt+hSOzvJlYfzn4fu/pTGtttpPr/AhYQtN OWBoBLGVLSzTTqAB8xZjxgm80XEAgNHNJrT6nuOG85MKbyVksaUm8ReCAZlO2IIZ8mwxlQSVWPv gDoqwGx9hKDPrOie2Xw== X-Authority-Analysis: v=2.4 cv=C5TkCAP+ c=1 sm=1 tr=0 ts=69661423 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Uyhorv2uAAAA:20 a=OuZLqq7tAAAA:8 a=FRLbyl5siKgbeq2o-74A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=AKGiAy9iJ-JzxKVHQNES:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-GUID: yUitT35b1K_ebkJI_yVRl14_ki3RrbwL X-Proofpoint-ORIG-GUID: yUitT35b1K_ebkJI_yVRl14_ki3RrbwL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_01,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130081 On 1/13/26 10:25 AM, barnabas.czeman@mainlining.org wrote: > On 2026-01-13 10:12, Konrad Dybcio wrote: >> On 1/13/26 10:08 AM, barnabas.czeman@mainlining.org wrote: >>> On 2026-01-13 10:01, Konrad Dybcio wrote: >>>> On 1/12/26 9:13 PM, Barnabás Czémán wrote: >>>>> The device was crashing on boot because the reserved gpio ranges >>>>> was wrongly defined. Correct the ranges for avoid pinctrl crashing. >>>>> >>>>> Fixes: 9b1a6c925c88 ("arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo") >>>>> Signed-off-by: Barnabás Czémán >>>>> --- >>>> >>>> That's odd.. were you able to confirm that these values are alright for >>>> both the Note 8 and the 8T? >>> Yes, it was tested on both devices. The original devicetree was never boot. >> >> Fun.. >> >>>> >>>>>  arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 2 +- >>>>>  1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts >>>>> index 666daf4a9fdd..163ecdc7fd6c 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts >>>>> @@ -296,7 +296,7 @@ &sdhc_2 { >>>>>  }; >>>>> >>>>>  &tlmm { >>>>> -    gpio-reserved-ranges = <22 2>, <28 6>; >>>>> +    gpio-reserved-ranges = <0 4>, <30 4>; >>>> >>>> Any chance you know/could deduce what they're connected to and describe >>>> it, like in x1-crd.dtsi? >>> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/willow-p-oss/drivers/pinctrl/qcom/pinctrl-msm.c#L605 >>> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/ginkgo-p-oss/drivers/pinctrl/qcom/pinctrl-msm.c#L610 >> >> GPIO0-3 sounds like QUP0 and GPIO30-33 sounds like QUP6 >> >> My guess would be one goes to a fingerprint scanner and one goes to >> NFC eSE (or N/C for the device without NFC) >> >> Could you scan the downstream devicetree for signals of that? > NFC is using gpio83, gpio84, gpio85 and gpio95. I was referring to the NFC eSE (embedded Secure Element) which usually has a separate connection to the SoC Konrad