From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbdJ0FVX (ORCPT ); Fri, 27 Oct 2017 01:21:23 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:48216 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbdJ0FVR (ORCPT ); Fri, 27 Oct 2017 01:21:17 -0400 X-Google-Smtp-Source: ABhQp+RYu7KLpmtQbr1o2LcFqn2jHG9HkL7rTtOKPbbK4CA0v3ENW/TYrWuvJL06c9z6D9Pb1uLNJQ== Subject: Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing To: John Garry , Tomasz Nowicki , Jeremy Linton , linux-acpi@vger.kernel.org Cc: mark.rutland@arm.com, Jonathan.Zhang@cavium.com, Jayachandran.Nair@cavium.com, lorenzo.pieralisi@arm.com, austinwc@codeaurora.org, linux-pm@vger.kernel.org, jhugo@codeaurora.org, gregkh@linuxfoundation.org, sudeep.holla@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, will.deacon@arm.com, wangxiongfeng2@huawei.com, viresh.kumar@linaro.org, hanjun.guo@linaro.org, catalin.marinas@arm.com, ahs3@redhat.com, linux-arm-kernel@lists.infradead.org References: <20171012194856.13844-1-jeremy.linton@arm.com> <20171012194856.13844-2-jeremy.linton@arm.com> <38c63cfd-4c13-9461-0d4a-74b0943be0fd@semihalf.com> <2ce92b90-fc2c-3fff-a3e3-b9517057ab2c@arm.com> <4ee4af4d-d987-33f9-4d55-67bfede3ebfa@caviumnetworks.com> <47d8ef93-a3ce-6d40-f8db-2bc7d527ac6f@arm.com> <2605aa54-95f7-4619-e632-0a95a68e5fb0@caviumnetworks.com> <49421fa9-c3ac-c81b-ed2d-a113f676edd8@huawei.com> From: Tomasz Nowicki Message-ID: Date: Fri, 27 Oct 2017 07:21:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <49421fa9-c3ac-c81b-ed2d-a113f676edd8@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On 19.10.2017 12:25, John Garry wrote: > On 19/10/2017 06:18, Tomasz Nowicki wrote: >>> >>> Summary: >>> >>> I'm not at all happy with this specification's attempt to leave out >>> pieces of information which make parsing things more deterministic. In >>> this case I'm happy to demote the message level, but not remove it >>> entirely but I do think the obvious case you list shouldn't be the >>> default one. >>> >>> Lastly: >>> >>> I'm assuming the final result is that the table is actually being >>> parsed correctly despite the ugly message? >> >> Indeed, the ThunderX2 PPTT table is being parsed so that topology shown >> in lstopo and lscpu is correct. > > Hi Tomasz, > > Can you share the lscpu output? Does it have cluster info? I did not > think that lscpu has a concept of clustering. > > I would say that the per-cpu cluster index sysfs entry needs be added to > drivers/base/arch_topology.c (and other appropiate code under > GENERIC_ARCH_TOPOLOGY) to support this. Here is what I get: tn@val2-11 [~]$ lscpu -ap # The following is the parsable format, which can be fed to other # programs. Each different item in every column has an unique ID # starting from zero. # CPU,Core,Socket,Node,,L1d,L1i,L2,L3 [...] 1,0,0,0,,0,0,0,0 [...] so yes, no cluster info. Thanks, Tomasz