From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6860B36C5A2 for ; Mon, 9 Feb 2026 11:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770635541; cv=none; b=W/DcUafhpVLkx27h4TCOtfKhIkHyX2rw2Ib0rmZJTZCflEySusV/EY/fcnpqZLXrx1LOmsS22tginA9Fu5L+9BONdyGphAR75v5Q+dJdQzEvmE1Bvtv/+igHUHzlU9K49Urwp3XpSmUgeBvkSTmSekAky1JKJHmtOOecCPZl02g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770635541; c=relaxed/simple; bh=prs/+pekCsrcWWpQ9nWoZrcm7PMTmPz42teQbvfpKMs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GgHbqJlClnxGX36cGZaLfm7ASuy57S1pXGlBMsxEpjxnaUbFtoeqzjSek0usJxrLTw5TrGCb2lvBluDwyJ/4ctoTReVJiSB9+7SJJmjjxgI/JuIAC7nwi4De9dhkoglvZKc2RebtjRJxOxvdnb92HxPsDqRTJ6D139i+yjd7n/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ePDf+wms; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ePDf+wms" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770635539; bh=prs/+pekCsrcWWpQ9nWoZrcm7PMTmPz42teQbvfpKMs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ePDf+wmsnkN4HZOJDSqmh1eJLQ8Lm2Iu64aayHftqUM9CoxSL+0X0aHGVsI0HQ1Lc Fyz2Xes1Nq5C4lWyRTLw/I4I5uZgzj7l6Tfvz4iZfsQxnUY9pWQjRWgr3Iu8q3tJkd hNrrqcf8a8+rLgl0TEIzHGV5iMb5brZVcKdW6XmqVVNrBYfwh9zeoiyVX2m8rJQn0h w06QJA25Qd+bkmhKEPKZ4mtAXoJqkFNUVawxKzGHJUjz9hfhaznRR88zKsYsFdnvBL XdsCAw8WiESwCozCG1oTozQgNkKlyIj1E12cwnXH1jbm/onR4YJN9+3xGW9OHkFMTe 5INIzqP7grJ2w== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4B7BC17E0699; Mon, 9 Feb 2026 12:12:19 +0100 (CET) Message-ID: Date: Mon, 9 Feb 2026 12:12:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: mediatek: mtk-mmsys: Restore MT8167 routing masks lost during merge To: Luca Leonardo Scorcia , linux-mediatek@lists.infradead.org Cc: Matthias Brugger , Fabien Parent , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260206122623.670023-1-l.scorcia@gmail.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20260206122623.670023-1-l.scorcia@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 06/02/26 13:26, Luca Leonardo Scorcia ha scritto: > The original patch at > https://lore.kernel.org/all/20201027160631.608503-2-fparent@baylibre.com/ > included the values for the route masks, but they got lost during merge. > > Fixes: 060f7875bd23 ("soc: mediatek: mmsys: Add support for MT8167 SoC") > > Signed-off-by: Luca Leonardo Scorcia Hello Luca, thanks for this patch! I agree that the masks should be corrected, and I think the code itself is all good stuff. Great job! However, the commit description needs to be fixed; please, don't add links, as those are meaningful now, but may not work in some years from now. Something like: "The original patch that got sent to the mailing lists included the values for the route masks, but they got lost during merge: add back the full register masks where missing" ...the Fixes tag is good. Cheers, Angelo > --- > drivers/soc/mediatek/mt8167-mmsys.h | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/mediatek/mt8167-mmsys.h b/drivers/soc/mediatek/mt8167-mmsys.h > index c468926561b4..eef14083c47b 100644 > --- a/drivers/soc/mediatek/mt8167-mmsys.h > +++ b/drivers/soc/mediatek/mt8167-mmsys.h > @@ -10,24 +10,29 @@ > #define MT8167_DISP_REG_CONFIG_DISP_RDMA0_SOUT_SEL_IN 0x06c > > #define MT8167_DITHER_MOUT_EN_RDMA0 0x1 > +#define MT8167_DITHER_MOUT_EN_MASK 0x7 > + > #define MT8167_RDMA0_SOUT_DSI0 0x2 > +#define MT8167_RDMA0_SOUT_MASK 0x3 > + > #define MT8167_DSI0_SEL_IN_RDMA0 0x1 > +#define MT8167_DSI0_SEL_IN_MASK 0x3 > > static const struct mtk_mmsys_routes mt8167_mmsys_routing_table[] = { > MMSYS_ROUTE(OVL0, COLOR0, > MT8167_DISP_REG_CONFIG_DISP_OVL0_MOUT_EN, OVL0_MOUT_EN_COLOR0, > OVL0_MOUT_EN_COLOR0), > MMSYS_ROUTE(DITHER0, RDMA0, > - MT8167_DISP_REG_CONFIG_DISP_DITHER_MOUT_EN, MT8167_DITHER_MOUT_EN_RDMA0, > + MT8167_DISP_REG_CONFIG_DISP_DITHER_MOUT_EN, MT8167_DITHER_MOUT_EN_MASK, > MT8167_DITHER_MOUT_EN_RDMA0), > MMSYS_ROUTE(OVL0, COLOR0, > MT8167_DISP_REG_CONFIG_DISP_COLOR0_SEL_IN, COLOR0_SEL_IN_OVL0, > COLOR0_SEL_IN_OVL0), > MMSYS_ROUTE(RDMA0, DSI0, > - MT8167_DISP_REG_CONFIG_DISP_DSI0_SEL_IN, MT8167_DSI0_SEL_IN_RDMA0, > + MT8167_DISP_REG_CONFIG_DISP_DSI0_SEL_IN, MT8167_DSI0_SEL_IN_MASK, > MT8167_DSI0_SEL_IN_RDMA0), > MMSYS_ROUTE(RDMA0, DSI0, > - MT8167_DISP_REG_CONFIG_DISP_RDMA0_SOUT_SEL_IN, MT8167_RDMA0_SOUT_DSI0, > + MT8167_DISP_REG_CONFIG_DISP_RDMA0_SOUT_SEL_IN, MT8167_RDMA0_SOUT_MASK, > MT8167_RDMA0_SOUT_DSI0), > }; >