From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C9EC32750 for ; Fri, 2 Aug 2019 08:21:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DEDB2073D for ; Fri, 2 Aug 2019 08:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404077AbfHBIVf (ORCPT ); Fri, 2 Aug 2019 04:21:35 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:33107 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727008AbfHBIVf (ORCPT ); Fri, 2 Aug 2019 04:21:35 -0400 Received: from LHREML713-CAH.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 367D3321756B743FA386; Fri, 2 Aug 2019 09:21:33 +0100 (IST) Received: from [10.220.133.57] (10.220.133.57) by smtpsuk.huawei.com (10.201.108.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Aug 2019 09:21:25 +0100 Subject: Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated To: Jarkko Sakkinen CC: , , , , , , , , , , References: <20190705163735.11539-1-roberto.sassu@huawei.com> <20190711194811.rfsohbfc3a7carpa@linux.intel.com> <20190801163215.mfkagoafkxscesne@linux.intel.com> From: Roberto Sassu Message-ID: Date: Fri, 2 Aug 2019 10:21:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190801163215.mfkagoafkxscesne@linux.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.220.133.57] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/2019 6:32 PM, Jarkko Sakkinen wrote: > On Mon, Jul 15, 2019 at 06:44:28PM +0200, Roberto Sassu wrote: >> According to the bug report at https://bugs.archlinux.org/task/62678, >> the trusted module is a dependency of the ecryptfs module. We should >> load the trusted module even if the TPM is inactive or deactivated. >> >> Given that commit 782779b60faa ("tpm: Actually fail on TPM errors during >> "get random"") changes the return code of tpm_get_random(), the patch >> should be modified to ignore the -EIO error. I will send a new version. > > Do you have information where this dependency comes from? ecryptfs retrieves the encryption key from encrypted keys (see ecryptfs_get_encrypted_key()). Roberto -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Li Peng, Li Jian, Shi Yanli