From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1CCD37F8C8 for ; Wed, 4 Mar 2026 06:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772605393; cv=none; b=QTdgdnxp2rl2nERytxyLaER3WQACiAMQ/B9bBz1GdstLtc/3l5SrzuSp77zH5YVl6f8KHD/aUvNqo8cxP9s0KnhssuN3i49piGkzoi230pP1M/Lz8omJEVn+R8h0hpcvpd1mMMO1Nsi6mGDz+F0JuQIGB50hdcx/po18wiXfP+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772605393; c=relaxed/simple; bh=Hp2QrPOWKqCv7nAk4ci0TLOs1jBx/SSiuHZVLojI+Co=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MxzmvI+Ys5PmuZ8gz29d+8l9QvM5k8fugrRS2mIRR2dcirpstUU5ze75yEWrNUdeLgEPlYTuqmsEQjDG1HQVc8Kw7szrAiyLBwpHu0FRmrV6NdVN+fTlE4fRHur2S7wPMhHmAMkDIOM2XbfpA1WyL+7KNuatJYLKIvWelah5TO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iA7roWzM; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iA7roWzM" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35995cb33a8so1491825a91.0 for ; Tue, 03 Mar 2026 22:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772605392; x=1773210192; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=f9B/eoXPHzf4Ne438osq3GavHWtC0eEvRnIZrrT/wzs=; b=iA7roWzMkYyAkMGrHXcjq65NhpNDbVWNh7D+u0c9H68N5fG0C08OPApcIjBXJ6+Wwx hjQ+x3xmepHpgFPTm4mqk0UB+SbujcJjvDwjYXIYhrYZw5FbRjFufPHUvePGg+T8JKHj 9oNrV5Gfe+pccKeF2fULUKTWEb7Rw5YWJPzQy6uWPzBx5rp8+HzqH84pR8Y4kRYp78Uf RQ24hxhxK9QW990ZG4oalCakUQmBLTJtTWXjTT2IhtBvMulYZ2Pmw+NM97S1pGiVTYb+ iRC7NI24sYTIHrW4hSeQW27dhNnx5gsftp4r/WaO4c18Q1d96KrT24DebTBMT4IaV0Bq bJDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772605392; x=1773210192; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f9B/eoXPHzf4Ne438osq3GavHWtC0eEvRnIZrrT/wzs=; b=HzrNsZo3Qo2bJ4UoCw//VKn0sw6aNFHjpVM2q07tanDviovDyfG/b1nH0fTx0xcHDX UrYDR+uhtI3oDuuFOtkfBWNVRJs1zA4v4KCiv6pbbohlXqv29PxcGWBKhMg8JfqXktTF ziLMM5qlV5uhgo3V+4orrMBwjq/QxMyrZlbpEy4QY0wm420Af8wyFKP185myVnnC+XeU mUJGh6ndFFnqGpda3BTTHK4wXnRHI72AxlRplfM4khca/5DojgdUjvbXsnGldYxfqr89 yaOSBOyOeLIMp5Y2/EJ6dwCULQ7NGaK+jRaX8MOlCCqzK+WRtBUCB88+5flkMI5iq2V4 nnFA== X-Forwarded-Encrypted: i=1; AJvYcCXOWhzby6sJhhozMx3vQtwcGB8s/NdCFNVynqYKD+e9t+tfXKORwbGVNzYFt7IJJRIYZdA2FQvufrkPi2Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxNJgT3Hbm40mtyX8WFXvms4CC7XmtkrqV6d3M3rGAUE4sc/lDv 9Apw+3cyjx5K25STIb9flelfDYdPWEDVuuxHL3L3Xp9H2hJUDKDv1YCWbmupE1UE X-Gm-Gg: ATEYQzzmFWuRrzbgPCq1v/PTCgusen8TFyNQmMUPY2kMviqCAwwR5JmQ+FIt9ytl6r1 m//d1wGBC9VAydeR7Nh6hDUFNHqFxKyucumQkHookC69hqSGaxYbFsEWROK/tgVXyXaR9MmSzhr 7kiVsLNfyEQOTcJy7fcZ8pfz2iIUj7G2kDc0heNxsLKDuKlIYQ2ADGW8uLSkgYiPH/WuEhoTYmH GaHZH3w9yQLMsoQVuHB3ggbDWMWiqKvrWB0UxRV9yAnRC6iGqJjfaV5oW2Cs9qlPe+6VqkllLn1 slpMHg7UhSQcgNQVuGsMOdiIF8hCU4tVJjy9KfePdW2XaqprX50kQGgy6u+DFEala7P44hgIyWn AUzaYCimzUdtX/BCj3+Ubu1vXQTRcTegp74Xvl9rgza0cs30ZP8N5+hUJKPCZFlxiAmaeAQam4z eePOAJDUYrCmnYNK5r2/y+EsmswODu2SzelOy7aGHNQ2CWItCg5Khv X-Received: by 2002:a17:90b:2f87:b0:352:d933:5574 with SMTP id 98e67ed59e1d1-3599ceb537dmr4072869a91.9.1772605392279; Tue, 03 Mar 2026 22:23:12 -0800 (PST) Received: from [192.168.0.226] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae54e394aasm96198375ad.77.2026.03.03.22.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 22:23:11 -0800 (PST) Message-ID: Subject: Re: [PATCH bpf-next v5 4/5] bpf, x86: Emit ENDBR for indirect jump targets From: Eduard Zingerman To: Xu Kuohai , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Yonghong Song , Puranjay Mohan , Anton Protopopov Date: Tue, 03 Mar 2026 22:23:09 -0800 In-Reply-To: <20260302102726.1126019-5-xukuohai@huaweicloud.com> References: <20260302102726.1126019-1-xukuohai@huaweicloud.com> <20260302102726.1126019-5-xukuohai@huaweicloud.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-03-02 at 18:27 +0800, Xu Kuohai wrote: [...] > @@ -2449,7 +2452,7 @@ st: if (is_imm8(insn->off)) > =20 > /* call */ > case BPF_JMP | BPF_CALL: { > - u8 *ip =3D image + addrs[i - 1]; > + u8 *ip =3D image + addrs[i - 1] + (prog - temp); ^^^^^^^^^^^^^ Could you please comment a bit why this addend is needed? > =20 > func =3D (u8 *) __bpf_call_base + imm32; > if (src_reg =3D=3D BPF_PSEUDO_CALL && tail_call_reachable) { [...]