From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D1934DB54A for ; Wed, 29 Jul 2026 18:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785349715; cv=none; b=tfDHXidcBycqAoJH6m8wno7/BuQPtiaO8vOOpXmtF2zzbeA11Q1WGDO8szf+Fs8pPtOc42b3+9EVW1F2Z8siHI6t0V/IdUw7oZHhDApbecmXSH3U0N3jouIV+oL4gccEntf61MTKLKTJJoIagCo/mkTQUolbaesURhJY7Ych/ec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785349715; c=relaxed/simple; bh=eupjsbxKINcRQuC29F595+o6K1wLkOTXL9fh5anBXX4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qx+ONx5UFIb/Sd8/Ufj8L70py8D7uG72m3Z8sMG7Ia4ZgxWODUSvj1xkHCe4f6/KFYkt9mjcw+hNR7jwpOVT2LN8otbzuybI2XSFOoT4aT893wcbsmJ/T90bS1U59t0R2ARxmarHyY3nOmi7w7HVlkKaaO7kaxtPJhSkj+KDpRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E+UjYE6t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fWKXPGZG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E+UjYE6t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fWKXPGZG" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TIR8BN2881863 for ; Wed, 29 Jul 2026 18:28:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AnU1zi8FAw41jHzsJAGhK9y6ec/GVYsZBSJFjyj491s=; b=E+UjYE6tKRDqpkD/ RQfg+U1dEx8FBsE/fUbVM5whZE8WdrPhqNj51A0T41hzrXa15utlAa3z6u9d6m2s 9vj07rIf9iwNfLSot+WxL25/VpwHb3NGI+PVxCJ3usRsb5wBHHkda/xXKzFtVPT7 BxZjGI9RBwjBDTcftoIuawmOaJmmMHgIBkX/aor0Z5QiexIvgEFkvz8p/Mu3+Er2 +36s+1zHy+z0qJ8yM5zul8WhWGhpbU2l2JNWOKSLBBoLT0t5DiJxpNj9iGBiz8PL jvNDpmEYkb8lniNQjA8z7c83+gl9em0bE1ZTKSWwbJ6ysyZhVbit7CQ20leu40x0 EHf2tg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqh3ghyrn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 18:28:28 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5174a236220so12447161cf.3 for ; Wed, 29 Jul 2026 11:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785349708; x=1785954508; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AnU1zi8FAw41jHzsJAGhK9y6ec/GVYsZBSJFjyj491s=; b=fWKXPGZGVmhha9rppOsEVciPKdMGq7UO7+I4hhI51mjLJYZ6RZtojVJDlwxOyWx3xP SMCt6MV+tdE4gQk3dfbGNyX2yV2DNQBtYyf3RUltkYR9stdbOyIBiVi6dnKRRzNxvwkt VtYhlwBoQQrJPXPtww+qM3HgWrSyokUq+gV3oYts6t2jgTyrjmyizzglaiQ2mHiGS/vc kCDilpH345CLCQhJWGl7U13B931KdWsB7MkHC+QdZ+mOnOuVPDxueU3JbOf0HQj8hlJ1 3I8kXp1k1r3b+/mWW4skO0HrOadIjzynkiKsuu1kdUYXpdcykKDw7iYa3+COGyogY43X vFIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785349708; x=1785954508; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AnU1zi8FAw41jHzsJAGhK9y6ec/GVYsZBSJFjyj491s=; b=p8Cr61l004c/VXV5P9mok8R7UQ2u0cQIru4FvWev312lB/1AtyWYHi4b2Hfj0rB6Gk OFeUAPbbZsuDTntiBLPjPBk+4ilWLFu5jZzmoagya3h9HbU2gL4jfZYOKmG3FzDAnFhb lc9Erg+/3G1hXW4I7oQS3srEZQCatMPGM7j4l77vlALIsn7e7C82xZa0+8+trhmhmGQP MmAIuL+Ty9aflzby1cDnYOE2obl7ubMTiI6c/3f1m0Rt2NMOgRT+bEAbMV4sziahXtTR Cey2eSQKzPm0TPtdxLEIdHbGkWpVgHppeahdyOL30yK5PMfNNDZNX1nIbGPfEF9WFfn2 Dl5g== X-Gm-Message-State: AOJu0YyXNwwxd+zcRTzcadch+rFui8BaDe/QQeeD0hXIDKXHCfUrgB3T BlMOdlQR3zYd2SBRJ15sF4IxZNR3nTJ+0j0HpOMB681oW0gd8faXFIUKz4HOMNty9NCe0Hxa2za X/yKAUOiv2Tg3kHqjXlbXlm9kYamxSAVY81HvQv2jDqaLqs8fE9zvAygc4Ymmqi+aaRU= X-Gm-Gg: AR+sD10bYAkOxYRP9TwLnSHv+u1xeyDlraGTgcsZ6ajKLIp6SrJTAQs1ZAMP7bJcQz8 +C1C3ZK6zR8l5CsgA23nyiSGlD6I4EMatwTBDiVJm7K16BxHSFS3DMKjiRJMFud/lQmifl8sUoZ RTwjYUQiSBmVKwcym07bZcfbG0XLy3hA6hmAnWGSFhnvHddCIK4WEuLbnb2zkf7ERbSGHGe2xMS 5NPvlR9QsRBjztibLc283VdHqbB6nmZqKjVsnsuoiz3g/v7+/LL63SbAM7vcRLtvOtYLYEeHIem nogsoA3RgQ8ZlxE4/TaiiBjUmS2CH0G/hrAHmPgRo4nQYaYBNbJ/Gh5OB9sVot7iG6r/Nqbd3ao dg7CzoOoIMhrmnGSV/WEz/Cise18mjBh6e+wmnPNZaAb/EhDCgi2A06HyoS150wRrD9Y19Zho X-Received: by 2002:a05:622a:2b05:b0:516:df62:bdd2 with SMTP id d75a77b69052e-529d70e2ed5mr75381791cf.55.1785349707699; Wed, 29 Jul 2026 11:28:27 -0700 (PDT) X-Received: by 2002:a05:622a:2b05:b0:516:df62:bdd2 with SMTP id d75a77b69052e-529d70e2ed5mr75381341cf.55.1785349707118; Wed, 29 Jul 2026 11:28:27 -0700 (PDT) Received: from [192.168.1.31] ([85.196.172.179]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49764d777afsm92277955e9.4.2026.07.29.11.28.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 11:28:26 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 21:28:23 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/5] media: qcom: camss: Add V4L2 meta format for CAMSS ISP parameters To: Loic Poulain , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Kees Cook , "Gustavo A. R. Silva" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org, devicetree@vger.kernel.org References: <20260724-camss-isp-ope-v5-0-e70ad4fa39ce@oss.qualcomm.com> <20260724-camss-isp-ope-v5-1-e70ad4fa39ce@oss.qualcomm.com> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: <20260724-camss-isp-ope-v5-1-e70ad4fa39ce@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDE0MiBTYWx0ZWRfX3ezRc9OI3aO6 4uk86ZA+Q/Lzl1q0Z2t+zKrOvrMHp36+2GyzSZU6s5SupVqBMXJPY92CK7nIUDcN3hC/XD+1e4n +NTFzrsY51MMjySPnyDYxPPMMZAfZkE223qFjjCPsECyFqH49xTaP0x/reYpfGf+sbt/GL8fzFZ cP5pHxBAaAoOuUjT7rLUCfLphiBLPYSna7wk4KjyNWdNWvP/H8wRztMnE+wnrxo1Gmd1FSFpWXb no80eAMPUf9F+7s4WSbR3tjw6zn/MG84XZeRhPazNr49gOwrdKcxZKM43QP8CVgJm0bK4NoOdzQ jdCQhB2ZyrI2Qf5aKG5ZClHgRDIfcyx849s0fB+CIj8PqDfI1WJ3WCZokEg6jnSbN2JRk50Bx5+ 55JUnfw2GULrAKTUrJ+EhDpLt0joxUW6MFYkzVNZrvuAjwKuLNgmjpmAwcooqyxm5lb7s46crUv aFYy5/4NHm2Pi8OTjhQ== X-Proofpoint-ORIG-GUID: uOYokkz9vsjClUPSh2dTf0-KJdueD4Jr X-Authority-Analysis: v=2.4 cv=EOw2FVZC c=1 sm=1 tr=0 ts=6a6a464c cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=Q/e3f29T3Hw2hnAEzBPF7w==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=cfCy20KhcoV1EizUSHcA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: uOYokkz9vsjClUPSh2dTf0-KJdueD4Jr X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDE0MiBTYWx0ZWRfX5m4QFSYXm0VW 5RHnR6yGjm8bKnbybsxvGfpZdu3cRQFUNVIp8wWs7RlTNXrS/W1G4oWxxcwpWu9nQe0Fjr3XMOz IJqO7YT2xtsStdfbLmuZXJiP+qI3IqY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_07,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 impostorscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290142 Hi Loic, On 7/24/2026 3:42 PM, Loic Poulain wrote: > Add a V4L2 meta format code (V4L2_META_FMT_QCOM_ISP_PARAMS) for the > Qualcomm CAMSS ISP parameter buffer. This format is used by the params > video node exposed by CAMSS offline ISP drivers (e.g. OPE) to carry > ISP tuning data such as white balance, color correction and chroma > enhancement settings. > > Signed-off-by: Loic Poulain > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index 98512ea4cc5b9d725e1851af2ed38df85bb4fa8c..7b6e9a9a514f037190d55d59409dd6cc97522943 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1471,6 +1471,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > case V4L2_META_FMT_C3ISP_STATS: descr = "Amlogic C3 ISP Statistics"; break; > case V4L2_META_FMT_MALI_C55_PARAMS: descr = "ARM Mali-C55 ISP Parameters"; break; > case V4L2_META_FMT_MALI_C55_STATS: descr = "ARM Mali-C55 ISP 3A Statistics"; break; > + case V4L2_META_FMT_QCOM_ISP_PARAMS: descr = "Qualcomm CAMSS ISP Parameters"; break; > case V4L2_PIX_FMT_NV12_8L128: descr = "NV12 (8x128 Linear)"; break; > case V4L2_PIX_FMT_NV12M_8L128: descr = "NV12M (8x128 Linear)"; break; > case V4L2_PIX_FMT_NV12_10BE_8L128: descr = "10-bit NV12 (8x128 Linear, BE)"; break; > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index add08188f06890182a5c399a223c1ab0a546cae1..011026194a20cde22a374e6fb2570cbc6bced230 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -888,6 +888,9 @@ struct v4l2_pix_format { > #define V4L2_META_FMT_MALI_C55_PARAMS v4l2_fourcc('C', '5', '5', 'P') /* ARM Mali-C55 Parameters */ > #define V4L2_META_FMT_MALI_C55_STATS v4l2_fourcc('C', '5', '5', 'S') /* ARM Mali-C55 3A Statistics */ > > +/* Vendor specific - used for Qualcomm CAMSS offline ISP */ It seems that this is generic format for ISP parameters, can we update the comment and remove offline. The proposal: /* Vendor specific - used for Qualcomm CAMSS ISP */ ~Gjorgji