From: Hans Verkuil <hverkuil@xs4all.nl>
To: cgel.zte@gmail.com, djrscally@gmail.com
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Changcheng Deng <deng.changcheng@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] media: i2c: remove unneeded variable
Date: Wed, 12 Jan 2022 10:19:08 +0100 [thread overview]
Message-ID: <e5165aa9-4622-72dc-22dd-1077648d7cbf@xs4all.nl> (raw)
In-Reply-To: <20220112091718.668278-1-deng.changcheng@zte.com.cn>
On 12/01/2022 10:17, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Remove unneeded variable used to store return value.
Please add the driver name in the subject prefix! Why is that so hard to
remember?
Regards,
Hans
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> ---
> drivers/media/i2c/ov5693.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
> index 2784fcf67f3b..a55910f6283a 100644
> --- a/drivers/media/i2c/ov5693.c
> +++ b/drivers/media/i2c/ov5693.c
> @@ -950,7 +950,6 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
> unsigned int width, height;
> unsigned int hblank;
> int exposure_max;
> - int ret = 0;
>
> crop = __ov5693_get_pad_crop(ov5693, state, format->pad, format->which);
>
> @@ -982,7 +981,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
> format->format = *fmt;
>
> if (format->which == V4L2_SUBDEV_FORMAT_TRY)
> - return ret;
> + return 0;
>
> mutex_lock(&ov5693->lock);
>
> @@ -1012,7 +1011,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
> exposure_max));
>
> mutex_unlock(&ov5693->lock);
> - return ret;
> + return 0;
> }
>
> static int ov5693_get_selection(struct v4l2_subdev *sd,
next prev parent reply other threads:[~2022-01-12 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 9:17 cgel.zte
2022-01-12 9:19 ` Hans Verkuil [this message]
2022-01-14 0:03 ` Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5165aa9-4622-72dc-22dd-1077648d7cbf@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=cgel.zte@gmail.com \
--cc=deng.changcheng@zte.com.cn \
--cc=djrscally@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®