From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0AD1331A61 for ; Tue, 27 Jan 2026 09:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769504470; cv=none; b=qu3ll1VLo/byeIT9Iqbigfhct6s8SnxO0lDx39qWNWOnllv5H2On/ze5bj+UWwN2m7JRx33Kwdv5VhjbkVDgCB3w/55Xx+QzbkQnw2GUnvaw/TaTHRilATV+YZmVrNCBgV7a+dLBqISlCm19wQKDFrl3Bk/XVCj9fKfokxIIFWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769504470; c=relaxed/simple; bh=noo9XsAcC7n3F4JCncujc4ESels/5xcyYpBpkJ9bFy0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mB3UTs6hyYMHCFdeK/aedz1q3K7lOTd421IvHT45W3a4T8R7DsveLreKG3WOSsOeCNfBn73mROZQg7ecWnEMmDpKuVLrMvyoG3Cm61PUS6pXcYJ/a4Y3aTIFgYj9wAyp6wjvwlMucgVJAcRBEUjWKgP+1dhBE+jvIw7AIo/rT54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=X+gIjFdN; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="X+gIjFdN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1769504466; bh=noo9XsAcC7n3F4JCncujc4ESels/5xcyYpBpkJ9bFy0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=X+gIjFdNgCgMDfrS3icP5NKrOS9hVcQAijOwjnlOVaFJbTMXEuWg76e95TRg4cr3n Qo1v90TEZ4mAtIdolCQ93aNR8Tiw1xJG2lXMwY2G4CvJe9GSxEcA53mJK0B61VHczz UimmQLOiDqrBYcdh43olLdK9W1YCW1xX2okD+gj0I5EBqUnQiFE884Jqmh3g3I5Tsg oQ/cH5uq7Q0TAeJf96DrFwzxkOT56ban2l0SblMUVbSPcqxdr3fmKi6xADdMsr0IFH yEExYV37cf8rW2C1z3xjRz6r+MgSlwbv5qjAf7EMzfHz2ETwhW2I6mrge9m+IrpxYI nz4UnXHGvmcqQ== Received: from [192.168.1.90] (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 198F317E1276; Tue, 27 Jan 2026 10:01:06 +0100 (CET) Message-ID: Date: Tue, 27 Jan 2026 11:01:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] drm: Add CRTC background color property To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Matt Roper References: <20251219-rk3588-bgcolor-v4-0-2ff1127ea757@collabora.com> <20251219-rk3588-bgcolor-v4-2-2ff1127ea757@collabora.com> <1425ed35a21bcd9633524d4fc747b71a17068363.camel@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <1425ed35a21bcd9633524d4fc747b71a17068363.camel@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/26/26 8:23 PM, Nícolas F. R. A. Prado wrote: > On Fri, 2025-12-19 at 23:46 +0200, Cristian Ciocaltea wrote: >> Some display controllers can be hardware programmed to show non-black >> colors for pixels that are either not covered by any plane or are >> exposed through transparent regions of higher planes. This feature >> can >> help reduce memory bandwidth usage, e.g. in compositors managing a UI >> with a solid background color while using smaller planes to render >> the >> remaining content. >> >> To support this capability, introduce the BACKGROUND_COLOR standard >> DRM >> mode property, which can be attached to a CRTC through the >> drm_crtc_attach_background_color_property() helper function. >> >> Additionally, define a 64-bit ARGB format value to be built with the >> help of a couple of dedicated DRM_ARGB64_PREP*() helpers. Individual >> color components can be extracted with desired precision using the >> corresponding DRM_ARGB64_GET*() macros. >> >> Co-developed-by: Matt Roper >> Signed-off-by: Matt Roper >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/gpu/drm/drm_atomic_state_helper.c | 1 + >> drivers/gpu/drm/drm_atomic_uapi.c | 4 ++ >> drivers/gpu/drm/drm_blend.c | 39 ++++++++++++++++-- >> drivers/gpu/drm/drm_mode_config.c | 6 +++ >> include/drm/drm_blend.h | 4 +- >> include/drm/drm_crtc.h | 12 ++++++ >> include/drm/drm_mode_config.h | 5 +++ >> include/uapi/drm/drm_mode.h | 67 >> +++++++++++++++++++++++++++++++ >> 8 files changed, 133 insertions(+), 5 deletions(-) > > You should also add a dump for this property in > drm_atomic_crtc_print_state(). This and all your other comments have been addressed in v5 [1]. $ grep background_color -B13 /sys/kernel/debug/dri/display-subsystem/state crtc[82]: video_port0 enable=1 active=1 self_refresh_active=0 planes_changed=1 mode_changed=0 active_changed=0 connectors_changed=0 color_mgmt_changed=0 plane_mask=1 connector_mask=1 encoder_mask=1 mode: "3840x2160": 60 594000 3840 4016 4104 4400 2160 2168 2178 2250 0x48 0x9 background_color=ffff000000000000 Thanks, Cristian [1] https://lore.kernel.org/all/20260127-rk3588-bgcolor-v5-0-b25aa8613211@collabora.com/