From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F324C4167D for ; Thu, 2 Nov 2023 09:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345768AbjKBJf2 (ORCPT ); Thu, 2 Nov 2023 05:35:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjKBJf0 (ORCPT ); Thu, 2 Nov 2023 05:35:26 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2E943133; Thu, 2 Nov 2023 02:35:21 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D9E12F4; Thu, 2 Nov 2023 02:36:03 -0700 (PDT) Received: from [10.57.70.106] (unknown [10.57.70.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 98A813F67D; Thu, 2 Nov 2023 02:35:19 -0700 (PDT) Message-ID: Date: Thu, 2 Nov 2023 09:35:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] coresight: etm4x: Fix width of CCITMIN field Content-Language: en-US To: Anshuman Khandual , coresight@lists.linaro.org, suzuki.poulose@arm.com Cc: stable@vger.kernel.org, Mike Leach , Alexander Shishkin , Mathieu Poirier , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231030102940.115078-1-james.clark@arm.com> From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2023 04:14, Anshuman Khandual wrote: > > > On 10/30/23 15:59, James Clark wrote: >> CCITMIN is a 12 bit field and doesn't fit in a u8, so extend it to u16. >> This probably wasn't an issue previously because values higher than 255 >> never occurred. >> >> But since commit 0f55b43dedcd ("coresight: etm: Override TRCIDR3.CCITMIN >> on errata affected cpus"), a comparison with 256 was done to enable the >> errata, generating the following W=1 build error: >> >> coresight-etm4x-core.c:1188:24: error: result of comparison of >> constant 256 with expression of type 'u8' (aka 'unsigned char') is >> always false [-Werror,-Wtautological-constant-out-of-range-compare] >> >> if (drvdata->ccitmin == 256) >> >> Cc: stable@vger.kernel.org >> Fixes: 54ff892b76c6 ("coresight: etm4x: splitting struct etmv4_drvdata") >> Signed-off-by: James Clark >> --- >> drivers/hwtracing/coresight/coresight-etm4x.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h >> index 20e2e4cb7614..da17b6c49b0f 100644 >> --- a/drivers/hwtracing/coresight/coresight-etm4x.h >> +++ b/drivers/hwtracing/coresight/coresight-etm4x.h >> @@ -1036,7 +1036,7 @@ struct etmv4_drvdata { >> u8 ctxid_size; >> u8 vmid_size; >> u8 ccsize; >> - u8 ccitmin; >> + u16 ccitmin; >> u8 s_ex_level; >> u8 ns_ex_level; >> u8 q_support; > > Thanks James, so this takes care of the Smatch static checker > warning as reported by Dan Carpenter earlier. > I didn't see that report, but it was in "[linux-next:master] BUILD REGRESSION c503e3eec382ac708ee7adf874add37b77c5d312" > Reviewed-by: Anshuman Khandual