mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Colin Ian King <colin.i.king@googlemail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] mmc: dw_mmc: exynos: Fix spelling mistake "candiates" -> candidates
Date: Thu, 28 Oct 2021 20:32:28 +0900	[thread overview]
Message-ID: <e51c552a-0cab-10c0-1242-b69ea7707863@samsung.com> (raw)
In-Reply-To: <CAPDyKFqXQwfJuU_PPrfeNwh51UkhtVFJzZ71_0R6kcVuSM3bWw@mail.gmail.com>

On 10/28/21 7:00 PM, Ulf Hansson wrote:
> On Wed, 27 Oct 2021 at 15:08, Colin Ian King
> <colin.i.king@googlemail.com> wrote:
>>
>> There are several spelling mistakes in variable names and in a dev_warn
>> message. Fix these.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
> Applied for next, thanks!

Thanks for fixing them!

Best Regards,
Jaehoon Chung

> 
> Kind regards
> Uffe
> 
> 
>> ---
>>  drivers/mmc/host/dw_mmc-exynos.c | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
>> index 1f8a3c0ddfe1..c2dd29ef45c6 100644
>> --- a/drivers/mmc/host/dw_mmc-exynos.c
>> +++ b/drivers/mmc/host/dw_mmc-exynos.c
>> @@ -442,14 +442,14 @@ static inline u8 dw_mci_exynos_move_next_clksmpl(struct dw_mci *host)
>>         return sample;
>>  }
>>
>> -static s8 dw_mci_exynos_get_best_clksmpl(u8 candiates)
>> +static s8 dw_mci_exynos_get_best_clksmpl(u8 candidates)
>>  {
>>         const u8 iter = 8;
>>         u8 __c;
>>         s8 i, loc = -1;
>>
>>         for (i = 0; i < iter; i++) {
>> -               __c = ror8(candiates, i);
>> +               __c = ror8(candidates, i);
>>                 if ((__c & 0xc7) == 0xc7) {
>>                         loc = i;
>>                         goto out;
>> @@ -457,7 +457,7 @@ static s8 dw_mci_exynos_get_best_clksmpl(u8 candiates)
>>         }
>>
>>         for (i = 0; i < iter; i++) {
>> -               __c = ror8(candiates, i);
>> +               __c = ror8(candidates, i);
>>                 if ((__c & 0x83) == 0x83) {
>>                         loc = i;
>>                         goto out;
>> @@ -466,11 +466,11 @@ static s8 dw_mci_exynos_get_best_clksmpl(u8 candiates)
>>
>>         /*
>>          * If there is no cadiates value, then it needs to return -EIO.
>> -        * If there are candiates values and don't find bset clk sample value,
>> -        * then use a first candiates clock sample value.
>> +        * If there are candidates values and don't find bset clk sample value,
>> +        * then use a first candidates clock sample value.
>>          */
>>         for (i = 0; i < iter; i++) {
>> -               __c = ror8(candiates, i);
>> +               __c = ror8(candidates, i);
>>                 if ((__c & 0x1) == 0x1) {
>>                         loc = i;
>>                         goto out;
>> @@ -485,7 +485,7 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
>>         struct dw_mci *host = slot->host;
>>         struct dw_mci_exynos_priv_data *priv = host->priv;
>>         struct mmc_host *mmc = slot->mmc;
>> -       u8 start_smpl, smpl, candiates = 0;
>> +       u8 start_smpl, smpl, candidates = 0;
>>         s8 found;
>>         int ret = 0;
>>
>> @@ -496,18 +496,18 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
>>                 smpl = dw_mci_exynos_move_next_clksmpl(host);
>>
>>                 if (!mmc_send_tuning(mmc, opcode, NULL))
>> -                       candiates |= (1 << smpl);
>> +                       candidates |= (1 << smpl);
>>
>>         } while (start_smpl != smpl);
>>
>> -       found = dw_mci_exynos_get_best_clksmpl(candiates);
>> +       found = dw_mci_exynos_get_best_clksmpl(candidates);
>>         if (found >= 0) {
>>                 dw_mci_exynos_set_clksmpl(host, found);
>>                 priv->tuned_sample = found;
>>         } else {
>>                 ret = -EIO;
>>                 dev_warn(&mmc->class_dev,
>> -                       "There is no candiates value about clksmpl!\n");
>> +                       "There is no candidates value about clksmpl!\n");
>>         }
>>
>>         return ret;
>> --
>> 2.32.0
>>
> 


      reply	other threads:[~2021-10-28 11:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 13:08 Colin Ian King
2021-10-28 10:00 ` Ulf Hansson
2021-10-28 11:32   ` Jaehoon Chung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e51c552a-0cab-10c0-1242-b69ea7707863@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=colin.i.king@googlemail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®