From: Joe Perches <joe@perches.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] checkpatch: Don't check for unified diff format in git sendemail headers
Date: Thu, 22 Feb 2024 17:01:53 -0800 [thread overview]
Message-ID: <e51c5e6fe02bcc5a487cae063fe8f440013d0ca9.camel@perches.com> (raw)
In-Reply-To: <CAGETcx-mNt+_ST0opQ=_M1ZJK1acf8Rr0VqaAUskyig5YwL_dw@mail.gmail.com>
On Thu, 2024-02-22 at 16:45 -0800, Saravana Kannan wrote:
> On Thu, Feb 22, 2024 at 12:54 AM Joe Perches <joe@perches.com> wrote:
> >
> > On Wed, 2024-02-21 at 21:15 -0800, Saravana Kannan wrote:
> > > When checkpatch is used as a git sendemail-validate hook, it's also passed
> > > in the email header for sanity check.
> >
> > Why?
> >
> > If so, why not use a front-end script to stop/remove
> > the file from being scanned by checkpatch?
>
> Sure, I could do that. But this also makes it easier for people to
> start using checkpatch. Or I can put up a git hook wrapper script in
> here for people to symlink into their .git/hooks that does this.
>
> I'd prefer the lazy route of not creating a 1 line wrapper script :)
I'd not. checkpatch is for _patches_.
Don't feed stuff to it that isn't patches and expect good results.
next prev parent reply other threads:[~2024-02-23 1:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 5:15 [PATCH 1/2] checkpatch: Don't check for 75 chars per line for create/delete mode lines Saravana Kannan
2024-02-22 5:15 ` [PATCH 2/2] checkpatch: Don't check for unified diff format in git sendemail headers Saravana Kannan
2024-02-22 8:54 ` Joe Perches
2024-02-23 0:45 ` Saravana Kannan
2024-02-23 1:01 ` Joe Perches [this message]
2024-02-23 1:10 ` Saravana Kannan
2024-02-23 1:22 ` Joe Perches
2024-02-23 19:05 ` Lukas Bulwahn
2024-04-12 4:33 ` [PATCH 1/2] checkpatch: Don't check for 75 chars per line for create/delete mode lines Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e51c5e6fe02bcc5a487cae063fe8f440013d0ca9.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®