From: "tiantao (H)" <tiantao6@huawei.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Tian Tao <tiantao6@hisilicon.com>, <airlied@linux.ie>,
<daniel@ffwll.ch>, <kraxel@redhat.com>,
<alexander.deucher@amd.com>, <tglx@linutronix.de>,
<dri-devel@lists.freedesktop.org>, <xinliang.liu@linaro.org>,
<linux-kernel@vger.kernel.org>
Cc: <linuxarm@huawei.com>
Subject: Re: [PATCH] drm/hisilicon: Delete the unused macro
Date: Tue, 29 Sep 2020 15:29:56 +0800 [thread overview]
Message-ID: <e528f881-05bb-3ec0-c0cc-a254288c8c96@huawei.com> (raw)
In-Reply-To: <b2e756df-a434-f60c-c5f5-0cbb43f00d5c@suse.de>
在 2020/9/29 15:24, Thomas Zimmermann 写道:
>
>
> Am 29.09.20 um 02:45 schrieb Tian Tao:
>> The macro PADDING is no longer used. Delete it.
>>
>> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
Thanks a lot for the timely help with the review code!
>> ---
>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
>> index 4d57ec6..b3a81da 100644
>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
>> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
>> @@ -52,8 +52,6 @@ static const struct hibmc_dislay_pll_config hibmc_pll_table[] = {
>> {1920, 1200, CRT_PLL1_HS_193MHZ, CRT_PLL2_HS_193MHZ},
>> };
>>
>> -#define PADDING(align, data) (((data) + (align) - 1) & (~((align) - 1)))
>> -
>> static int hibmc_plane_atomic_check(struct drm_plane *plane,
>> struct drm_plane_state *state)
>> {
>>
>
prev parent reply other threads:[~2020-09-29 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 0:45 Tian Tao
2020-09-29 7:24 ` Thomas Zimmermann
2020-09-29 7:29 ` tiantao (H) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e528f881-05bb-3ec0-c0cc-a254288c8c96@huawei.com \
--to=tiantao6@huawei.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=tglx@linutronix.de \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®