From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1C4B332ED0 for ; Thu, 5 Mar 2026 12:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772712082; cv=none; b=ISqZWnmHUt1aMNPQjGMZ8epKBztIDCVqyRF9L9mVN02hRENYX6juiJlFV5EDb1l2qqel0mdWAqT8fxvxNPuo6gEtua48ga5lEhvoxM4b1xv59QXnLIyrvVxk28klk74d+k9TcKvHz5psqjlnZSt5tZF5mcPbZoVusQdfn4pnuDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772712082; c=relaxed/simple; bh=zygdDX9+W+oMjvzo+XEs4zkITghAIx30y9g+SS5sjyw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=NQPiB938KACanssVzOg/ldMr4EV3lhjGn/25a6dKhCUCs7SnkHf015v2v5bCJ9YhDp37BuMnXCBsc1cQYqsjyQg/PMTRsUIFvtA64Q4WloLJAi3ZkRWUVuSoguR7ut8gg7RnA/P0rGCqEvVDlOz+cfwYpB+G7Z1uP4P/li47cGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jD6qCXHm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TfsSoF4Z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jD6qCXHm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TfsSoF4Z" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625AVv5C2401203 for ; Thu, 5 Mar 2026 12:01:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +kHJsrS+fSQ7OcWRA5LmpUsqkNxNip5EorCn4UGNqtc=; b=jD6qCXHmhRK6QZeg 0wfR1Z8/vxPdgcefMUB22eKws/TyF+3BQDo09hdYh6+ZXdzSW8jotOTwmiN1jKcG EYwFa7Js28wMLNF9uZYQhMVJ6fsJxRr+O8k+C2uam0SvGi89lHX6XJgSsGFsuQSp eRt8ThN2ab7qSl0QwgcYDUOCb2x/xOGtwHoEELW9mlQZ1B0hzi2BY3DhAdCkFFr5 Zeg3MRBGZGP0yy3Vg20MMl0zOj8mKm/BYxMYLrkZMDwf7mDLKLeiQc2MaizfHVFa 05s7YnrTWncEszyupAGF2grZwy8F1twve6NPowPUmQ0r6+D0iVL2RUo0oWSz3aME GICJvg== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cq85dg759-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 12:01:19 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-56ae2015498so10731292e0c.1 for ; Thu, 05 Mar 2026 04:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772712079; x=1773316879; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=+kHJsrS+fSQ7OcWRA5LmpUsqkNxNip5EorCn4UGNqtc=; b=TfsSoF4Zvjxi6Hr5aJyk3SCMXcZRyM1+8bLX1Og/MJ7DOA+ZlXOfo3v5Wtub/Bxnew /qQ7c3CZMlGXs7A+PaK4tsr5mAMRP3USoTAWpdRmtma2V7rIjNkG8IQXjJ5jqcHKtCSA x2ObggfpCoosDUh2XacC8hsswBCqA2Vk2qSYIlKdftiHzYbFHgLOmm9SnK9E0vT4atlT h+ZDKcO7ecpSWtN8RPBoJLbkxCUwBuuwsZ8LsrKY5430hZqso9yTKYi7KCLLDJjA2qwn lLjuM4p8jS0RtEMWh7uUcflvOm9gZYz3K56G7EFlIddV3CDVH1l8o3aD+i0b2l52UVgZ 5o6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772712079; x=1773316879; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+kHJsrS+fSQ7OcWRA5LmpUsqkNxNip5EorCn4UGNqtc=; b=KNhXZNM2Rf/HSCzR2zVx0gcpZ7DnYI6H6xyK9yJ0CU3QVdyNjRKl1sID2A7oY32WqV TtsmugP5OPN4ZnwnTmjPZqHL9BgTEiQqGocGjio9eic4u0N/eIKhW3XkEKpZDeDE1UjV YkQoT1BNNQfFSe7VW42R19OI8iFLZGgzmuM5NiKMQwCuhhIMxEes2x9+fwjIHv+WUAi6 lpQx8qcaBCo7zVJ/ubkyb6GL6XNlSWUs/jGf2yiKFRULCoIif9Kspl2P+kuJz0VNV+UQ h4SdPk0Es7befK8gUuS8vxugYiHr/kzC3GegLVeF4/wOzKuFCI5WM8clTOE4GNMkA50x wIpA== X-Forwarded-Encrypted: i=1; AJvYcCWUjyk+F1pEOAWXVhkz2xheWXnikq3Tzsts1tYi8YXzKRakWQpELzoluyT8FvHAqoMPLn4oPCtWPuY4ipc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywnnbhh0NQHht+v5no5UhFWSGZyt8gn1tn0w4Ac+Kz569ysiaj/ 6DveJ7ftVNDZzFWNQx8hoZJFde/KuzBNv2vst9imGdoAglkTd4DOHcu+pNKaqYPLMvEJn8u7zte f4CCffZElfulcPCim/aaFmCBEihWay46O0mawjhKadnFuLdeMSvIIHUitSf1AOapk2gg= X-Gm-Gg: ATEYQzxbSWXfAG0mZpp6/HdxfHFLDRWIshFMnyHwZ/REgyblBaSfZOgzUaGPmjzkBtz ugsSh5W2dq0fX6CZukIzqZEUUIQxKhyJBhL+wN3M8OKb2haCbJ3Re2RqwLSKs3bsp132OPFRLqL rk5QEJeA00OjB/nUNEWKa33aenoHhoROefuvXlHWF9CDFqsHCXP/61wNCrec/uoXNW0FppyTGRa f8PqozgUWUTkjRuenkgXemBEN8fWjw1cio3RkMPY1cE4EEXhjq/piACHlb/TGQ2YlOrmr/GXj4m 3i3zB+wktqLB3+4bNEL35S6g20/7We+qnuO1T3Gi8X4P8TSYJdB8eAzp3x0yjTnGG9dQudRLJia GBh1XkkOB7nPZ5Udd8dLuCLKSSTzmLUf1yMc6AN9+49/9w3SRyrLw5uKqxvj2xO5D55CdNPXei6 wmrNubCQiR6qfpCCyRmtTxSE+JnfU7nfSuSrL1N27n1gDx8kEieEJYswJKexwtcQDW/HfBEOxV7 CD1b3b2tTsPILz9 X-Received: by 2002:a05:6102:3f4d:b0:5ee:a6f8:f93b with SMTP id ada2fe7eead31-5ffc8bdd63emr883524137.2.1772712077260; Thu, 05 Mar 2026 04:01:17 -0800 (PST) X-Received: by 2002:a05:6102:3f4d:b0:5ee:a6f8:f93b with SMTP id ada2fe7eead31-5ffc8bdd63emr883507137.2.1772712076661; Thu, 05 Mar 2026 04:01:16 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b94172ca2dfsm34184266b.36.2026.03.05.04.01.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 04:01:15 -0800 (PST) Message-ID: Date: Thu, 5 Mar 2026 13:01:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH v4 2/2] media: i2c: mt9m114: add support for Aptina MI1040 To: Svyatoslav Ryhel , Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260305102123.17216-1-clamor95@gmail.com> <20260305102123.17216-3-clamor95@gmail.com> Content-Language: en-US, nl In-Reply-To: <20260305102123.17216-3-clamor95@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Zjf_GXasGCtsAa2Fndr_A2MJHfL0SRXc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDA5OCBTYWx0ZWRfX8yUnGTyaxu2W 6SVpLsTvwoplaJFE2G+SsmQzskMfD/ymGB+3rBxNH9hbX16B+LZ2q2IkI9WciasSMjLoiv+OBfK fuhVp6jXRmCUbDi9a2maxK9O5O18d6cRrdDREvOaNt58FnaA8uNAy4XQ59d3Grrf4tg+2eQm4AL MozbrlAJbn3ItGJiqFOCIAvFDGW1AOfs9HROo7gRzVwTLFJPmUmaN3EZHopLX4g4djthvTOnYR3 Q6cneCVtPZlBamDIgL1/7UVFFDcsPvJTu7knpPrgETVZ6ItYmKPrvdChCtFt1N7DXoYftv+A9Si CxpLftbJovh5fig+jV5B1Lx2zjFED2a+RvgSEyl9FQYAMeJ82jD1mOGgy1A3eY8KUDj/Io+l4VV JjBYUPsAYn8jxz0OaPayhWwPu7yMQArnQxVSMbPY/QXkgWaNTxmiMbbLzE3ApbSWv2IAx+vhjs9 chSiQg1EjN9wT8hv3gQ== X-Authority-Analysis: v=2.4 cv=aOb9aL9m c=1 sm=1 tr=0 ts=69a9708f cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=bTc6kqDxjHKFMN1yjnMA:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-GUID: Zjf_GXasGCtsAa2Fndr_A2MJHfL0SRXc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_04,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050098 Hi, On 5-Mar-26 11:21, Svyatoslav Ryhel wrote: > Slightly different version of MT9M114 camera module is used in a several > devices like ASUS Nexus 7 (2012) or ASUS Transformer Prime TF201 and is > called Aptina MI1040. The only difference found so far is lacking ability > to poll STATE register during power on sequence, which causes driver to > fail with time out error. Add state_standby_polling flag to diverge models > and address quirk found in MI1040. > > Signed-off-by: Svyatoslav Ryhel Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/media/i2c/mt9m114.c | 35 ++++++++++++++++++++++++++++------- > 1 file changed, 28 insertions(+), 7 deletions(-) > > diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c > index 16b0ace15813..e395e2d14e97 100644 > --- a/drivers/media/i2c/mt9m114.c > +++ b/drivers/media/i2c/mt9m114.c > @@ -368,6 +368,10 @@ > * Data Structures > */ > > +struct mt9m114_model_info { > + bool state_standby_polling; > +}; > + > enum mt9m114_format_flag { > MT9M114_FMT_FLAG_PARALLEL = BIT(0), > MT9M114_FMT_FLAG_CSI2 = BIT(1), > @@ -417,6 +421,8 @@ struct mt9m114 { > > struct v4l2_ctrl *tpg[4]; > } ifp; > + > + const struct mt9m114_model_info *info; > }; > > /* ----------------------------------------------------------------------------- > @@ -2284,9 +2290,11 @@ static int mt9m114_power_on(struct mt9m114 *sensor) > * reaches the standby mode (either initiated manually above in > * parallel mode, or automatically after reset in MIPI mode). > */ > - ret = mt9m114_poll_state(sensor, MT9M114_SYS_STATE_STANDBY); > - if (ret < 0) > - goto error_clock; > + if (sensor->info->state_standby_polling) { > + ret = mt9m114_poll_state(sensor, MT9M114_SYS_STATE_STANDBY); > + if (ret < 0) > + goto error_clock; > + } > > return 0; > > @@ -2532,6 +2540,10 @@ static int mt9m114_probe(struct i2c_client *client) > if (ret < 0) > return ret; > > + sensor->info = device_get_match_data(dev); > + if (!sensor->info) > + return -ENODEV; > + > /* Acquire clocks, GPIOs and regulators. */ > sensor->clk = devm_v4l2_sensor_clk_get(dev, NULL); > if (IS_ERR(sensor->clk)) { > @@ -2646,15 +2658,24 @@ static void mt9m114_remove(struct i2c_client *client) > pm_runtime_set_suspended(dev); > } > > +static const struct mt9m114_model_info mt9m114_models_default = { > + .state_standby_polling = true, > +}; > + > +static const struct mt9m114_model_info mt9m114_models_aptina = { > + .state_standby_polling = false, > +}; > + > static const struct of_device_id mt9m114_of_ids[] = { > - { .compatible = "onnn,mt9m114" }, > - { /* sentinel */ }, > + { .compatible = "onnn,mt9m114", .data = &mt9m114_models_default }, > + { .compatible = "aptina,mi1040", .data = &mt9m114_models_aptina }, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, mt9m114_of_ids); > > static const struct acpi_device_id mt9m114_acpi_ids[] = { > - { "INT33F0" }, > - { /* sentinel */ }, > + { "INT33F0", (kernel_ulong_t)&mt9m114_models_default }, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(acpi, mt9m114_acpi_ids); >