From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752625AbdLGVUe (ORCPT ); Thu, 7 Dec 2017 16:20:34 -0500 Received: from mout.web.de ([212.227.17.12]:55788 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752491AbdLGVUb (ORCPT ); Thu, 7 Dec 2017 16:20:31 -0500 Subject: [PATCH 2/2] serial: sccnxp: Improve a size determination in sccnxp_probe() From: SF Markus Elfring To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org References: <90e7fa7a-c0e6-4819-9fa6-fae1a71685eb@users.sourceforge.net> Message-ID: Date: Thu, 7 Dec 2017 22:20:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <90e7fa7a-c0e6-4819-9fa6-fae1a71685eb@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:DBJGhZvVDk5L+O5nYwoSd9o4Ep5ekNnSw7ApD3mnfbLHjvdAusM JFVcGHl4toTbrQpxyehspWW/4OR07Lut9u/YhXZHkhSj41eC17kbdWB70NzsDJjWXEjn63L n166qAT4/JA1nZJogljlqV+VSPLSXfDgVQveEa5tJaVcwK1w5qubEDp2g4JqbU+dAUBfyvI FmbGOPH3thtLlTwLgw+1Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:CJRzhpPdD4I=:20qczrACcFieqw4EKtR8DV TtXxy7OC4gOnoBvxmKFjRZk8piBT5Fp+bZKks1XOkd/huGggMmIitWGnk6dbhOkshMrdjOJu1 rapNKTvwqs8ATrnLK3hfCeRBjlfxy5i9sfRLW2HjSBh3whxJ9PPgvdSaBpGHdHiIJSdOCn3TP 7i5pLzqFAls4TQMJAVzf4+FNJnTuepwAcxxCvEfy5zcy6391gGN+Ic5GlaqM2Fy7iS33WxSQJ v7cQdiswd9FdWeiixnQllkft5NLZBcGvgxMkIZkX2dvtNwlqAtT4HTEqMyw/nuz/VbTrq+DjQ MW+WwVfcxRGhP1V27hhdp8cZ0PyDwPZ76iCKiVfcoUboRpsQRvjXG1dnyeP0D/9vrqPiQjZ4s QCSy/BEpXdpyDXwMDDm48dZ1iUHHX9iFS5n3S/PSo11BuzVkBcfdjJ2G5pg0AN1aibxPvOTqh Z7oC79L5tznOgFQGHOlqNzSNLTA3605K8K/+sm9XpRjjl0YIhrn9YPozRu/2o8STq+lUHtgj2 dc4+d25ldNU7DXkZvYVRW/mWjyXuwfeLymSy4i2YEdjw70k07Idv8+4a3Tl5eKw/t5e8AmhUT 3eNEH9jNGNpMe9rvKrvHXbtAszxjQopK6u+hVoWkpcHSY4faHMCjsALCqtHJex25IRvPGV0hw rIMOe6aixRpAjtETtMeWX2YKKEp2spn7wbLtR4r/okRlRYXrpgGk989rMCN7Zwt7BYEq9/Rs9 J22Wydr+dAXuTMTuQCaOWOW9vPSxvk1ABKhpkzTPbaAMWgHDV7WmKHLiTiPUcMoyN4XYeh0t0 Q3tjjtHlZAxBbnOKFQL2ps1fC0/ajsmDtPGc5sbPCiKLY+blW4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 7 Dec 2017 22:00:40 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/sccnxp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c index ba1653ba5f37..21be1fb5fd6d 100644 --- a/drivers/tty/serial/sccnxp.c +++ b/drivers/tty/serial/sccnxp.c @@ -856,7 +856,7 @@ static int sccnxp_probe(struct platform_device *pdev) if (IS_ERR(membase)) return PTR_ERR(membase); - s = devm_kzalloc(&pdev->dev, sizeof(struct sccnxp_port), GFP_KERNEL); + s = devm_kzalloc(&pdev->dev, sizeof(*s), GFP_KERNEL); if (!s) return -ENOMEM; -- 2.15.1