From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794494246; b=JWV492kKg4INTjmWCWW1J+CcQSp/iaUVUiDgZQp/buw/Qae44qe97ZfzXEp48eJZ6s56 6bG8Iqc0pLT6BvqtsZ15ZnwiGHAKTgIhwLDmzgwR2alN1tL5nYv0Vp1gZG1Uk5u+l6U/z BmtdFab2e9kqvt6d2098vQdx+Od5NeubCq4k/a1WkgOiJugYSTVtKO/fupmKG0m/1g8A4 23Lk76S0UX6mkoadWbP012dA8VzdmvcMX6Y7zJoyHtiE6ps8pL4mcgO31DmqiIYLUZXl0 AzDNKH4weSXjzWoeiCCOtpZmeqL7iemKlvu6S804x9FZ1kl1PE8OGWsKi06RQF3iVGg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794494246; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=z2wEI5VEe25LD61er33lq8AWRCY5Xe94AmrzUGTJZcI=; b=AcV4enM6u7UhPptKpKD/+NFSDhrZljza+wN9jgeEnlwu4OZoYHf4ld4NXNZHkqBbOwDF j/wgEKHp5cYbAocKputdpLjAh6CEyQk/9I6WWutOrgnDz5Xw3/EQaxeb2bIZaR3MAsQ+f t1YoYREC/+czAxyTaMAmFKa5S8ONwqAX4xevSyXl3+nyS4OT9Gq8Qq/x8o5s/KvQ2zWxX +r6FZ97TZ+3zPAah2o+D8XTpm7eUnp6qBAEhGWKspZCvMexo1g/KVau1kjEsObqxVtBLF 85tWCQ3WFeKuve2UMdPDXn7yx2ufRxXo0fq2YVAEYk+Kc+r9fO/+pUoTP6L3W3F3kxA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SYMbnKSu; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D8A8606A31C; Thu, 12 Nov 2026 14:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SYMbnKSu Received: by smtp.kernel.org (Postfix) with ESMTPSA id 362801F00A07; Thu, 12 Nov 2026 14:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794494246; bh=z2wEI5VEe25LD61er33lq8AWRCY5Xe94AmrzUGTJZcI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=SYMbnKSuEfDMxKBAUwscloPGrwixWMu0n2RND2uSvO86HoO/Mv1cEzOR1ANj49F6c jEZhCLcPrSExqFYx+aIa75j7uiJCwZmqfZj65RefavpeaEO8zGtudj+f2xOuzwDZ0l EqVWxWM41w6Il6bZwZL3hHP9AUyAQAYbWyPWdOhRE5uPkWSNK7E0Krrt7g2e1xJD5f TmM6IwjkLx+UQl/NsmE9gYZkI1cktRgZMQolMcfsoauPPj63YSp1JKchfDMQ/+33jf U65VEw/dvDA9OyhcNbewdpimey0vzO84+xil/PxP6x9TliZzjShL85SRgNKioLKWGv rK7QSouHDIVmg== Message-ID: Date: Thu, 12 Nov 2026 15:37:19 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports To: Nihal Kumar Gupta , Loic Poulain , Bryan O'Donoghue Cc: Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Conor Dooley , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh Vankadara , Vikram Sharma , Krzysztof Kozlowski References: <20261102-glymur_camss-v1-0-fcb619fc7319@oss.qualcomm.com> <539842db-c672-4549-b861-4a6f3be47556@oss.qualcomm.com> <1db9bf48-01d8-44fe-8dd2-7a3c84ecc556@kernel.org> <62fba00d-831c-44cc-8d3e-083a95abfbe8@kernel.org> <3df59469-e665-4901-b4b4-512604194ddd@kernel.org> <5e0f4424-7194-413a-af7c-f6e74d07392b@oss.qualcomm.com> <3cb96b5b-d061-4f0d-919b-09c6f336e453@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <3cb96b5b-d061-4f0d-919b-09c6f336e453@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/11/2026 15:22, Nihal Kumar Gupta wrote: > > > On 09-11-2026 11:35, Nihal Kumar Gupta wrote: >>> So yes, we could argue that the port ID itself has no inherent >>> meaning, but it acquires meaning through the convention we define, >>> since we still need a way to map DT ports to CAMSS input IDs. What is >>> really changing here is the convention used to describe that mapping. >>> So, for Hamoa, ports { 0, 1, 2, 3 } would map to CAMSS PHY inputs { 0, >>> 1, 2, 4 }, while for Glymur, ports { 0, 1, 2 } would map to CAMSS PHY >>> inputs { 0, 1, 4 }. >>> >> Thanks Loic, Bryan, Krzysztof and Vladimir for the discussion. >> >> Krzysztof, understood on the DT binding concern. I should have got clear DT >> maintainer agreement before proposing a binding semantic change, and I will >> keep that in mind for future changes. >> >> Based on the discussion, I agree that for standalone PHY CAMSS DT input ports >> should be logical and linear. For Glymur, that means using ports@0-2 { 0, 1, 2 }, >> and keep the mapping to hardware PHY indices { 0, 1, 4 } inside the driver. >> >> Krzysztof, does this direction sound aligned to you? If yes, I will respin >> accordingly and make sure the commit message documents the logical-port to >> hardware-PHY mapping clearly. >> > > Krzysztof, the Glymur CAMSS binding is already merged, but no upstream > DTS consumes it yet. The current example uses port@3 for CSIPHY4. > > For the binding, would you prefer keeping the existing "^port@[0-3]$" > range, or tightening it to "^port@[0-2]$" and using logical ports > port@0, port@1 and port@2 in the example? > Just explain in commit msg there is no port@3, because there are only three phys. Best regards, Krzysztof