From: Roger Quadros <rogerq@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <nsekhar@ti.com>, <s-anna@ti.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/4] ARM: dts: dra7: Keep usb_otg_ss3 and usb_otg_ss4 disabled
Date: Wed, 3 Apr 2019 11:38:41 +0300 [thread overview]
Message-ID: <e53664ff-4376-99eb-8fc5-ab335a59085a@ti.com> (raw)
In-Reply-To: <20190402162203.GL49658@atomide.com>
On 02/04/2019 19:22, Tony Lindgren wrote:
> * Roger Quadros <rogerq@ti.com> [190402 13:38]:
>> These 2 modules are not present on all families (e.g. AM57).
>> Keep them disabled.
>
> Can you please add comments to the dtsi file for why "disabled"
> is set? Otherwise we may end up removing them at some point as
> the default should be just enabled with no status property.
>
> If these devices are really there for some SoCs, we should
> have a separate dtsi for them.
They are there on J6 variants but not on AM5 variants.
OK. I will move them to a separate dtsi and include them in the
right variants.
The patch can be independent of this series.
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-04-03 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 13:37 [RFC PATCH 0/4] bus: ti-sysc: Add generic enable/disable & PRUSS Roger Quadros
2019-04-02 13:37 ` [RFC PATCH 1/4] ARM: dts: dra7: Keep usb_otg_ss3 and usb_otg_ss4 disabled Roger Quadros
2019-04-02 16:22 ` Tony Lindgren
2019-04-03 8:38 ` Roger Quadros [this message]
2019-04-03 14:53 ` Roger Quadros
2019-04-03 15:09 ` Tony Lindgren
2019-04-02 13:37 ` [RFC PATCH 2/4] bus: ti-sysc: Add generic enable/disable functions Roger Quadros
2019-04-02 17:14 ` Tony Lindgren
2019-04-02 13:37 ` [RFC PATCH 3/4] bus: ti-sysc: Add support for PRU-ICSS type Roger Quadros
2019-04-02 13:37 ` [RFC PATCH 4/4] bus: ti-sysc: Ensure PRU-ICSS doesn't break suspend/resume Roger Quadros
2019-04-02 16:57 ` Tony Lindgren
2019-04-03 8:46 ` Roger Quadros
2019-04-02 13:39 ` [RFC PATCH 0/4] bus: ti-sysc: Add generic enable/disable & PRUSS Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e53664ff-4376-99eb-8fc5-ab335a59085a@ti.com \
--to=rogerq@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®